Re: [PATCHES] options for RAISE statement

2008-05-13 Thread Pavel Stehule
2008/5/14 Tom Lane <[EMAIL PROTECTED]>: > "Pavel Stehule" <[EMAIL PROTECTED]> writes: >> I am sending enhanced version of original patch. > > Applied with syntax revisions as per pghackers discussion. thank you > > I made a couple of other changes too: I took out the restriction against > throwing

Re: [PATCHES] options for RAISE statement

2008-05-13 Thread Tom Lane
"Pavel Stehule" <[EMAIL PROTECTED]> writes: > I am sending enhanced version of original patch. Applied with syntax revisions as per pghackers discussion. I made a couple of other changes too: I took out the restriction against throwing codes that are category codes, and instead just documented th

Re: [PATCHES] options for RAISE statement

2008-05-12 Thread Pavel Stehule
I am sent two less dependend patch (both modify same files): COPY and RAISE USING. I am sorry, but I can't to know what commiters will be apply first. Problem is mainly in regress files because I append regress test on end of files. But boths are really generated from current HEAD. Regards Pavel S

Re: [PATCHES] options for RAISE statement

2008-05-11 Thread Tom Lane
"Pavel Stehule" <[EMAIL PROTECTED]> writes: > I am sending enhanced version of original patch. Hmm ... this patch seems to have been generated against something significantly different from HEAD ... was that intentional? patching file plpgsql.sgml Hunk #1 succeeded at 2102 (offset -82 lines). Hun

Re: [PATCHES] options for RAISE statement

2008-05-09 Thread Pavel Stehule
Hello I am sending enhanced version of original patch. 2008/5/5 Tom Lane <[EMAIL PROTECTED]>: > "Pavel Stehule" <[EMAIL PROTECTED]> writes: >> this patch adds possibility to set additional options (SQLSTATE, >> DETAIL, DETAIL_LOG and HINT) for RAISE statement, > > I looked this over briefly. A

Re: [PATCHES] options for RAISE statement

2008-05-04 Thread Pavel Stehule
Hello I thing, all your comments are not problem. I'll send new version this week. Thank You Pavel Stehule 2008/5/5 Tom Lane <[EMAIL PROTECTED]>: > "Pavel Stehule" <[EMAIL PROTECTED]> writes: >> this patch adds possibility to set additional options (SQLSTATE, >> DETAIL, DETAIL_LOG and HINT) for

Re: [PATCHES] options for RAISE statement

2008-05-04 Thread Tom Lane
"Pavel Stehule" <[EMAIL PROTECTED]> writes: > this patch adds possibility to set additional options (SQLSTATE, > DETAIL, DETAIL_LOG and HINT) for RAISE statement, I looked this over briefly. A couple of comments: * Raising errors via hard-coded SQLSTATEs seems pretty unfriendly, at least for cas

Re: [PATCHES] options for RAISE statement

2008-04-16 Thread Alvaro Herrera
Pavel Stehule escribió: > Hello > > this patch adds possibility to set additional options (SQLSTATE, > DETAIL, DETAIL_LOG and HINT) for RAISE statement, Added to May commitfest page, thanks. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company -