Re: [PATCHES] patch for temporary view from TODO list

2005-02-01 Thread Neil Conway
On Wed, 2005-02-02 at 00:39 -0500, Tom Lane wrote: > isViewOnTempTable_walker. If that isn't euphonious to you, then change > the name of isViewOnTempTable. Everywhere else that we have walker > subroutines, foo() invokes foo_walker(). You need a seriously good reason > to deviate from that conv

Re: [PATCHES] patch for temporary view from TODO list

2005-02-01 Thread Neil Conway
On Wed, 2005-02-02 at 00:39 -0500, Tom Lane wrote: > Maybe I'm reading the wrong thing, but the only uses of CASCADED-with- > a-D that I see in the spec are in the context of WITH CHECK OPTION, > which this patch does not implement. Precisely; prior to the patch, WITH CHECK OPTION was documented i

Re: [PATCHES] patch for temporary view from TODO list

2005-02-01 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > On Tue, 2005-02-01 at 01:28 -0500, Tom Lane wrote: >> The references to "CASCADED" (sic) in the patch are surely bogus. > Per SQL:2003 section 11.22, it is spelt "CASCADED". Maybe I'm reading the wrong thing, but the only uses of CASCADED-with- a-D that I

Re: [PATCHES] patch for temporary view from TODO list

2005-02-01 Thread Neil Conway
On Tue, 2005-02-01 at 01:28 -0500, Tom Lane wrote: > The references to "CASCADED" (sic) in the patch are surely bogus. Per SQL:2003 section 11.22, it is spelt "CASCADED". I'm not sure there's a whole lot of value in documenting syntax we don't support, but if we're going to do it we may as well ge

Re: [PATCHES] patch for temporary view from TODO list

2005-01-31 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > On Mon, 2004-09-27 at 09:39 +1000, Koju Iijima wrote: >> I have implemented temporary view related items as I proposed few days ago. >> http://archives.postgresql.org/pgsql-hackers/2004-09/msg00682.php > Barring any objections, I'll apply this patch tomorr

Re: [PATCHES] patch for temporary view from TODO list

2005-01-31 Thread Neil Conway
On Mon, 2004-09-27 at 09:39 +1000, Koju Iijima wrote: > I have implemented temporary view related items as I proposed few days ago. > http://archives.postgresql.org/pgsql-hackers/2004-09/msg00682.php Barring any objections, I'll apply this patch tomorrow. -Neil ---(end

Re: [PATCHES] patch for temporary view from TODO list

2004-10-08 Thread Bruce Momjian
This has been saved for the 8.1 release: http:/momjian.postgresql.org/cgi-bin/pgpatches2 --- Koju Iijima wrote: > Dear community, > > I have implemented temporary view related items as I proposed few days ago. > ht