Re: [PATCHES] pg_ctl -D canonicalization

2004-10-28 Thread Magnus Hagander
Thanks. I can confirm that this fixes the issue. //Magnus >-Original Message- >From: Bruce Momjian [mailto:[EMAIL PROTECTED] >Sent: den 27 oktober 2004 19:17 >To: Magnus Hagander >Cc: [EMAIL PROTECTED] >Subject: Re: [PATCHES] pg_ctl -D canonicalization > > >

Re: [PATCHES] pg_ctl -D canonicalization

2004-10-27 Thread Bruce Momjian
OK, attached patch applied. Your original patch didn't canonicalize the PGDATA environment variable. '-D' takes precidence but it should be accurate. I also updated the comments in canonicalize_path because it does a lot more now that just win to unix path conversion. -

Re: [PATCHES] pg_ctl -D canonicalization

2004-10-27 Thread Magnus Hagander
> > It seems pg_ctl calls canonicalize_path() only on the path as being > > used to access for example the pid file, and not the path > that is sent > > along to the postmaster. > > Specifically, this causes failure on win32 when a path is > passed with > > a trailing backslash, when it's insi

Re: [PATCHES] pg_ctl -D canonicalization

2004-10-26 Thread Bruce Momjian
Magnus Hagander wrote: > It seems pg_ctl calls canonicalize_path() only on the path as being used > to access for example the pid file, and not the path that is sent along > to the postmaster. > Specifically, this causes failure on win32 when a path is passed with a > trailing backslash, when it's