[PATCHES] costly foreign key ri checks (4)

2004-03-09 Thread Fabien COELHO
Dear patchers, Following the discussion about previous versions of this patch, please find attached a new patch candidate for warning about costly foreign key referential integrity checks. 1/ it generates a WARNING 2/ it DETAILs the attributes and types 3/ some regression tests are also append

Re: [PATCHES] minor doc work

2004-03-09 Thread Peter Eisentraut
Neil Conway wrote: > If SET is allowed, it overrides all other sources of > ! values for the parameter. Superusers are allowed to > ! SET more values than ordinary users. Some parameters > ! cannot be SET even by superusers: for example, Please don't use marked up command names

Re: [PATCHES] minor doc work

2004-03-09 Thread Neil Conway
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Please don't use marked up command names as verbs. Next week you'll > be UPDATEing or something. The existing documentation does this -- indeed, the very section of the docs that I modified *already* did it: If SET is allowed, it overrides all

[PATCHES] PSQLRC environment variable.

2004-03-09 Thread James Tanis
In the tradition of telnet, xinit, and others, I've created a patch which allows users to override the location of .psqlrc by setting the PSQLRC environment variable. I occurs to me that you have probably considered this and the fact that it is not implemented suggests that you have rejected the i

Re: [PATCHES] notice about costly ri checks (2)

2004-03-09 Thread Fabien COELHO
> > As a side question, if there are multiple cross-type conversions in one > > constraint on different column pairs, what do we think the message should > > be? One message with multiple column mentions in detail or multiple > > notices? (I haven't looked at the patch to see if one or the other

Re: [PATCHES] [GENERAL] dblink: rollback transaction

2004-03-09 Thread Oleg Lebedev
Joe, I applied the patch to 7.4.1 on RH Linux 8.0 and it works great. Thanks. Oleg -Original Message- From: Joe Conway [mailto:[EMAIL PROTECTED] Sent: Thursday, March 04, 2004 11:12 PM To: [EMAIL PROTECTED] Cc: Tom Lane; Oleg Lebedev Subject: Re: [PATCHES] [GENERAL] dblink: rollback tr

[PATCHES] Alter table Patch

2004-03-09 Thread Rod Taylor
This patch seems to have fallen off of Bruces "To be applied" list without being applied. Could I get a status report? http://archives.postgresql.org/pgsql-patches/2003-11/msg00222.php -- Rod Taylor Build A Brighter Lamp :: Linux Apache {middleware} PostgreSQL PGP Key: http://www.rbt.ca/signat

Re: [PATCHES] "ALSO" keyword to "CREATE RULE" patch

2004-03-09 Thread Fabien COELHO
> I thought the syntax came from Berkeley. We can add ALSO if folks like > it. I can't think of cases where we have keywords for both on and off > behavior, and allow a default if the keyword is missing. ALTER TABLE ... DROP CONSTRAINT ... [ RESTRICT | CASCADE ] CREATE TABLE ... [ WITH OIDS |

Re: [PATCHES] PSQLRC environment variable.

2004-03-09 Thread Tom Lane
James Tanis <[EMAIL PROTECTED]> writes: > In the tradition of telnet, xinit, and others, I've created a patch which > allows users to override the location of .psqlrc by setting the PSQLRC > environment variable. Uh, why is that a good idea? regards, tom lane

Re: [PATCHES] PSQLRC environment variable.

2004-03-09 Thread Bruce Momjian
Seems like a nice feature to me. --- James Tanis wrote: > > In the tradition of telnet, xinit, and others, I've created a patch which > allows users to override the location of .psqlrc by setting the PSQLRC > environment va

Re: [PATCHES] PSQLRC environment variable.

2004-03-09 Thread Bruce Momjian
Tom Lane wrote: > James Tanis <[EMAIL PROTECTED]> writes: > > In the tradition of telnet, xinit, and others, I've created a patch which > > allows users to override the location of .psqlrc by setting the PSQLRC > > environment variable. > > Uh, why is that a good idea? Well, suppose you want all

Re: [PATCHES] PSQLRC environment variable.

2004-03-09 Thread Tom Lane
James Tanis <[EMAIL PROTECTED]> writes: > In message <[EMAIL PROTECTED]>, Tom Lane avows: >> Uh, why is that a good idea? > As you will see, it takes a pretty contrived situation, but indeed I've got > one :-) > I have a software system which can use postgres if the user so wishes. We > have a wr

Re: [PATCHES] PSQLRC environment variable.

2004-03-09 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> Uh, why is that a good idea? > Well, suppose you want all your users to use the same psqlrc file. > Instead of creating symlinks for every user, you can just set PSQLRC in > /etc/profile and everyone gets it. ... but people who want

[PATCHES] Initial Review of Copy Command Patch

2004-03-09 Thread mike g
Hello, I thought I would try and knock off the "count number of rows inserted when using the Copy command" from the todo list. The attached diff works for me on non-binary files using latest cvs It seems though that I am making a redundant elog(INFO) call though. If I run gmake check the Copy

Re: [PATCHES] Initial Review of Copy Command Patch

2004-03-09 Thread Tom Lane
mike g <[EMAIL PROTECTED]> writes: > I thought I would try and knock off the "count number of rows inserted > when using the Copy command" from the todo list. I think what was envisioned was adding a field to the COPY command tag returned at command completion. Sending an INFO message seems way t

[PATCHES] initdb could use some lower default settings (trivial patch)

2004-03-09 Thread evanm
Installing postgres on a Solaris 8 system for personal use, I discovered that initdb exceeded the shared memory available on my system (Default settings). There's enough to run the database, but initdb doesn't probe to low enough values: for nconns in 100 50 40 30 20 10 for nbuffers in 1000 900 80

Re: [PATCHES] [BUGS] initdb could use some lower default settings (trivial patch)

2004-03-09 Thread Tom Lane
[EMAIL PROTECTED] writes: > 10/50 is too large, the largest Solaris can handle without changing the > defaults is 10/46. I think it'd be a good idea if initdb probed at least a > little lower here, say to a buffer size of 25, to let it install on Solaris > with default shmem settings. Actually, I'