[PATCHES] new aggregate functions v3

2004-05-06 Thread Fabien COELHO
Dear patchers, please find attached my third patch submission for adding new aggregate functions. This new version adds a note and some indexes in the documentation about sql standard names for bool_and and bool_or, as suggested by Robert Treat. It also fixes conflicts created by the removal of s

Re: [PATCHES] Function to do runtime relative directory mapping

2004-05-06 Thread Tony Reina
[EMAIL PROTECTED] (Bruce Momjian) wrote in message > extern void canonicalize_path(char *path); > + #ifndef WIN32 > + #define ISSEP(c)((c) == '/') > + #else > + #define ISSEP(c)((c) == '/' || (c) == '\\') > + #endif I've seen references to this "canonicalization" of the Windows \ chara

Re: [PATCHES] Function to do runtime relative directory mapping

2004-05-06 Thread Andrew Dunstan
Tony Reina said: > [EMAIL PROTECTED] (Bruce Momjian) wrote in message > extern void > canonicalize_path(char *path); >> + #ifndef WIN32 >> + #define ISSEP(c) ((c) == '/') >> + #else >> + #define ISSEP(c) ((c) == '/' || (c) == '\\') >> + #endif > > > I've seen references to this "canonicalizat

Re: [PATCHES] Dollar Quoting doc patch--resend.

2004-05-06 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > On 6-May-04, at 12:41 AM, Bruce Momjian wrote: >> OK. I am just afraid if we show 4 functions, and three use $$, and one >> doesn't use single-quotes inside, so we quote with single-quotes, that >> it would look strange. > Personally I don't think it woul

Re: [PATCHES] Dollar Quoting doc patch--resend.

2004-05-06 Thread Bruce Momjian
Tom Lane wrote: > Neil Conway <[EMAIL PROTECTED]> writes: > > On 6-May-04, at 12:41 AM, Bruce Momjian wrote: > >> OK. I am just afraid if we show 4 functions, and three use $$, and one > >> doesn't use single-quotes inside, so we quote with single-quotes, that > >> it would look strange. > > > Pe

Re: [PATCHES] thread

2004-05-06 Thread Bruce Momjian
Sorry I sent this email to the lists by accident. I meant to send it just to Magnus. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.

[PATCHES] thread

2004-05-06 Thread Bruce Momjian
Here is the email I have. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 >From [EMAIL PR

Re: [PATCHES] [BUGS] BUG #1134: ALTER USER ... RENAME breaks md5 passwords

2004-05-06 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > The attached patch clears the password field on rename: > > I think you should clear the password field *only* if it's > MD5-encrypted. Patch attached and applied. -- Bruce Momjian| http://candle.pha.pa.u

Re: [PATCHES] [BUGS] BUG #1134: ALTER USER ... RENAME breaks md5 passwords

2004-05-06 Thread Bruce Momjian
Bruce Momjian wrote: > Tom Lane wrote: > > Bruce Momjian <[EMAIL PROTECTED]> writes: > > > The attached patch clears the password field on rename: > > > > I think you should clear the password field *only* if it's > > MD5-encrypted. > > Patch attached and applied. Oh, I forgot to display the new

Re: [PATCHES] win32: whitespace in dir names, shmem bug

2004-05-06 Thread Bruce Momjian
Patch applied. Thanks. --- Claudio Natoli wrote: > > For application to HEAD, following community review. > > sysv_shmem.c patch is to correct a bug that prevents the postmaster > recovering from an unexpected backend te

Re: [PATCHES] Alter Table phase 1 -- Please apply to 7.5

2004-05-06 Thread Bruce Momjian
Patch applied with adjustments by Tom. Thanks. --- Rod Taylor wrote: > Completes: > ALTER TABLE ADD COLUMN does not honour DEFAULT and non-CHECK > CONSTRAINT > > ALTER TABLE ADD COLUMN column DEFAUL

[PATCHES] refactor CheckDropPermissions()

2004-05-06 Thread Neil Conway
This patch makes a minor tweak to CheckDropPermissions(): it moves some initialization code for reporting errors out of the "common case" code path. I think that results in a small win in both readability and performance. Barring any objections, I intend to apply this patch within 24 hours. -Ne

Re: [PATCHES] [BUGS] BUG #1148: server restarts depending on stats options

2004-05-06 Thread Bruce Momjian
I have applied the attached patch to fix this problem. Sample output is: test=> set log_statement_stats = true; SET test=> set log_parser_stats = true; ERROR: Can not enable parameter when "log_statement_stats" is true. test=> begin; BEGIN