Re: [PATCHES] contrib/ sparse code cleanup

2004-11-05 Thread Oleg Bartunov
Neil, go ahead ! Oleg On Fri, 5 Nov 2004, Neil Conway wrote: [ Oleg, I've CC'd you because this patch makes some modifications, albeit trivial ones, to tsearch2; let me know if you object to me applying it ] This patch makes some cleanups to contrib/ to silence some sparse warnings: - remov

[PATCHES] contrib/xml2: add function xml_encode_special_chars

2004-11-05 Thread Markus Bertheau
Hi, attached is a patch that adds the function xml_encode_special_chars to the xml2 contrib module. It's against 8.0beta4. It's intended for commit. I would have CC'ed the author, John Gray, but I was unable to find his email address. -- Markus Bertheau <[EMAIL PROTECTED]> ÐÐÐÑÐÐ Ð postgresql-8

Re: [PATCHES] [HACKERS] CVS should die (was: Possible make_oidjoins_check ...)

2004-11-05 Thread David Helgason
The intuitive understanding of a file is certainly something like "a file called 'baz.c' residing at 'foo/bar/', which contains the BAZ subsystem". Now, when renaming/moving a file such an intuitive understanding is partially lost. UI-wise that's a problem which I haven't ever seen solved well.

Re: [PATCHES] CVS should die

2004-11-05 Thread Thomas Hallgren
Joerg Hessdoerfer wrote: Yes, some do. At least SVN (Subversion) can handle moves very well, and especially it doesn't loose history on moves/renames. SVN holds it's repo entries in a database like 'filesystem', which can be backed by BDB4 or flat files (as of 1.1). SVN has proven to be stable i

Re: [PATCHES] CVS should die

2004-11-05 Thread Neil Conway
Thomas Hallgren wrote: Another compelling reason to use SVN is that one of their long term goals is to use an SQL backend. That is about as far from a "compelling reason" to use a particular version control system as I can imagine. -Neil ---(end of broadcast)-

Re: [PATCHES] GiST: memory allocation, cleanup

2004-11-05 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Attached is a patch that makes some cleanups and improvements to GiST, > as well as a few semi-related cleanups. Changes: > ... > QUESTION: given a ScanKey for an index scan, GiST overwrites the > ScanKey's sk_func to point to the user-defined Consistent m

Re: [PATCHES] GiST: memory allocation, cleanup

2004-11-05 Thread Alvaro Herrera
On Fri, Nov 05, 2004 at 04:41:00PM +1100, Neil Conway wrote: > Comments welcome. I would like to apply this to 8.1 at some point after > we branch for 8.0. I thought I would post this patch to get some > feedback before starting on further GiST work (speculatively, adding > support for concurrency

Re: [PATCHES] GiST: memory allocation, cleanup

2004-11-05 Thread Neil Conway
Alvaro Herrera wrote: What are you going to base your concurrency work on? I wonder because I skimmed through Marcel Kornacker's theses, and for example it mentioned use of predicate locking (among other interesting things). Do you have any ideas yet on how to handle that? I've read a paper[1] on

Re: [PATCHES] contrib/xml2: add function xml_encode_special_chars

2004-11-05 Thread Markus Bertheau
Ð ÐÐÑ, 06.11.2004, Ð 01:24, Peter Eisentraut ÐÐÑÐÑ: > Markus Bertheau wrote: > > attached is a patch that adds the function xml_encode_special_chars > > to the xml2 contrib module. It's against 8.0beta4. It's intended for > > commit. > > Would you also tell us what this function does? It calls th

Re: [PATCHES] contrib/xml2: add function xml_encode_special_chars

2004-11-05 Thread Peter Eisentraut
Markus Bertheau wrote: > attached is a patch that adds the function xml_encode_special_chars > to the xml2 contrib module. It's against 8.0beta4. It's intended for > commit. Would you also tell us what this function does? -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---

[PATCHES] yet another .exe path fix

2004-11-05 Thread Andrew Dunstan
The "adjustments" made to my previous patch to remove a trailing .exe from get_progname()'s result broke it. The attached patch, which I have tested, fixes the breakage. cheers andrew Index: src/port/path.c === RCS file: /home/cvsmi

Re: [PATCHES] yet another .exe path fix

2004-11-05 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > The "adjustments" made to my previous patch to remove a trailing .exe > from get_progname()'s result broke it. The attached patch, which I have > tested, fixes the breakage. Applied. regards, tom lane

[PATCHES] psql \! WIN32 cleanup

2004-11-05 Thread Bruce Momjian
The attached applied patch tests for COMSPEC in the right place and supplies a reasonable shell default on Win32. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road +

[PATCHES] ON COMMIT and foreign keys

2004-11-05 Thread Alvaro Herrera
Hackers, There's a bug with temporary tables signalled ON COMMIT DELETE ROWS, when they contain foreign key references. An example: alvherre=# begin; BEGIN alvherre=# CREATE TEMP TABLE foo (a int PRIMARY KEY) ON COMMIT DELETE ROWS; NOTICE: CREATE TABLE / PRIMARY KEY will create implicit index "

Re: [PATCHES] ON COMMIT and foreign keys

2004-11-05 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Incidentally ("collateral damage"), the patch modifies the TRUNCATE > command so that it can work on multiple tables. In particular, if > foreign key references are all internal to the group that's being > truncated, the command is allowed. I think thi

Re: [PATCHES] psql \! WIN32 cleanup

2004-11-05 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > The attached applied patch tests for COMSPEC in the right place and > supplies a reasonable shell default on Win32. > + #define DEFAULT_SHELL "c:/windows/system32/cmd.exe" Is it really a good idea to assume that the Windows installation is on drive C: ?

Re: [PATCHES] psql \! WIN32 cleanup

2004-11-05 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > The attached applied patch tests for COMSPEC in the right place and > > supplies a reasonable shell default on Win32. > > > + #define DEFAULT_SHELL "c:/windows/system32/cmd.exe" > > Is it really a good idea to assume that the Windows

Re: [PATCHES] ON COMMIT and foreign keys

2004-11-05 Thread Bruce Momjian
Bruce Momjian wrote: > Tom Lane wrote: > > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > > Incidentally ("collateral damage"), the patch modifies the TRUNCATE > > > command so that it can work on multiple tables. In particular, if > > > foreign key references are all internal to the group that's

Re: [PATCHES] ON COMMIT and foreign keys

2004-11-05 Thread Bruce Momjian
Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > Incidentally ("collateral damage"), the patch modifies the TRUNCATE > > command so that it can work on multiple tables. In particular, if > > foreign key references are all internal to the group that's being > > truncated, the comman