Magnus Hagander wrote:
We have the following warning on Windows:
pgarch.c:349: warning: implicit declaration of function `sleep'
To fix it we could include the right header (which appears to be
in the Windows/Mingw case), or we could replace
the call by
a call to pg_usleep()
On Sun, 07 Nov 2004 13:03:33 +, Simon Riggs wrote:
> On Sun, 2004-11-07 at 12:56, Markus Bertheau wrote:
>> В Вск, 07.11.2004, в 09:33, Simon Riggs пишет:
>> > On Sat, 2004-11-06 at 23:42, Markus Bertheau wrote:
>> > > В Сбт, 06.11.2004, в 23:13, Simon Riggs пишет:
>> > > > On Sat, 2004-11-06
Yet another fix for a useless compile warning. This one is slightly ugly ;-(
cheers
andrew
Index: src/bin/pg_dump/pg_backup_tar.c
===
RCS file: /home/cvsmirror/pgsql/src/bin/pg_dump/pg_backup_tar.c,v
retrieving revision 1.45
diff -c -
Andrew Dunstan <[EMAIL PROTECTED]> writes:
> Yet another fix for a useless compile warning. This one is slightly ugly ;-(
Why not use off_t in the first place?
regards, tom lane
---(end of broadcast)---
TIP 7: don't forget t
Simon Riggs <[EMAIL PROTECTED]> writes:
> A range of minor enhancements, plus some stronger doc around:
> - warnings about overwrites
> - additional documentation of recovery.conf parameters
Applied with some editorialization.
regards, tom lane
---
Andrew Dunstan wrote:
> Yet another fix for a useless compile warning. This one is slightly
> ugly ;-(
First of all, ugly code needs to be documented in the code.
Then, the diff
+ #ifdef INT64_IS_BUSTED
if (th->fileLen > MAX_TAR_MEMBER_FILELEN)
+ #else
+ if (((int64) th->fileLen -1
Peter Eisentraut wrote:
Andrew Dunstan wrote:
Yet another fix for a useless compile warning. This one is slightly
ugly ;-(
First of all, ugly code needs to be documented in the code.
Ok. Perhaps code that is expected to generate warnings should be too ;-)
Then, the diff
+ #ifdef INT64_I
Andrew Dunstan wrote:
> ISTM that what is happening here is that the compiler is smart enough
> to know that what is in MAX_TAR_MEMBER_FILELEN can't be exceeded by
> any possible value of type off_t.
Yeah, I think off_t is only 32 bits there. Then using INT64_IS_BUSTED
as conditional is really m
Peter Eisentraut wrote:
Andrew Dunstan wrote:
ISTM that what is happening here is that the compiler is smart enough
to know that what is in MAX_TAR_MEMBER_FILELEN can't be exceeded by
any possible value of type off_t.
Yeah, I think off_t is only 32 bits there. Then using INT64_IS_BUSTED
This patch makes the following changes to GiST:
- refactor the code to keep a pin on the buffer currently being examined
by a GiST index scan. This avoids the need to invoke ReadBuffer() for
each tuple produced by the scan; this should result in a performance
improvement.
- add support for index
On Fri, 2004-11-05 at 15:21, Neil Conway wrote:
> This patch makes some cleanups to contrib/ to silence some sparse
> warnings
Applied.
-Neil
---(end of broadcast)---
TIP 8: explain analyze is your friend
On Sun, 2004-11-07 at 11:33, Alvaro Herrera wrote:
> Since the behavior previously known as install-all-headers is now the
> default, there's no point in keeping that target. This patch removes it.
Looks good -- applied.
Note that I believe pre-7.1 would put these extra headers in a different
pl
12 matches
Mail list logo
