Re: [PATCHES] [PATCH] Add support for IS NULL to btree indexes

2005-09-20 Thread Martijn van Oosterhout
On Mon, Sep 19, 2005 at 04:33:27PM -0400, Tom Lane wrote: > This is a bad idea, because it translates "x IS NULL" into "x = NULL" > which is under no circumstances the same thing. It might coincidentally > fail to malfunction for btree indexes, depending on the specifics of the > "=" operator in u

[PATCHES] Multiple -t options for pg_dump

2005-09-20 Thread David Fetter
Folks, Please find enclosed a patch against CVS TIP that allows people to specify more than one table via pg_dump -t. Cheers, D -- David Fetter [EMAIL PROTECTED] http://fetter.org/ phone: +1 510 893 6100 mobile: +1 415 235 3778 Remember to vote! Index: doc/src/sgml/ref/pg_dump.sgml ==

Re: [PATCHES] Multiple -t options for pg_dump

2005-09-20 Thread Neil Conway
A few minor comments are below. This is for 8.2, right? On Tue, 2005-20-09 at 08:51 -0700, David Fetter wrote: > /* obsolete as of 7.3: */ > static Oidg_last_builtin_oid; /* value of the last builtin oid > */ > > ! static char **selectTableNames = NULL;/* name(s) of > specified

Re: [PATCHES] Multiple -t options for pg_dump

2005-09-20 Thread David Fetter
On Tue, Sep 20, 2005 at 12:15:23PM -0400, Neil Conway wrote: > A few minor comments are below. This is for 8.2, right? I am hoping to make a case for inclusion in 8.1. The code is completely isolated in one command and does not affect anyone who does not use the new features. > On Tue, 2005-20-0

Re: [PATCHES] Multiple -t options for pg_dump

2005-09-20 Thread Neil Conway
On Tue, 2005-20-09 at 11:33 -0700, David Fetter wrote: > I am hoping to make a case for inclusion in 8.1. The code is > completely isolated in one command and does not affect anyone who > does not use the new features. On those grounds we could include a lot of new features during the 8.1 beta pe

Re: [PATCHES] [PORTS] Solaris - psql returns 0 instead of 1 for file not found.

2005-09-20 Thread Bruce Momjian
I have applied the following patch to 8.1beta and 8.0.X to return the proper failure value for a psql -f filename open failure. The bug was that process_file() was returning false for failure, while the call site expected MainLoop() return values, meaning false/0 was success. ---

Re: [PATCHES] Multiple -t options for pg_dump

2005-09-20 Thread Alvaro Herrera
On Tue, Sep 20, 2005 at 11:33:39AM -0700, David Fetter wrote: > On Tue, Sep 20, 2005 at 12:15:23PM -0400, Neil Conway wrote: > > A few minor comments are below. This is for 8.2, right? > > I am hoping to make a case for inclusion in 8.1. The code is > completely isolated in one command and does n

Re: [PATCHES] Bug in psql (on_error_rollback)

2005-09-20 Thread Bruce Momjian
Good patch. You are right that the original code did not consider that AUTOCOMMIT would change the transaction state seen by the ON_ERROR_ROLLBACK check. Fixed in CVS. ON_ERROR_ROLLBACK was not in 8.0.X so no need to backpatch. ---

Re: [PATCHES] Multiple -t options for pg_dump

2005-09-20 Thread Tom Lane
David Fetter <[EMAIL PROTECTED]> writes: > I am hoping to make a case for inclusion in 8.1. We are months past feature freeze. Don't waste your breath. regards, tom lane ---(end of broadcast)--- TIP 3: Have you checked our

Re: [PATCHES] Multiple -t options for pg_dump

2005-09-20 Thread David Fetter
On Tue, Sep 20, 2005 at 05:55:52PM -0400, Tom Lane wrote: > David Fetter <[EMAIL PROTECTED]> writes: > > I am hoping to make a case for inclusion in 8.1. > > We are months past feature freeze. Don't waste your breath. OK, I won't. Cheers, D -- David Fetter [EMAIL PROTECTED] http://fetter.org/