Re: [PATCHES] [HACKERS] Kerberos brokenness and oops question in 8.1beta2

2005-10-15 Thread Magnus Hagander
> Now, our code has been modified since his patch was applied, > but we now > have: > > /* > * If no hostname was specified, pg_krb_server_hostname is already > * NULL. If it's set to blank, force it to NULL. > */ > khostname = pg_krb_server_hostname; > if (khostname &&

Re: [PATCHES] [HACKERS] Kerberos brokenness and oops question in 8.1beta2

2005-10-15 Thread Bruce Momjian
Magnus Hagander wrote: > Previously, we set pg_krb5_server to NULL, which is something completely > different than pg_krb_srvname=NULL (yes, they are named very closely, > but they are completely different things). krb5_sname_to_principal() > was never called. > > This is what wasn't working for

Re: [PATCHES] [HACKERS] Kerberos brokenness and oops question in 8.1beta2

2005-10-15 Thread Tom Lane
Bruce Momjian writes: > Magnus Hagander wrote: >> This is not correct. >> The default is *not* "localhost". It's the "local host name". As in >> what's returned by gethostname(). > Ah, local host name, not localhost. Poor wording. Text updated: > If not set, the default is the server hos

Re: [PATCHES] [HACKERS] Kerberos brokenness and oops question in 8.1beta2

2005-10-15 Thread Magnus Hagander
> > Previously, we set pg_krb5_server to NULL, which is something > > completely different than pg_krb_srvname=NULL (yes, they are named > > very closely, but they are completely different things). > > krb5_sname_to_principal() was never called. > > > > This is what wasn't working for me. > >

Re: [PATCHES] Documentation typos

2005-10-15 Thread Neil Conway
On Thu, 2005-13-10 at 00:39 -0600, Michael Fuhr wrote: > Correct several typos in the documentation. Applied to HEAD -- thanks for the patch. I also removed the comment from the cvs.sgml file. -Neil ---(end of broadcast)--- TIP 9: In versions be

Re: [PATCHES] [HACKERS] Kerberos brokenness and oops question in 8.1beta2

2005-10-15 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Magnus Hagander wrote: > >> This is not correct. > >> The default is *not* "localhost". It's the "local host name". As in > >> what's returned by gethostname(). > > > Ah, local host name, not localhost. Poor wording. Text updated: > > > If not se

Re: [PATCHES] [HACKERS] roundoff problem in time datatype

2005-10-15 Thread Neil Conway
On Thu, 2005-13-10 at 22:54 -0400, Bruce Momjian wrote: > I have written the attached patch which I think does what you suggested. > I found all the places where we disallowed 24:00:00, and make it valid, > including nabstime.c. Should this be added to the regression tests? -Neil -

Re: [PATCHES] [HACKERS] Patching dblink.c to avoid warning about

2005-10-15 Thread Joe Conway
Bruce Momjian wrote: No problem -- thanks. I have slimmed down the patch by applying the cosmetic parts to CVS. Use the URL above to get the newest versions of the dblink.c and regression changes. Here is my counter-proposal to Bruce's dblink patch. Any comments? Is it too late to apply thi