Re: [PATCHES] [HACKERS] Should libedit be preferred to libreadline?

2005-12-03 Thread Peter Eisentraut
Bruce Momjian wrote: In any case please be consistent about the capitalization ... OK, updated text: --with-openssl build with OpenSSL support --with-libedit-preferred prefer Libedit over Libreadline --without-readline do not use Libreadline/Libedit line editing

Re: [PATCHES] [HACKERS] Should libedit be preferred to libreadline?

2005-12-03 Thread Bruce Momjian
Peter Eisentraut wrote: Bruce Momjian wrote: In any case please be consistent about the capitalization ... OK, updated text: --with-openssl build with OpenSSL support --with-libedit-preferred prefer Libedit over Libreadline --without-readline do not use

Re: [PATCHES] [HACKERS] Should libedit be preferred to libreadline?

2005-12-03 Thread Peter Eisentraut
Bruce Momjian wrote: They are called Readline and Libedit. I wanted to distinguish libreadline from readline-functionality. The functionality may be called command-line editing but I don't see how that relates to what actually appears in the patch. Why is it Readline? PostgreSQL was

Re: [PATCHES] [HACKERS] Should libedit be preferred to libreadline?

2005-12-03 Thread Bruce Momjian
Peter Eisentraut wrote: Bruce Momjian wrote: They are called Readline and Libedit. I wanted to distinguish libreadline from readline-functionality. The functionality may be called command-line editing but I don't see how that relates to what actually appears in the patch. When you

Re: [PATCHES] [HACKERS] Should libedit be preferred to libreadline?

2005-12-03 Thread Michael Paesold
Bruce Momjian wrote: I wanted to distinguish libreadline from readline-functionality. Why is it Readline? The GNU Readline Library is usually referred to as Readline, not libreadline. The offical name for libedit is really Libedit. See e.g.: http://sourceforge.net/projects/libedit/

Re: [PATCHES] [HACKERS] Should libedit be preferred to libreadline?

2005-12-03 Thread Bruce Momjian
Michael Paesold wrote: Bruce Momjian wrote: I wanted to distinguish libreadline from readline-functionality. Why is it Readline? The GNU Readline Library is usually referred to as Readline, not libreadline. The offical name for libedit is really Libedit. See e.g.:

Re: [PATCHES] [HACKERS] snprintf() argument reordering not working under Windows

2005-12-03 Thread Bruce Momjian
Nicolai Tufar wrote: Greetings, Last April we have made some changes to src/ports/snprintf.c so that it would support argument reordering like %2$s, %1$d and such on platforms where original snprintf() does not support it, like Windows, HP-UX or NetBSD. Sure, I remember. So glad you

Re: [PATCHES] [HACKERS] snprintf() argument reordering not working under Windows

2005-12-03 Thread Tom Lane
Bruce Momjian pgman@candle.pha.pa.us writes: I am also thinking of modifying the code so if we are using snprintf.c only because we need positional parameter control, we check for '$' in the string and only use snprintf.c in those cases. What's the point? If the code is in there we may as

Re: [PATCHES] [HACKERS] snprintf() argument reordering not working under

2005-12-03 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian pgman@candle.pha.pa.us writes: I am also thinking of modifying the code so if we are using snprintf.c only because we need positional parameter control, we check for '$' in the string and only use snprintf.c in those cases. What's the point? If the code is

Re: [PATCHES] [HACKERS] snprintf() argument reordering not working under Windows in 8.1

2005-12-03 Thread Magnus Hagander
Here is the commit: revision 1.409 date: 2005/05/05 19:15:54; author: momjian; state: Exp; lines: +8 -2 On Win32, libintl replaces snprintf() with its own version that understands arg control, so we don't need our own. In fact, it also uses macros

Re: [PATCHES] Numeric 508 datatype

2005-12-03 Thread Tom Lane
Bruce Momjian pgman@candle.pha.pa.us writes: (I could have done the struct but that seemed too invasive.) I think it'd be a lot cleaner with the struct. Mind if I take another pass at it? regards, tom lane ---(end of

Re: [PATCHES] [HACKERS] snprintf() argument reordering not working under Windows in 8.1

2005-12-03 Thread Nicolai Tufar
Greetings, I thought it will be as simple as changing Makefile, the issue seem to be much more complicated. Unfortunately I have no PostgreSQL building environment handy and will not be able to look at it until the end of next week because I am moving my house :( But since this issue waited for

Re: [PATCHES] Numeric 508 datatype

2005-12-03 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian pgman@candle.pha.pa.us writes: (I could have done the struct but that seemed too invasive.) I think it'd be a lot cleaner with the struct. Mind if I take another pass at it? OK, you want my patch or want me to apply and then you can modify? -- Bruce

Re: [PATCHES] A couple of proposed pgbench changes

2005-12-03 Thread Tatsuo Ishii
I have commited your fixes into PostgreSQL 8.1 stable branches. -- Tatsuo Ishii SRA OSS, Inc. Japan Hi Tatsuo, Attached is a proposed patch that deals with a couple of pgbench issues. The change at line 490 updates doCustom's local variable commands after selecting a new file (command

Re: [PATCHES] Numeric 508 datatype

2005-12-03 Thread Tom Lane
Bruce Momjian pgman@candle.pha.pa.us writes: Tom Lane wrote: I think it'd be a lot cleaner with the struct. Mind if I take another pass at it? OK, you want my patch or want me to apply and then you can modify? You sent out your patch already --- I've been working from that.

Re: [PATCHES] Numeric 508 datatype

2005-12-03 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian pgman@candle.pha.pa.us writes: Tom Lane wrote: I think it'd be a lot cleaner with the struct. Mind if I take another pass at it? OK, you want my patch or want me to apply and then you can modify? You sent out your patch already --- I've been working

Re: [PATCHES] [HACKERS] Should libedit be preferred to libreadline?

2005-12-03 Thread Bruce Momjian
Patch applied. --- Bruce Momjian wrote: Michael Paesold wrote: Bruce Momjian wrote: I wanted to distinguish libreadline from readline-functionality. Why is it Readline? The GNU Readline Library is usually

Re: [PATCHES] return can contains any row or record functions

2005-12-03 Thread Bruce Momjian
Where are we on this patch? I don't see it as applied to CVS. --- Pavel Stehule wrote: - we can't use estate-rsi for the RETURN case, at least as presently implemented, because that is not always filled-out -- the