Re: [PATCHES] [HACKERS] BEGIN inside transaction should be an error

2006-05-26 Thread Gurjeet Singh
I have made the changes to implement this TODO item. I wish to know the standard procedure (command) to generate a patch; and from which level in the source directory should I execute it? On 5/18/06, Bruce Momjian wrote: Added to TODO: * Add a GUC to control whether BEGIN inside a

Re: [PATCHES] [HACKERS] BEGIN inside transaction should be an error

2006-05-26 Thread Alvaro Herrera
Gurjeet Singh wrote: >I have made the changes to implement this TODO item. I wish to > know the standard procedure (command) to generate a patch; and from > which level in the source directory should I execute it? The toplevel directory. The command is cvs -q diff -cp If you created new fil

Re: [PATCHES] [HACKERS] BEGIN inside transaction should be an error

2006-05-26 Thread Andrew Dunstan
Please read the developers FAQ: http://www.postgresql.org/docs/faqs.FAQ_DEV.html For the most part, patches are probably best generated relative to the root directory of your CVS checkout. cheers andrew Gurjeet Singh wrote: I have made the changes to implement this TODO item. I wish t

Re: [PATCHES] [HACKERS] BEGIN inside transaction should be an error

2006-05-26 Thread Gurjeet Singh
On 5/26/06, Alvaro Herrera <[EMAIL PROTECTED]> wrote: Gurjeet Singh wrote: >I wish to > know the standard procedure (command) to generate a patch; and from > which level in the source directory should I execute it? The toplevel directory. The command is cvs -q diff -cp If you created new

Re: [PATCHES] [HACKERS] BEGIN inside transaction should be an error

2006-05-26 Thread Gurjeet Singh
On 5/26/06, Andrew Dunstan <[EMAIL PROTECTED]> wrote: Please read the developers FAQ: http://www.postgresql.org/docs/faqs.FAQ_DEV.html For the most part, patches are probably best generated relative to the root directory of your CVS checkout. cheers andrew Gurjeet Singh wrote: >I wish to

Re: [PATCHES] [HACKERS] BEGIN inside transaction should be an error

2006-05-26 Thread Alvaro Herrera
Gurjeet Singh wrote: > *** BeginTransactionBlock(void) > *** 2725,2731 > case TBLOCK_SUBINPROGRESS: > case TBLOCK_ABORT: > case TBLOCK_SUBABORT: > ! ereport(WARNING, > > (errcode(E

Re: [PATCHES] [HACKERS] BEGIN inside transaction should be an error

2006-05-26 Thread Tom Lane
"Gurjeet Singh" <[EMAIL PROTECTED]> writes: > Here's the patch: Wrong default (there was no consensus for changing the default behavior, and you need to tone down the description strings). A less verbose GUC variable name would be a good idea, too. Something like "error_double_begin" would be mo

Re: [PATCHES] Binary COPY for psql

2006-05-26 Thread Tom Lane
Andreas Pflug <[EMAIL PROTECTED]> writes: > The attached patch enables psql to copy binary data in and out. Applied with revisions. regards, tom lane ---(end of broadcast)--- TIP 5: don't forget to increase your free space m

Re: [PATCHES] AIX FAQ - IPv6 Fun

2006-05-26 Thread Bruce Momjian
Applied. --- Chris Browne wrote: > [EMAIL PROTECTED]:/opt/OXRS/sources/pgsql-HEAD/doc$ cvs diff -u FAQ_AIX > Index: FAQ_AIX > === > RCS file: /projects/cvsroot

Re: [PATCHES] Cleanup for new escape handling

2006-05-26 Thread Bruce Momjian
Patch applied. --- Bruce Momjian wrote: > This patch cleans up the use of E'' strings in 8.2. 8.2 is the first > release where standard_conforming_strings can be 'on', and when 'on', > escape_string_warning is disabled. >