Re: [pgsql-patches] O_DIRECT support for Windows

2007-01-16 Thread Magnus Hagander
On Tue, Jan 16, 2007 at 10:59:11AM +0900, Takayuki Tsunakawa wrote: > From: "Magnus Hagander" <[EMAIL PROTECTED]> > > ITAGAKI Takahiro wrote: > >> Do you mean there are drives that have larger sector size than 8kB? > >> We've already put the xlog buffer along the alignment of > >> ALIGNOF_XLOG_BUFF

Re: [pgsql-patches] pg_dumpall default database

2007-01-16 Thread Dave Page
Tom Lane wrote: > Dave Page <[EMAIL PROTECTED]> writes: >> OK, updated patch attached. This has > >> -E or --default-database= > > Not sure that "default" database is a particularly helpful adjective; > why shouldn't the switch just be --database? > > Other than that, looks fine. Updated to -l

Re: [pgsql-patches] [PATCHES] [HACKERS] [Fwd: Index Advisor]

2007-01-16 Thread Gurjeet Singh
On 1/15/07, Andrew Dunstan <[EMAIL PROTECTED]> wrote: Gurjeet Singh wrote: > > 1) pg_post_planner_plugin-REL8_2_STABLE-v1.patch.gz > 2) pg_index_adviser-REL8_2_STABLE-v26.patch.gz > Why are these patches against 8.2 rather than CVS HEAD? Is this not a new feature? We never backport new f

[pgsql-patches] Recalculating OldestXmin in a long-running vacuum

2007-01-16 Thread Heikki Linnakangas
Hi, It seems to me that we could easily reclaim a bit more dead tuples in a vacuum by recalculating the OldestXmin every now and then. In a large table with a constant stream of updates/deletes and concurrent vacuums, this could make a big difference. With the attached patch, OldestXmin is r

[pgsql-patches] pg_dumpall -f option

2007-01-16 Thread Dave Page
Per discussion on -hackers, the attached patch adds the option -f, --file=FILENAME to pg_dumpall. In order to support this, a new (undocumented) format option (-Fa) is added to pg_dump which is identical to -Fp, except that the output file is opened for append rather than write. This patch shoul

Re: [pgsql-patches] scrollable cursor sup. for SPI

2007-01-16 Thread Pavel Stehule
"Pavel Stehule" <[EMAIL PROTECTED]> writes: > if I comprehended it well CURSOR_OPT_SCROLL is set only when SCROLL is cheap > (not when is possible). It's true? Nope. If you want a scrollable plan you need to make sure you tell the planner about it. SPI_cursor_open is not in charge, it's mer

Re: [pgsql-patches] Recalculating OldestXmin in a long-running vacuum

2007-01-16 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > It seems to me that we could easily reclaim a bit more dead tuples in a > vacuum by recalculating the OldestXmin every now and then. Doesn't this break relfrozenxid maintenance? In any case I'd like to see some evidence of significant real-world b

Re: [pgsql-patches] Recalculating OldestXmin in a long-running vacuum

2007-01-16 Thread Heikki Linnakangas
Tom Lane wrote: Heikki Linnakangas <[EMAIL PROTECTED]> writes: It seems to me that we could easily reclaim a bit more dead tuples in a vacuum by recalculating the OldestXmin every now and then. Doesn't this break relfrozenxid maintenance? Not AFAICS. relfrozenxid is nowadays updated with F

Re: [pgsql-patches] TODO improvements

2007-01-16 Thread Neil Conway
On Mon, 2007-01-15 at 13:41 -0500, Neil Conway wrote: > BTW, it seems that while Oracle provides an IS NAN construct, they also > treat NaN as equal to itself (which makes me question why they added IS > NAN in the first place). So perhaps it is sufficient to leave things as > they are... Patch ap

Re: [pgsql-patches] vcbuild updates

2007-01-16 Thread Neil Conway
On Mon, 2007-01-15 at 22:25 +0100, Magnus Hagander wrote: > * After Markos patch, now builds pgcrypto without zlib again > * Updates README with xml info > * xml requires xslt and iconv > * disable unnecessary warning about __cdecl() > * Add a buildenv.bat called from all other bat files to set up

Re: [pgsql-patches] O_DIRECT support for Windows

2007-01-16 Thread Takayuki Tsunakawa
Hello, Magnus-san, Itagaki-san From: "Magnus Hagander" <[EMAIL PROTECTED]> >> I think many people can benefit from Itagaki-san's proposal, and >> NO_BUFFERING should be default. Isn't it very rare that disks with >> sector size larger than 8KB are used? > > Definitly very rare. > > >> Providing a

Re: [pgsql-patches] O_DIRECT support for Windows

2007-01-16 Thread Chuck McDevitt
People seem to be confusing sector size and cluster size. Microsoft Windows assumes sectors are 8k or less on hard drives (99% are 512 bytes). Cluster size is the allocation unit. On windows, this can be 512 to 256k (max 64k with 512 byte sectors). NTFS (which I think we need) is limited to 64k,