Re: [PATCHES] xpath_array with namespaces support

2007-03-17 Thread Nikolay Samokhvalov
What about it? W/o this not large patch XML functionality in 8.3 will be weak... Will it be accepted? On 3/5/07, Nikolay Samokhvalov <[EMAIL PROTECTED]> wrote: On 3/4/07, Nikolay Samokhvalov <[EMAIL PROTECTED]> wrote: > I'll fix these issues and extend the patch with resgression tests and > docs

Re: [PATCHES] xpath_array with namespaces support

2007-03-17 Thread Andrew Dunstan
Nikolay Samokhvalov wrote: What about it? W/o this not large patch XML functionality in 8.3 will be weak... Will it be accepted? In principle I am in favor of the patch. Would it be better to use some more unlikely name for the dummy root element used to process fragments than ? Perhap

Re: [PATCHES] xpath_array with namespaces support

2007-03-17 Thread Andrew Dunstan
Nikolay Samokhvalov wrote: On 3/17/07, Andrew Dunstan <[EMAIL PROTECTED]> wrote: In principle I am in favor of the patch. Would it be better to use some more unlikely name for the dummy root element used to process fragments than ? Perhaps even something in a special namespace? I did thi

[PATCHES] ecpg threading vs win32

2007-03-17 Thread Magnus Hagander
This patch replaces the pthreads code in ecpg with native win32 threads, in order to make it threadsafe. The idea is not to have to download the non-standard pthreads library on windows. Does it seem like it should be doing the right thing? Does somebody have a good test-case where ecpg breaks whe

Re: [PATCHES] Code-Cleanup: char* -> const char*

2007-03-17 Thread Neil Conway
Stefan Huehner wrote: attached patches marks several char* variables as const where they are initialized with constant strings. I really wonder how much value there is in using the "const" modifier very widely. "const" for function parameters is valuable (because it adds information about

Re: [PATCHES] Code-Cleanup: function declarations (void, and k&r style)

2007-03-17 Thread Neil Conway
Stefan Huehner wrote: attached patch fixes some function declarations: - () -> (void) - k&r style -> ansi C Applied, thanks for the patch. -Neil ---(end of broadcast)--- TIP 6: explain analyze is your friend

Re: [PATCHES] patch adding new regexp functions

2007-03-17 Thread Neil Conway
Jeremy Drake wrote: The patch has been sitting in the unapplied patches queue for a while Barring any objections, I'll apply this tomorrow. -Neil ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate