[PATCHES] Re: [HACKERS] choose_bitmap_and again (was Re: [PERFORM] Strangely Variable Query Performance)

2007-04-15 Thread Steve


Can you find any cases where it makes a worse choice than before?
Another thing to pay attention to is whether the planning time gets
noticeably worse.  If we can't find any cases where it loses badly
on those measures, I'll feel comfortable in applying it...



	I'll see what I can find -- I'll let you know on Monday if I can 
find any queries that perform worse.  My tests so far have shown 
equivalent or better performance so far but I've only done sort of a 
survey so far ... I've got plenty of special cases to test that should 
put this through the paces.



Steve

---(end of broadcast)---
TIP 1: if posting/reading through Usenet, please send an appropriate
  subscribe-nomail command to [EMAIL PROTECTED] so that your
  message can get through to the mailing list cleanly


Re: [PATCHES] build/install xml2 when configured with libxml

2007-04-15 Thread Peter Eisentraut
Andrew Dunstan wrote:
 I don't think it should go away until we provide for equivalents in
 core, at least optionally.

Well, if we're going to make libxslt an explicit thing, then it'd be 
trivial to add an xslt transformation function into the core, and then 
I think we can claim equivalent support.  But we'll have to check the 
details, of course.

I have been thinking, however, that I don't want to add more and more 
library dependencies into the server.  libxml2 was necessary to some 
extent.  But xslt functionality could easily be provided as a module.  
This would be easy to do and might be useful even for 8.3.  But I don't 
really know how to label that.  Having a contrib/xslt alongside 
contrib/xml2 would probably be confusing.  Ideas?

-- 
Peter Eisentraut
http://developer.postgresql.org/~petere/

---(end of broadcast)---
TIP 7: You can help support the PostgreSQL project by donating at

http://www.postgresql.org/about/donate


[PATCHES] Suppress warnings on mingw

2007-04-15 Thread ITAGAKI Takahiro
This trivial patch fixes the following warnings on mingw.


pthread-win32.c:20: warning: no previous prototype for 'pthread_self'
dllwrap --def pgevent.def -o pgevent.dll pgevent.o pgmsgevent.o
Warning: resolving _DllUnregisterServer by linking to [EMAIL PROTECTED]
Use --enable-stdcall-fixup to disable these warnings
Use --disable-stdcall-fixup to disable these fixups
Warning: resolving _DllRegisterServer by linking to [EMAIL PROTECTED]
Warning: resolving _DllUnregisterServer by linking to [EMAIL PROTECTED]
Use --enable-stdcall-fixup to disable these warnings
Use --disable-stdcall-fixup to disable these fixups
Warning: resolving _DllRegisterServer by linking to [EMAIL PROTECTED]



Index: src/bin/pgevent/pgevent.def
===
--- src/bin/pgevent/pgevent.def (HEAD)
+++ src/bin/pgevent/pgevent.def (working copy)
@@ -1,4 +1,4 @@
 ; dlltool --output-def pgevent.def pgevent.o pgmsgevent.o
 EXPORTS
-   DllUnregisterServer ;
-   DllRegisterServer ;
+   DllUnregisterServer = [EMAIL PROTECTED] ;
+   DllRegisterServer = [EMAIL PROTECTED] ;
Index: src/port/pthread-win32.h
===
--- src/port/pthread-win32.h(HEAD)
+++ src/port/pthread-win32.h(working copy)
@@ -5,7 +5,7 @@
 typedef HANDLE pthread_mutex_t;
 typedef int pthread_once_t;
 
-DWORD  pthread_self();
+DWORD  pthread_self(void);
 
 void   pthread_setspecific(pthread_key_t, void *);
 void  *pthread_getspecific(pthread_key_t);

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center


---(end of broadcast)---
TIP 3: Have you checked our extensive FAQ?

   http://www.postgresql.org/docs/faq