Re: [PATCHES] Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1

2008-03-25 Thread Tom Lane
Zoltan Boszormenyi <[EMAIL PROTECTED]> writes: > Gregory Stark írta: >> 1) Please don't include configure in your patch. I don't know why it's >> checked >> into CVS but it is so that means manually removing it from any patch. It's >> usually a huge portion of the diff so it's worth removing. > N

Re: [PATCHES] int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1

2008-03-25 Thread Magnus Hagander
I haven't had time to look through the patch, but reading Gregs comments I noted: 2) The genbki.sh change could be a bit tricky for multi-platform builds (ie OSX). I don't really see an alternative so it's just something to note for the folks setting that up (Hi Dave). Changes to genbk

Re: [PATCHES] Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1

2008-03-25 Thread Zoltan Boszormenyi
Tom Lane wrote: Zoltan Boszormenyi <[EMAIL PROTECTED]> writes: Gregory Stark írta: 1) Please don't include configure in your patch. I don't know why it's checked into CVS but it is so that means manually removing it from any patch. It's usually a huge portion of the diff so it's worth r

Re: [PATCHES] Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1

2008-03-25 Thread Zoltan Boszormenyi
Tom Lane wrote: Zoltan Boszormenyi <[EMAIL PROTECTED]> writes: Gregory Stark írta: 1) Please don't include configure in your patch. I don't know why it's checked into CVS but it is so that means manually removing it from any patch. It's usually a huge portion of the diff so it's worth r

Re: [PATCHES] actualised execute using patch

2008-03-25 Thread Zdenek Kotala
you have extra space onPavel Stehule napsal(a): Hello http://archives.postgresql.org/pgsql-patches/2007-10/msg00161.php I actualized this patch for current CVS Hi Pavel, I tested your patch and it works regarding to proposal. However I have some small comments: 1) you have extra space in ./

Re: [PATCHES] Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1

2008-03-25 Thread Alvaro Herrera
I don't think my $int64passbyval = "(?($real64 = 1)t|f)"; works. Perhaps my $int64passbyval = $real64 ? 't' : 'f'; -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. pg84-passedbyval-v4.patch.gz Descri

Re: [PATCHES] Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1

2008-03-25 Thread Zoltan Boszormenyi
Alvaro Herrera írta: I don't think my $int64passbyval = "(?($real64 = 1)t|f)"; works. Perhaps my $int64passbyval = $real64 ? 't' : 'f'; Thanks. Modified patch attached. Stupid question follows. Now that float4 is passed by value unconditionally, is it worth modifying the

Re: [PATCHES] pg_dump -i wording

2008-03-25 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > I have developed the attached patch with improves wording for the > > pg_dump -i (ignore version) option. > > I think this is going in exactly the wrong direction --- it makes > both the documentation and the warning message less scar

Re: [PATCHES] tuplestore_putvalues()

2008-03-25 Thread Neil Conway
On Thu, 2008-02-28 at 16:37 -0800, Neil Conway wrote: > Attached is a patch that allows an array of Datums + nulls to be > inserted into a tuplestore without first creating a HeapTuple, per > recent suggestion on -hackers. This avoids making an unnecessary copy. Applied to HEAD. -Neil -- Sent

[PATCHES] Doc patch for DTrace

2008-03-25 Thread Robert Lor
Attached is the doc patch for the recent DTrace changes http://archives.postgresql.org/pgsql-committers/2008-03/msg00316.php Regards, -Robert Index: doc/src/sgml/installation.sgml === RCS file: /projects/cvsroot/pgsql/doc/src/sgml/in

Re: [PATCHES] tuplestore_putvalues()

2008-03-25 Thread Neil Conway
On Sat, 2008-03-22 at 21:35 -0400, Tom Lane wrote: > After a quick read, looks sane except for one stylistic gripe: > in exec_stmt_return_next, you added an initialization of tuple = NULL > in order to remove a couple of lines like > > tuple = NULL; /* keep compiler quiet *

Re: [PATCHES] Moving snapshot code around

2008-03-25 Thread Neil Conway
On Tue, 2008-03-18 at 16:19 -0300, Alvaro Herrera wrote: > The other approach, of course, is to just keep all the code in tqual.c > and not create a separate module at all. Opinions? I prefer to keep > them separate, but I'm not wedded to it if there's any strong reason not > to do it. Also, the

Re: [PATCHES] [HACKERS] Text <-> C string

2008-03-25 Thread Tom Lane
"Brendan Jurd" <[EMAIL PROTECTED]> writes: > As discussed on -hackers, I'm trying to get rid of some redundant code > by creating a widely useful set of functions to convert between text > and C string in the backend. Applied with revisions --- the functions were modified as per recent discussion,

Re: [PATCHES] Doc patch for DTrace

2008-03-25 Thread Neil Conway
On Tue, 2008-03-25 at 15:45 -0500, Robert Lor wrote: > Attached is the doc patch for the recent DTrace changes Applied, thanks. -Neil -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches

Re: [PATCHES] libpq type system 0.9a

2008-03-25 Thread Alvaro Herrera
Merlin Moncure escribió: > The latest version of libpq type system is available here: > http://www.esilo.com/projects/postgresql/libpq/typesys-0.9a.tar.gz This patch is not in diff -c format ... please provide a diff -c patch, and add the URL to the wiki patch queue: http://wiki.postgresql.org/wi

Re: [PATCHES] Moving snapshot code around

2008-03-25 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > On Tue, 2008-03-18 at 16:19 -0300, Alvaro Herrera wrote: >> The other approach, of course, is to just keep all the code in tqual.c >> and not create a separate module at all. Opinions? I prefer to keep >> them separate, but I'm not wedded to it if there's

Re: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-03-25 Thread Bruce Momjian
This has been saved for the next commit-fest: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- NikhilS wrote: > Hi, > > Please find attached the WIP version 1 of the auto partitioning patch. There > was dis

Re: [PATCHES] Add function for quote_qualified_identifier?

2008-03-25 Thread Bruce Momjian
Brendan Jurd wrote: > On 9/29/07, Bruce Momjian <[EMAIL PROTECTED]> wrote: > > I think we need more than one person's request to add this function. > > Well, I don't expect it would get requested. Most DBAs would likely > look for the function in the docs, see it's not there and then just > imple