Re: [PATCHES] Improve shutdown during online backup, take 4

2008-04-25 Thread Albe Laurenz
Tom Lane wrote: >>> Why not? It'll fall out of the state again immediately in >>> PostmasterStateMachine, no, if we do a CancelBackup here? >> >> We cannot call CancelBackup there because that's exactly the state >> in which a smart shutdown waits for a superuser to issue pg_stop_backup(). > > Er

Re: [PATCHES] 64-bit CommandIds

2008-04-25 Thread Hans-Juergen Schoenig
Alvaro Herrera wrote: Bruce Momjian wrote: I think the case for it got a whole lot weaker in 8.3, with lazy consumption of CIDs. Agreed. Let's see if we get requests for it in >= 8.3 releases. In the original submission message you find this text: : attached is our patch aga

Re: [PATCHES] Improve shutdown during online backup, take 4

2008-04-25 Thread Tom Lane
"Albe Laurenz" <[EMAIL PROTECTED]> writes: > That should work, but isn't it better if backup_label is removed > only if we know we're going to shutdown cleanly? Why? That seems like an entirely arbitrary specification. regards, tom lane -- Sent via pgsql-patches mailing

Re: [PATCHES] 64-bit CommandIds

2008-04-25 Thread Tom Lane
Hans-Juergen Schoenig <[EMAIL PROTECTED]> writes: > Alvaro Herrera wrote: >> Question for Hans-Juergen and Zoltan: have you tested 8.3 and do you >> still see the need for this? > i have seen this problem two or three times within the past 2-3 years or > so. so, it can basically happen in the fie

Re: [PATCHES] Improve shutdown during online backup, take 4

2008-04-25 Thread Albe Laurenz
Tom Lane wrote: > Why? That seems like an entirely arbitrary specification. My resoning is that I think of smart/fast/immediate shutdown as three different things. For an immediate shutdown/crash thought it was best not to modify anything to facilitate an analysis of the problem. A fast shutdow

Re: [PATCHES] 64-bit CommandIds

2008-04-25 Thread Hans-Juergen Schoenig
Tom Lane wrote: Hans-Juergen Schoenig <[EMAIL PROTECTED]> writes: Alvaro Herrera wrote: Question for Hans-Juergen and Zoltan: have you tested 8.3 and do you still see the need for this? i have seen this problem two or three times within the past 2-3 years or so. so, it can