Re: [PATCHES] Warning for missing createlang

2003-09-04 Thread Bruce Momjian
Bruce Momjian wrote: > I have written a patch to issue an hint if someone tries to create a > function in a language that isn't loaded into the database: > > test=> CREATE FUNCTION xx() RETURNS INT AS ' > test'> select 1' > test-> LANGUAGE 'plpgsql'; > ERROR: language "plp

Re: [PATCHES] small typos

2003-09-04 Thread Bruce Momjian
Patch applied. Thanks. --- Alvaro Herrera wrote: > Patchers, > > This fixes three minor typos in hba.c. > > -- > Alvaro Herrera () > "There was no reply" (Kernel Traffic) [ Attachment, skipping... ] > > -

[PATCHES] fix doc typo

2003-09-04 Thread Neil Conway
This patch fixes a trivial typo in the CREATE FUNCTION ref page. -Neil Index: doc/src/sgml/ref/create_function.sgml === RCS file: /var/lib/cvs/pgsql-server/doc/src/sgml/ref/create_function.sgml,v retrieving revision 1.49 diff -c -r1.

Re: [PATCHES] doc patch - linux memory handling

2003-09-04 Thread Bruce Momjian
Patch applied. Thanks. --- Andrew Dunstan wrote: > > It appears we are back in the "you need a non-empty password" mode. > > Anyway, here's the revised patch. > > andrew > > > Andrew Dunstan wrote: > > > > > I didn't

Re: [PATCHES] postgresql-7.4b1 Native-Windows patch

2003-09-04 Thread Bruce Momjian
I went over this patch and fixed the problem with WIN32_CONSOLE. It seems you have a problem with mbvalidate. Is that correct? What doesn't work there? Also, I see you had to ifdef out something in thread.c. Would you test current CVS and see if you still need that change. Thanks. -

Re: [PATCHES] libpq-win32 patches

2003-09-04 Thread Bruce Momjian
OK, I have applied this patch, except for this part: > Index: include/pg_config.h.win32 > === > RCS file: /projects/cvsroot/pgsql-server/src/include/pg_config.h.win32,v > retrieving revision 1.11 > diff -u -r1.11 pg_config.h.win32 >

Re: [PATCHES] libpq with ssl under win32

2003-09-04 Thread Bruce Momjian
Andreas Pflug wrote: > The attached patch enables libpq to be linked with ssl support (openssl > 0.9.7.b tested). > Client certificates are commented out because the implementation is *nix > specific, regarding the location resolution of the .pem files. It needs > to be discussed where these fil

Re: [PATCHES] Warning for missing createlang

2003-09-04 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > I have written a patch to issue an hint if someone tries to create a > > function in a language that isn't loaded into the database: > > > ERROR: language "plpgsql" does not exist > > HINT: Perhaps you need to use 'createlan

Re: [PATCHES] Warning for missing createlang

2003-09-04 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > I have written a patch to issue an hint if someone tries to create a > function in a language that isn't loaded into the database: > ERROR: language "plpgsql" does not exist > HINT: Perhaps you need to use 'createlang' to load the language

Re: [PATCHES] IPV4 addresses on IPV6 machines in pg_hba.conf

2003-09-04 Thread Andrew Dunstan
Andreas, You should check that the CIDR mask is a valid integer. You would need to use strtol() rather than atoi() to do that. Perhaps this should be hoisted out of ip.c:SockAddr_cidr_mask() and put in hba.c. Sorry, I should have checked this carefully earlier. andrew Andreas Pflug wrote: Ku

Re: [PATCHES] IPV4 addresses on IPV6 machines in pg_hba.conf

2003-09-04 Thread Andreas Pflug
Kurt Roeckx wrote: You're assuming all systems have an AF_INET6 constant, which is not the case. Please make use of HAVE_IPV6. Can't directly see anything else wrong with it. Here's the patch with HAVE_IPV6 conditional compiling. Regards, Andreas Index: hba.c ===

[PATCHES] minor documentation improvements

2003-09-04 Thread Neil Conway
This patch makes a few minor improvements to the docs: make the conventions more consistent, and improve the ANALYZE ref page. -Neil Index: doc/src/sgml/perform.sgml === RCS file: /var/lib/cvs/pgsql-server/doc/src/sgml/perform.sgml,

[PATCHES] Warning for missing createlang

2003-09-04 Thread Bruce Momjian
I have written a patch to issue an hint if someone tries to create a function in a language that isn't loaded into the database: test=> CREATE FUNCTION xx() RETURNS INT AS ' test'> select 1' test-> LANGUAGE 'plpgsql'; ERROR: language "plpgsql" does not exist

[PATCHES] note on dropped columns in pg_attribute

2003-09-04 Thread Robert Treat
I didn't see it documented anywhere that a 0 in attypid of pg_attribute, and given the note on the need to match pg_type lest failure seems to warrant the mention. Robert Treat -- Build A Brighter Lamp :: Linux Apache {middleware} PostgreSQL Index: src/include/catalog/pg_attribute.h

Re: [PATCHES] Fw: New translation

2003-09-04 Thread Peter Eisentraut
Mirko Tebaldi writes: > what about this email ? Can you send the files in a less unusual archive format? -- Peter Eisentraut [EMAIL PROTECTED] ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postg

[PATCHES] OffsetNumber offnum (LOCKTAG in lock.c)

2003-09-04 Thread Sumaira Maqsood Ali
the offnum of LOCKTAG I gather indicates which row (tuple) is being locked in a row level locking. But when I lock 2 diffrent rows of a table, offset for both is 0. and also offset is 0 if i take a table lock on the same table. (blkno is the same for all three locks)..shouldnt the OffsetNumber

[PATCHES] PgSQL74b2: initdb fails (max_connections)

2003-09-04 Thread Janko Richter
On FreeBSD 5.1 using PgSQL 7.4b2 initdb failed with: su-2.05b$ ./initdb -D /data/pgsql The files belonging to this database system will be owned by user "postgres". This user must also own the server process. The database cluster will be initialized with locale C. fixing permissions on existing

Re: [PATCHES] IPV4 addresses on IPV6 machines in pg_hba.conf

2003-09-04 Thread Kurt Roeckx
On Wed, Sep 03, 2003 at 07:19:16PM +0200, Andreas Pflug wrote: > This was discussed in [HACKERS] TCP/IP with 7.4 beta2 broken? > > > I created a patch to hba.c which uses IPV4 entries as IPV6 entries if > running on a IPV6 system (which is detected from a port coming in as > AF_INET6). > You'r