Re: [PATCHES] hint infrastructure setup (v3)

2004-04-03 Thread Tom Lane
Fabien COELHO <[EMAIL PROTECTED]> writes: > That is done with YYERROR_VERBOSE, but the result is really poor > most of the time, because it does not look for all possible terminals, > just the ones easilly accessible. I wasn't aware that bison had a built-in facility for better messages --- this i

Re: [PATCHES] MSFT compiler fixes + misc

2004-04-03 Thread Magnus Hagander
A thought about this - how about converting pgpiperead() and pgpipewrite() into functions intead of macros (on win32 - still redifining them on != win32), mimicking the behaviour of read() and write()? Then we could do awya with the #ifdefs at the points where its used, and just expect the normal U

Re: [PATCHES] [HACKERS] Function to kill backend

2004-04-03 Thread Andrew Dunstan
Magnus Hagander wrote: I think any such facility is inherently a security risk, since it means that a remote attacker who's managed to break into your superuser account can randomly zap other backends. Now admittedly there's plenty of other mischief he can do with superuser privs,

Re: [PATCHES] hint infrastructure setup (v3)

2004-04-03 Thread Fabien COELHO
> > You *really* don't want to go there. If you want to see what the parser > > is doing you can run "bison -r all" over the grammar and examine the > > .output file. But please, let's not examine the internal states. Talk > > about unmaintainability! > > What I was suggesting was that we might be

Re: [PATCHES] hint infrastructure setup (v3)

2004-04-03 Thread Fabien COELHO
Dear Tom, > > Not really in terms of state. The state should basically be the same. > > However yes in terms of "explicit" state that are given explicit names. > > And definitely in terms of actions, as you say. > > But mid-rule actions are implemented by inventing additional internal > productio

Re: [PATCHES] hint infrastructure setup (v3)

2004-04-03 Thread Fabien COELHO
> I wonder if we could just do a \h command as a hint. In some cases, it > might be clearer than printing some text. \h SELECT or \h CREATE TABLE are 2 pages long. For the beginner, it is a lot of help... a little bit too much. So I think that a better job can be done. If I'm wrong, you don't

Re: [PATCHES] hint infrastructure setup (v3)

2004-04-03 Thread Fabien COELHO
Dear Stephan, > I can see them as potentially being useful for people who don't have alot > of knowledge of SQL or our dialect thereof. That is my audience. > I think some of the ones shown may need better wording [...] Sure. I'm not the man for writing very clear English sentences. I may be m