Re: [PATCHES] Minor BEFORE DELETE trigger fix

2004-08-12 Thread Gavin Sherry
On Thu, 12 Aug 2004, Bruce Momjian wrote: > > Did this get resolved? > > --- > > Gavin Sherry wrote: > > Attached is a minor patch to make BEFORE DELETE triggers honour tgenabled > > properly. > > > > I know that we cannot, cu

Re: [PATCHES] Add GUC_REPORT to server_encoding, integer_datetimes

2004-08-12 Thread Oliver Jowett
Oliver Jowett wrote: This adds GUC_REPORT to server_encoding and integer_datetimes so they are reported in the V3 protocol startup packet. s/startup packet/startup process/ -O ---(end of broadcast)--- TIP 6: Have you searched our list archives?

Re: [PATCHES] Minor BEFORE DELETE trigger fix

2004-08-12 Thread Bruce Momjian
Did this get resolved? --- Gavin Sherry wrote: > Attached is a minor patch to make BEFORE DELETE triggers honour tgenabled > properly. > > I know that we cannot, currently, use this feature through a DDL command > but just

[PATCHES] Add GUC_REPORT to server_encoding, integer_datetimes

2004-08-12 Thread Oliver Jowett
This adds GUC_REPORT to server_encoding and integer_datetimes so they are reported in the V3 protocol startup packet. Also some related doc updates. Rationale: 1) server_encoding is useful to allow clients to detect bad server/client encoding pairs. The one that bites JDBC regularly is client_

Re: [PATCHES] [pgsql-hackers-win32] PITR on Win32 - Archive and Restore

2004-08-12 Thread Bruce Momjian
OK, patch attached and applied. --- Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > The attached applied patch cleans up our implementation and documents > > its purpose. I also added some examples for 'archi

Re: [PATCHES] [HACKERS] SAVEPOINT syntax again

2004-08-12 Thread Tom Lane
Oliver Jowett <[EMAIL PROTECTED]> writes: > Here's an updated patch that supports the syntax you suggest. I kept the > error messages, doc examples and regression tests using RELEASE > SAVEPOINT in full to follow the standard. Applied. I had to tweak the grammar changes a bit --- the patch as g

Re: [PATCHES] psql - missing tab-completion support for tablespaces

2004-08-12 Thread Bruce Momjian
Removed. Superceeded by later patch. --- Stefan Kaltenbrunner wrote: > [sorry if you get this mail twice, i think my first post didn't made it > passt the moderator queue] > > Hi! > > While playing around with 8.0devel I

Re: [PATCHES] [HACKERS] SAVEPOINT syntax again

2004-08-12 Thread Tom Lane
Oliver Jowett <[EMAIL PROTECTED]> writes: > Here's an updated patch that supports the syntax you suggest. I kept the > error messages, doc examples and regression tests using RELEASE > SAVEPOINT in full to follow the standard. As long as we're tweaking syntax to agree with the spec ... I notice

Re: [PATCHES] dbsize modification to support tablespaces

2004-08-12 Thread Bruce Momjian
Patch applied. Thanks. --- Gavin Sherry wrote: > Attached. > > Gavin Content-Description: [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 2: you can get

Re: [PATCHES] [pgsql-hackers-win32] PITR on Win32 - Archive and Restore

2004-08-12 Thread Bruce Momjian
Tom Lane wrote: > Andrew Dunstan <[EMAIL PROTECTED]> writes: > > Actually, it appears to me that we have a 100% solution. > > Yeah --- "friends don't let friends use Windows" ... > > Is there any part of this discussion that does not amount to documenting > Redmond's bugs? > > I'm perfectly happ

Re: [PATCHES] [pgsql-hackers-win32] PITR on Win32 - Archive and Restore

2004-08-12 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > The attached applied patch cleans up our implementation and documents > its purpose. I also added some examples for 'archive_command'. If you're going to do that, do it in both places ... you missed pgarch.c. Also, I would say that the large block comme

[PATCHES] Replace incorrect example for quote_ident

2004-08-12 Thread Greg Sabino Mullane
Index: func.sgml === RCS file: /projects/cvsroot/pgsql-server/doc/src/sgml/func.sgml,v retrieving revision 1.217 diff -c -r1.217 func.sgml *** func.sgml 10 Aug 2004 00:55:03 - 1.217 --- func.sgml 12 Aug 2004 18:37:20 -000

Re: [PATCHES] [BUGS] 8.0.0beta1: -lpthread missing

2004-08-12 Thread Bruce Momjian
OK, we now have thread compile failure reports on Debian and Slackware. The config/acx_pthread.m4 script basically tests these: acx_pthread_flags="pthreads none -Kthread -kthread lthread -pthread -pthreads -mthreads pthread --thread-safe -mt pthread-config" in th

Re: [PATCHES] Win32 Event log

2004-08-12 Thread Andreas Pflug
Dave Page wrote: "Dave Page" <[EMAIL PROTECTED]> writes: The attached patch directs FATAL and PANIC elog's to the event log as well as their normal destination. I don't think this is a good idea. In the first place, FATAL errors are not necessarily serious or out-of-the-ordinary --- an exampl

Re: [PATCHES] Win32 Event log

2004-08-12 Thread Dave Page
> -Original Message- > From: Tom Lane [mailto:[EMAIL PROTECTED] > Sent: 12 August 2004 15:40 > To: Dave Page > Cc: PostgreSQL Patches > Subject: Re: [PATCHES] Win32 Event log > > "Dave Page" <[EMAIL PROTECTED]> writes: > > The attached patch directs FATAL and PANIC elog's to the > ev

Re: [PATCHES] Win32 Event log

2004-08-12 Thread Tom Lane
"Dave Page" <[EMAIL PROTECTED]> writes: > The attached patch directs FATAL and PANIC elog's to the event log as > well as their normal destination. I don't think this is a good idea. In the first place, FATAL errors are not necessarily serious or out-of-the-ordinary --- an example is that all aut

[PATCHES] Translation updates for 8.0: pg_controldata-ru, pg_resetxlog-ru, pgscripts-ru

2004-08-12 Thread Serguei Mokhov
Hello Peter, These are fully translated. Some messages were tweaked, with some errors fixed. Please install for 8.0. -s pg_controldata-ru.po.gz;pg_resetxlog-ru.po.gz;pgscripts-ru.po.gz pg_controldata-ru.po.gz Description: GNU Zip compressed data pg_resetxlog-ru.po.gz Description: GNU Zip com

[PATCHES] pg_dump 'die on errors' option

2004-08-12 Thread Fabien COELHO
Dear patchers, Please find attached a submission to add a "die on errors" option to pg_restore, as it seems that some people have scripts that rely on the previous "abort on error" default behavior when restoring data with a direct connection. It works for me. Maybe Philip could test that it wor

Re: [PATCHES] [HACKERS] SAVEPOINT syntax again

2004-08-12 Thread Oliver Jowett
Tom Lane wrote: Oliver Jowett <[EMAIL PROTECTED]> writes: ::= RELEASE SAVEPOINT Oracle does not have RELEASE SAVEPOINT. DB2 has RELEASE [ TO ] SAVEPOINT I'd vote for RELEASE [ SAVEPOINT ] (for brevity, and for consistency with ROLLBACK). I feel no urge to copy DB2. Here's an updated patch th

[PATCHES] Win32 Event log

2004-08-12 Thread Dave Page
Under Win32 it is normal for serious errors to be recorded to the systems event log as well as any log that the application may also be writing (SQL Server is a good example of an app that does this). The attached patch directs FATAL and PANIC elog's to the event log as well as their normal desti

Re: [PATCHES] more massaging on pgxs postresql extension infrastructure

2004-08-12 Thread Fabien COELHO
Dear Peter, > Am Mittwoch, 11. August 2004 16:25 schrieb Fabien COELHO: > > (b) I think it is a key feature that one should be able to compile > > contrib with the already installed postgresql, without having > > to reconfigure. > > Why? I think it would be an entirely useless feature.