[PATCHES] small doc patch for postgresql.conf.sample

2004-09-19 Thread Josh Berkus
Bruce, Re-building CVS I noticed that I never submitted this doc-only patch to postgresql.conf.sample. -- Josh Berkus Aglio Database Solutions San Francisco Index: postgresql.conf.sample === RCS file: /projects/cvsroot/pgsql-server

[PATCHES] documentation fixes

2004-09-19 Thread Neil Conway
The attached patch makes some minor improvements and cleanup to the docs. Patch applied to HEAD. -Neil Index: doc/src/sgml/ref/create_operator.sgml === RCS file: /Users/neilc/local/cvs/pgsql-server/doc/src/sgml/ref/create_operator.sg

Re: [PATCHES] Fix for VACUUM in psql autocommit off

2004-09-19 Thread Michael Paesold
Tom Lane wrote: > "Michael Paesold" <[EMAIL PROTECTED]> writes: > > Or do I not understand what you mean by nested > > comments? (There is code for ignore /* .. */ before the first keyword.) > > Per SQL spec, the backend thinks that /* .. */ nests: > > regression=# /* some /* comment */ comment *

Re: [PATCHES] Fix for VACUUM in psql autocommit off

2004-09-19 Thread Tom Lane
"Michael Paesold" <[EMAIL PROTECTED]> writes: > Or do I not understand what you mean by nested > comments? (There is code for ignore /* .. */ before the first keyword.) Per SQL spec, the backend thinks that /* .. */ nests: regression=# /* some /* comment */ comment */ select 1; ?column? ---

Re: [PATCHES] Fix for VACUUM in psql autocommit off

2004-09-19 Thread Michael Paesold
Tom Lane wrote: > If we're going to do that, we should also include the other statements > that disallow execution in a transaction, and we should rename > is_transact_command to something more appropriate (not to mention fix > its comments). A quick grep shows > > PreventTransactionChain((void

Re: [PATCHES] Fix for VACUUM in psql autocommit off

2004-09-19 Thread Tom Lane
"Michael Paesold" <[EMAIL PROTECTED]> writes: > In current cvs (as in version 7.4.5), VACUUM does not work at all in > autocommit=off mode. That is, because psql does not know that VACUUM cannot > be performed inside an transaction. > I consider this a bug and suggest the attached fix. If we're go

[PATCHES] Fix for VACUUM in psql autocommit off

2004-09-19 Thread Michael Paesold
In current cvs (as in version 7.4.5), VACUUM does not work at all in autocommit=off mode. That is, because psql does not know that VACUUM cannot be performed inside an transaction. Even if you do ROLLBACK; VACUUM; it will internally issue a ROLLBACK; BEGIN; VACUUM; I consider this a bug and sugge