[PATCHES] SSL Error Code logging.

2004-09-21 Thread Dominic Mitchell
This patch logs the error code in the default case, so that the user stands a chance of looking it up. "Unrecognised error" is always disheartening. :-) -Dom Index: src/interfaces/libpq/fe-secure.c === RCS file: /projects/cvsroot/pg

Re: [PATCHES] psql tab-completion improvements

2004-09-21 Thread Neil Conway
On Wed, 2004-09-01 at 09:34, Greg Sabino Mullane wrote: > Some improvements for the tab-completion of psql. This should > address all of the items in the todo list and adds some new > things as well. Patch applied. Thanks. Bruce: this was also on the pending list. -Neil

Re: [PATCHES] Xid in log_line_prefix

2004-09-21 Thread Neil Conway
On Sat, 2004-09-11 at 13:44, Alvaro Herrera wrote: > This trivial patch adds the transaction Id to the list of escapes > available to log_line_prefix. Patch applied to HEAD. Thanks. Bruce, this patch was/is on the pending patches list. I don't know of a way to remove items from that list myself -

Re: [PATCHES] pg_controldata usage

2004-09-21 Thread Neil Conway
On Sun, 2004-09-19 at 01:39, Dennis Bjorklund wrote: > I think that the DATADIR part being treated as an option is confusing I agree. Barring any objections I'll apply this patch to HEAD within 24 hours. -Neil ---(end of broadcast)--- TIP 1: subs

Re: [PATCHES] pg_hba.conf additional comment re local line

2004-09-21 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan <[EMAIL PROTECTED]> writes: The attached tiny patch will possibly help to avoid some confusion by Windows users about the "local" line in pg_hba.conf (and thus help reduce queries to us ;-) ). I was wondering if we could teach initdb to remove that line alt

Re: [PATCHES] pg_hba.conf additional comment re local line

2004-09-21 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > The attached tiny patch will possibly help to avoid some confusion by > Windows users about the "local" line in pg_hba.conf (and thus help > reduce queries to us ;-) ). I was wondering if we could teach initdb to remove that line altogether in Windows

Re: [PATCHES] pg_hba.conf additional comment re local line

2004-09-21 Thread Andrew Dunstan
Peter Eisentraut wrote: Andrew Dunstan wrote: The attached tiny patch will possibly help to avoid some confusion by Windows users about the "local" line in pg_hba.conf (and thus help reduce queries to us ;-) ). It also removes an essentially content-free suffix in 2 nearby comment lines. M

Re: [PATCHES] pg_hba.conf additional comment re local line

2004-09-21 Thread Peter Eisentraut
Andrew Dunstan wrote: > The attached tiny patch will possibly help to avoid some confusion by > Windows users about the "local" line in pg_hba.conf (and thus help > reduce queries to us ;-) ). It also removes an essentially > content-free suffix in 2 nearby comment lines. Maybe initdb should just

Re: [PATCHES] [SQL] COUNT(*) to find records which have a certain number of dependencies ?

2004-09-21 Thread Greg Stark
Tom Lane <[EMAIL PROTECTED]> writes: > Greg Stark <[EMAIL PROTECTED]> writes: > > This patch allows subqueries without aliases. This is SQL-non-spec-compliant > > syntax that Oracle supports and many users expect to work. > > AFAIR you're the first to propose that we ignore the SQL spec here. >

[PATCHES] pg_hba.conf additional comment re local line

2004-09-21 Thread Andrew Dunstan
The attached tiny patch will possibly help to avoid some confusion by Windows users about the "local" line in pg_hba.conf (and thus help reduce queries to us ;-) ). It also removes an essentially content-free suffix in 2 nearby comment lines. cheers andrew Index: src/backend/libpq/pg_hba.conf.s

Re: [PATCHES] psql \set case sensitive for boolean (OFF/off)

2004-09-21 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Am Dienstag, 21. September 2004 13:01 schrieb Michael Paesold: >> I would recommend to make this check at least case insensitive, because >> >> a) Since SQL is case insensitive, the current behaviour is not what you >> would expect. > In contrast, ps

Re: [PATCHES] psql \set case sensitive for boolean (OFF/off)

2004-09-21 Thread Peter Eisentraut
Am Dienstag, 21. September 2004 13:01 schrieb Michael Paesold: > I would recommend to make this check at least case insensitive, because > > a) Since SQL is case insensitive, the current behaviour is not what you > would expect. In contrast, psql is case sensitive, so the current behavior is consi

Re: [PATCHES] psql: rollback only last query on error

2004-09-21 Thread Alvaro Herrera
On Tue, Sep 21, 2004 at 02:30:17PM +0200, Michael Paesold wrote: > I am sorry for kind of reposting this, but I have not got any response to my > patch sent for comment to hackers (Subject: Rollback on error): > http://archives.postgresql.org/pgsql-hackers/2004-09/msg00576.php > > I just want to f

[PATCHES] psql: rollback only last query on error

2004-09-21 Thread Michael Paesold
I am sorry for kind of reposting this, but I have not got any response to my patch sent for comment to hackers (Subject: Rollback on error): http://archives.postgresql.org/pgsql-hackers/2004-09/msg00576.php I just want to find out, if I should try to solve the issues with this patch (and add regre

Re: [PATCHES] psql \set case sensitive for boolean (OFF/off)

2004-09-21 Thread Michael Paesold
I wrote: > Patch attached. Is strcasecmp ok, or should pg_strcasecmp be used here? I don't know how I did it, but this was the wrong patch. Correct patch attached now. Best Regards, MIchael Paesold variables.c.diff Description: Binary data ---(end of broadcast)-

[PATCHES] psql \set case sensitive for boolean (OFF/off)

2004-09-21 Thread Michael Paesold
psql is currently case sensitive for boolean values in \set, only "off" is regarded as off, whereas "OFF" is regarded as on. There is a comment in the code that explains, why other values than "off" are always treated as true: "for backwards compatibility, anything except "off" is taken as "true"

Re: [PATCHES] Fix for VACUUM in psql autocommit off

2004-09-21 Thread Michael Paesold
> Tom Lane wrote: > > > > It is now fixed in the attached patch. > > > > Applied with some additional cleanup (the code wasn't multibyte-aware, > > and so could get fooled in some Far Eastern encodings). Looking at your cleanup is a good for learning more about C. :-) But I have one another que

Re: [PATCHES] [pgsql-hackers-win32] pg_autovacuum log paths can't contain spaces

2004-09-21 Thread Dave Page
> -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf > Of Barry Lind > Sent: 21 September 2004 00:46 > To: [EMAIL PROTECTED] > Subject: [pgsql-hackers-win32] pg_autovacuum log paths can't > contain spaces > > I just installed the beta2 Dev 3 version of