Re: [PATCHES] contrib/xml2: add function xml_encode_special_chars

2004-11-06 Thread Markus Bertheau
Ð ÐÑÐ, 07.11.2004, Ð 00:55, Peter Eisentraut ÐÐÑÐÑ: > Markus Bertheau wrote: > > It calls the similarly named function from libxml2. It replaces > > characters that carry a special meaning in XML (<, >, &, " and \r) > > with their respective XML entities. > > Where does this fit with the overall s

Re: [PATCHES] Add remove duplicate slashes to canonicalize_path()

2004-11-06 Thread Bruce Momjian
Andrew Dunstan wrote: > > > Bruce Momjian wrote: > > >*** 247,255 > > int len = strlen(path); > > > > if (len > 2 && strcmp(path + len - 2, "/.") == 0) > >-{ > > trim_directory(path); > >-} > >

Re: [PATCHES] Add remove duplicate slashes to canonicalize_path()

2004-11-06 Thread Andrew Dunstan
Bruce Momjian wrote: *** 247,255 int len = strlen(path); if (len > 2 && strcmp(path + len - 2, "/.") == 0) - { trim_directory(path); - } else if (len > 3 && strcmp(path + len - 3, "/..") == 0) { trim_directory(path); As a matter of style I hate this. Stripping

[PATCHES] Add remove duplicate slashes to canonicalize_path()

2004-11-06 Thread Bruce Momjian
The following applied patch removes duplicate slashes from the path in canonicalize_path(). It preserve double leading slashes on Win32. e.g.ab => /a/b -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If yo

[PATCHES] src/include/Makefile: remove-old-headers

2004-11-06 Thread Alvaro Herrera
Hackers, There is a remove-old-headers target in src/include/Makefile that is supposed to clean old headers "unless the user did a install-all-headers". Moreover, that target is invoked by the install target. Since the behavior previously known as install-all-headers is now the default, there's n

Re: [PATCHES] contrib/xml2: add function xml_encode_special_chars

2004-11-06 Thread Peter Eisentraut
Markus Bertheau wrote: > It calls the similarly named function from libxml2. It replaces > characters that carry a special meaning in XML (<, >, &, " and \r) > with their respective XML entities. Where does this fit with the overall scheme of things? I mean, you clearly wouldn't call that functi

Re: [PATCHES] contrib/xml2: add function xml_encode_special_chars

2004-11-06 Thread Markus Bertheau
Ð ÐÐÑ, 06.11.2004, Ð 23:13, Simon Riggs ÐÐÑÐÑ: > On Sat, 2004-11-06 at 00:36, Markus Bertheau wrote: > > Ð ÐÐÑ, 06.11.2004, Ð 01:24, Peter Eisentraut ÐÐÑÐÑ: > > > Markus Bertheau wrote: > > > > attached is a patch that adds the function xml_encode_special_chars > > > > to the xml2 contrib module. I

Re: [PATCHES] contrib/xml2: add function xml_encode_special_chars

2004-11-06 Thread Simon Riggs
On Sat, 2004-11-06 at 00:36, Markus Bertheau wrote: > Ð ÐÐÑ, 06.11.2004, Ð 01:24, Peter Eisentraut ÐÐÑÐÑ: > > Markus Bertheau wrote: > > > attached is a patch that adds the function xml_encode_special_chars > > > to the xml2 contrib module. It's against 8.0beta4. It's intended for > > > commit. > >

Re: [PATCHES] ON COMMIT and foreign keys

2004-11-06 Thread Bruce Momjian
Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > >> Tom Lane wrote: > > I think this is a feature addition that you've cleverly managed to > > present as a bug fix ;-). While I like the feature, I've got very > > mixed emotions about applying it this late in beta. > > > Ok, you caug

Re: [PATCHES] ON COMMIT and foreign keys

2004-11-06 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: >> Tom Lane wrote: > I think this is a feature addition that you've cleverly managed to > present as a bug fix ;-). While I like the feature, I've got very > mixed emotions about applying it this late in beta. > Ok, you caught me :-) Actually, I develop

Re: [PATCHES] ON COMMIT and foreign keys

2004-11-06 Thread Alvaro Herrera
> Tom Lane wrote: > > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > > Incidentally ("collateral damage"), the patch modifies the TRUNCATE > > > command so that it can work on multiple tables. In particular, if > > > foreign key references are all internal to the group that's being > > > truncated

Re: [PATCHES] psql \! WIN32 cleanup

2004-11-06 Thread Bruce Momjian
Dave Page wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > >> The attached applied patch tests for COMSPEC in the right place and > >> supplies a reasonable shell default on Win32. > >> > > + #define DEFAULT_SHELL "c:/windows/system32/cmd.exe" > > > Is it really a good idea to assume that the

Re: [PATCHES] psql \! WIN32 cleanup

2004-11-06 Thread Dave Page
-Original Message- From: [EMAIL PROTECTED] on behalf of Tom Lane Sent: Sat 11/6/2004 5:30 AM To: Bruce Momjian Cc: PostgreSQL-patches Subject: Re: [PATCHES] psql \! WIN32 cleanup Bruce Momjian <[EMAIL PROTECTED]> writes: >> The attached applied patch tests for COMSPEC in the right pla

Re: [PATCHES] psql \! WIN32 cleanup

2004-11-06 Thread Gaetano Mendola
Bruce Momjian wrote: Tom Lane wrote: Bruce Momjian <[EMAIL PROTECTED]> writes: The attached applied patch tests for COMSPEC in the right place and supplies a reasonable shell default on Win32. + #define DEFAULT_SHELL "c:/windows/system32/cmd.exe" Is it really a good idea to assume that the Windows