[PATCHES] diff -c please
This is a time when many patches are arriving, so reviewing patches efficiently is important. My understanding was that diff -c was the only approved patch submission format, but I note at least 3 people have submitted patches in other formats in the last week. It often seems like there's only a few people on the lists, but many people are watching. Sticking to diff -c format helps those people to review and comment back. I've not always done this myself, so forgive me for casting the first stone. This isn't aimed at anyone, just a general comment. -- Best Regards, Simon Riggs ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send unregister YourEmailAddressHere to [EMAIL PROTECTED])
Re: [PATCHES] PITR docs enhancements
On Fri, 2004-11-12 at 05:38, Gavin Sherry wrote: Just some docs enhancements based on feedback I received from a few recent talks on PITR. Gavin, You change includes this phrase: write them onto a tape drive (ensuring that you have a way of restoring the file with its original file name) to me, it seems you are saying that only tapes have the requirement to restore with the same name. That comment applies to all methods. If there is a particular command/mechanism that gives that problem, we should name and shame it. Tape is good, tape commands may not be. -- Best Regards, Simon Riggs ---(end of broadcast)--- TIP 8: explain analyze is your friend
Re: [PATCHES] diff -c please
Simon Riggs wrote: I note at least 3 people have submitted patches in other formats in the last week. I'm one of the guilty parties (as is Gavin, I'd imagine). As I explained in an earlier mail to -patches, the reason I've been submitting unified diffs is that Gavin and I have been using the Monotone version control system for development, and at present it only generates unified diffs. I've been meaning to submit a fix for that -- I'll send the Monotone folks a patch adding context diff support on Monday or Tuesday. So I pledge to stop sending unified diffs ASAP :) (BTW, I actually find unified diffs much easier to read. But since the consensus is apparently to prefer context diffs, I'm happy to oblige.) -Neil ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings
Re: [PATCHES] [PORTS] Windows XP could not get token information: 122
Title: Message Since nobody did :-), here is the patch to fix pgwin32_is_service() to use dynamic buffers. Fred - this applies to current cvs. There has been some error msg cleanups since beta4, so I'm not sure it'll apply cleanly to that one. //Magnus -Original Message-From: Magnus Hagander Sent: den 13 november 2004 23:56To: Fred Pederndong; [EMAIL PROTECTED]Subject: Re: [PORTS] Windows XP could not get token information: 122 This is clearly a case of oversight in my fix of token buffers in src/backend/port/win32/security.c. pgwin32_is_admin()correctly uses a dynamic buffer. pgwin32_is_service() does not. I'll code up a patch for this tomorrow, unless beaten to it. If you want to do it yourself, just copy the logic from is_admin to is_service. note that there are two calls to gettokeninformation in is_service - both need dynamic buffers. //Magnus -Original Message-From: Fred Pederndong [mailto:[EMAIL PROTECTED] Sent: den 9 november 2004 21:33To: [EMAIL PROTECTED]Subject: [PORTS] Windows XP could not get token information: 122 Greetings, I built postgreSQL 8.0 beta 4 from scratch on Windows XPSP1 using minGW/MSYS and encountered the following error when attempting to run the resulting executable: could not get token information: 122 I appreciate any help... Fred J. Do you Yahoo!?Check out the new Yahoo! Front Page. www.yahoo.com tokenbuffer2.patch Description: tokenbuffer2.patch ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
[PATCHES] Translation updates for 8.0: pg_dump-ru, pgscripts-ru
Hello Peter, Please install the attached translation updates. Thanks, -s pg_dump-ru.po.gz;pgscripts-ru.po.gz pg_dump-ru.po.gz Description: GNU Zip compressed data pgscripts-ru.po.gz Description: GNU Zip compressed data ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
[PATCHES] doc cleanup: proper emdashes
This patch replaces --- with mdash; in the documentation, which is the proper SGML character entity for an emdash. Barring any objections, I'll apply this to HEAD before the end of the day. -Neil # Old manifest: 01f0baf61d31b0bbe7563ce51fd262481b20ca57 # New manifest: fcb6532423fefa04824a2aefd07c4c9d7fe640b0 # Summary of changes: # # patch doc/src/sgml/array.sgml #from 1b00c69d094632ee14178f62930153152a3b2a94 # to 8052e2bef3e4d6de12fee8706e9a7222830882ff # # patch doc/src/sgml/backup.sgml #from 9af3e51f96d332e564060493443e172f1f5c9b5f # to 40aa68c313f097cdbfa630864b86ee1a65fa65ae # # patch doc/src/sgml/catalogs.sgml #from 66daa1980d14077db9fef757878cc7f1ea9e6644 # to 2a3562616974b84d37760722f88b70fec61a3de2 # # patch doc/src/sgml/datetime.sgml #from 83ba94e01004142ff3d45998136e288848dad8a9 # to f45c54ece8d562197f9cdae6d90c8d2e7e41e63a # # patch doc/src/sgml/ddl.sgml #from e96d2b97e6c97dbdbe1ff717839aa615efd8aede # to f29c9ba31362b3d5b84751266033742cc38cfa99 # # patch doc/src/sgml/dfunc.sgml #from b171f77de7b0131997837f55c9b8d6be310e6075 # to ad63f7cc25881541fc844617244df16725cf55a9 # # patch doc/src/sgml/errcodes.sgml #from c068effaebafa7e86a8ef1ba81bb9e4d725ae379 # to db00797ad0503ceb386a32fe2c1393ac9f86a234 # # patch doc/src/sgml/func.sgml #from 928b2aec84c396c5282bf8138fe9a3accdbc981f # to 4e1580d4a478afd8c9a70df19940f387b989f09d # # patch doc/src/sgml/information_schema.sgml #from dd030182cb6072a4554c451087c99281ea5adb4b # to 890d3c6b5142e9f30cf87a837e317430e6ad8b3a # # patch doc/src/sgml/libpq.sgml #from 038396930b6d0ce26a9bdd546421b1825e2d0228 # to 3bc6b064872ef91d95302029dd44a107c95c7f8e # # patch doc/src/sgml/maintenance.sgml #from aadb76dd1db108dd83304cbad49f6d7c35da8133 # to 5fe574c7e81cdfc8bff67a30c94f6ceffe44ec5f # # patch doc/src/sgml/mvcc.sgml #from 7159f3aad786afa521484da9fb789f9a11c8af61 # to 68951a11d2c7051dc2008ae40c543085e1012a90 # # patch doc/src/sgml/perform.sgml #from 3f5b510224a48f2d56bc7fd6ae809eec171438e2 # to 9f330a1a92bab64932253b7d5f14edadae523386 # # patch doc/src/sgml/plpgsql.sgml #from cf091d56e4b1c9554030d61099592b52e935d138 # to 08940a5da76b559f3a66136ab4523486481f08a1 # # patch doc/src/sgml/protocol.sgml #from 148daace598d221b4fb1de5ed596c788993c3266 # to bf8f3b8c0d4cf23aeba65dadfe70a2750487e2f0 # # patch doc/src/sgml/queries.sgml #from 4418fed2dbdb2c5621812bb3915ace53fb67dd66 # to fdd6f5d0a734e008276a12fb3a6a970b4f3febaf # # patch doc/src/sgml/query.sgml #from 3f6f4c6699fc8dd029ab5a7d27ad4e864d2cc406 # to 288c88918d3587f565d710a84c49885c35efabbc # # patch doc/src/sgml/ref/cluster.sgml #from acfd092cabdfc6f19ac901df0bc83ab551373d39 # to f6cfc959fcd35060bac1e3f6e6ae921204dc21e1 # # patch doc/src/sgml/ref/copy.sgml #from 661348d43626b2871e203d74fa7f976acc346287 # to 9fdc148930163d22540651fcfd0b07d4182f0158 # # patch doc/src/sgml/ref/declare.sgml #from 9961dae87ac389f5fe7593f664c15af5c76ed6b2 # to 689d73682b68411555b52f523191f2e45f9da7d7 # # patch doc/src/sgml/ref/lock.sgml #from e3dd1be0b6efde957b6a8f992377ff8da559c632 # to f0fbc57e3014961a6337ed2542cdd15ea6e749f0 # # patch doc/src/sgml/ref/postgres-ref.sgml #from e9388954ebb8d59144cee0bdd06d5d05f75a7007 # to d3010c3f04e96336e1bdc956b179bd7896b52785 # # patch doc/src/sgml/regress.sgml #from 86a51990076a31765b7275e05ba8f14bffc88464 # to b4ce3c46efb0c5b640ab3f1309b8cac9f9512dd1 # # patch doc/src/sgml/rules.sgml #from cf9e537241a6ee657e9ec461cad9bc6d512d1fb4 # to 136e5abe5960fd65b98901066f4cd9f1b68329c2 # # patch doc/src/sgml/sources.sgml #from f8d57c8d127dde3ab613d2c985f553befa05d3a4 # to d2bcbecbf2466dc9236b65310175c2c4b5baa104 # # patch doc/src/sgml/sql.sgml #from bf7cdc3dd1e8b057afa7d1688ad7b13e42e45953 # to 08953c131981ce3abc80c0028e11d0e1fe90d47a # # patch doc/src/sgml/syntax.sgml #from d9b5fe8f14229b801db59c7d138c19af0afcba1f # to 7f93fd4211e1f8cdffb42e0ff28954e1924e3129 # # patch doc/src/sgml/wal.sgml #from 9aa672dfa9ed46c1330677d16cbd985b1e5cbaa9 # to 30921a612739486af99e373e667ce7b1b882eb40 # # patch doc/src/sgml/xaggr.sgml #from 91d56faa5dddf742a1bfc79a49a87d7a495a28c4 # to e4c9732bf66e692185f9362a71b1737f97b77d5a # # patch doc/src/sgml/xfunc.sgml #from b73db6406df8b3d0196a9019753ac8596b8742f8 # to e19cfec736613f3abc13362355e6a3a607a288a3 # # patch doc/src/sgml/xindex.sgml #from 990371873d8aad33013647888af8add8b71bf5f9 # to dbcf718a136c57fc75d6921137562cb2bfbf9248 # # patch doc/src/sgml/xoper.sgml #from 063c6801cb4078757dccee5f799bce757e2dd12e # to e8f294f2be0d2c4f9f529aee7247471755c46897 # --- doc/src/sgml/array.sgml +++ doc/src/sgml/array.sgml @@ -49,7 +49,7 @@ /programlisting However, the current implementation does not
[PATCHES] Translation updates for 8.0: initdb-ru, psql-ru
Hello, Updated translations of initdb and psql. Please install. (German quotes replaced with English ones in the 2 source strings in initdb I pointed out earlier). -s initdb-ru.po.gz;psql-ru.po.gz initdb-ru.po.gz Description: GNU Zip compressed data psql-ru.po.gz Description: GNU Zip compressed data ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [PATCHES] doc cleanup: proper emdashes
On Mon, Nov 15, 2004 at 03:39:00PM +1100, Neil Conway wrote: On Mon, 2004-11-15 at 01:35 -0300, Alvaro Herrera wrote: Is . --- really correct? I think there should be no period there. Good catch -- I'll rephrase that text. ^^ Hey, this should have been a proper em-dash too (yours is an en-dash AFAIK) :-D (Though with a monospaced font it doesn't seem to make a lot of difference ... oh well) -- Alvaro Herrera ([EMAIL PROTECTED]) La rebeldÃa es la virtud original del hombre (Arthur Schopenhauer) ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [PATCHES] doc cleanup: proper emdashes
On Mon, Nov 15, 2004 at 11:27:39AM +1100, Neil Conway wrote: --- doc/src/sgml/dfunc.sgml +++ doc/src/sgml/dfunc.sgml @@ -38,7 +38,7 @@ in memory when they are loaded by the executable. (Object files intended for executables are usually not compiled that way.) The command to link a shared library contains special flags to - distinguish it from linking an executable. --- At least this is the + distinguish it from linking an executable. mdash; At least this is the theory. On some systems the practice is much uglier. /para Is . --- really correct? I think there should be no period there. -- Alvaro Herrera ([EMAIL PROTECTED]) When the proper man does nothing (wu-wei), his thought is felt ten thousand miles. (Lao Tse) ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
Re: [PATCHES] doc cleanup: proper emdashes
On Mon, 2004-11-15 at 01:35 -0300, Alvaro Herrera wrote: Is . --- really correct? I think there should be no period there. Good catch -- I'll rephrase that text. -Neil ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [PATCHES] doc cleanup: proper emdashes
On Mon, 2004-11-15 at 11:27 +1100, Neil Conway wrote: This patch replaces --- with mdash; in the documentation, which is the proper SGML character entity for an emdash. Patch applied. I also fixed up cases where -- was used in a similar fashion (-- might be considered an en dash, but AFAIK it is incorrect to use an en dash to designate a parenthetical comment anyway). -Neil ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faqs/FAQ.html
Re: [PATCHES] doc cleanup: proper emdashes
On Nov 15, 2004, at 3:35 PM, Neil Conway wrote: (-- might be considered an en dash, but AFAIK it is incorrect to use an en dash to designate a parenthetical comment anyway). Then again, wouldn't parentheses be the appropriate punctuation for a parenthetical comment? :P Michael Glaesemann grzm myrealbox com PS. I think the phrasing you're looking for is amplifying or explanatory text. Em dashes, commas, or parentheses can all serve this purpose. ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send unregister YourEmailAddressHere to [EMAIL PROTECTED])
