Dave Page wrote:
Theis patch supercedes *all* my earlier ones from today - apologies for
the noise, clearly I need a beer or 3 and a few nights away from the
laptop.
@@ -1166,7 +1166,9 @@
exit(0);
#ifdef WIN32
case 'E':
- args-service_dependencies = optarg;
+
It occurred to me that if we elog(ERROR) during VACUUM, the vacuum
activity hint will not be reset. This will result in all subsequent I/O
by the current backend being treated by the bufmgr as though it resulted
from VACUUM. While elog(ERROR) during VACUUM is not a common occurrence,
I don't
Alvaro Herrera wrote:
Hmm ... I think you should rather use a PG_TRY/PG_CATCH block.
Thanks for the suggestion, Alvaro -- I think that's a better way to go.
It means we can keep vacuum-specific stuff in vacuum.c, rather than
adding to AbortTransaction(). I'll post a revised patch tomorrow.
Neil Conway [EMAIL PROTECTED] writes:
It occurred to me that if we elog(ERROR) during VACUUM, the vacuum
activity hint will not be reset.
The code beginning at freelist.c line 645 is intended to deal with this.
Attached is a patch which resets the vacuum activity hint in
Rainer Brandt wrote:
Hi,
All places that mention the trigger event info hash pointer $_TD
end with the - characters. The hash keys are omitted.
That is certainly not what you wanted.
(Also, the code examples will not compile under Perl. (I didn't
try, but can see that they won't.))
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---
Neil Conway [EMAIL PROTECTED] writes:
Tom Lane wrote:
The code beginning at freelist.c line 645 is intended to deal with this.
Ah, good point -- sorry, I missed that. The code as-is should be fine, then.
Well, one point is that the flag bit is checked elsewhere in the same
file without
Tom Lane wrote:
The code beginning at freelist.c line 645 is intended to deal with this.
Ah, good point -- sorry, I missed that. The code as-is should be fine, then.
-Neil
---(end of broadcast)---
TIP 2: you can get off all lists at once with the
This has been saved for the 8.1 release:
http://momjian.postgresql.org/cgi-bin/pgpatches2
---
Euler Taveira de Oliveira wrote:
Bruce Momjian wrote:
This has been saved for the 8.1 release: