Re: [PATCHES] array_accum aggregate

2006-10-12 Thread Tom Lane
I wrote: > aggregate_state would have no other uses in the system, and its input > and output functions would raise an error, so type safety is assured > --- there would be no way to call either the sfunc or ffunc "manually", > except by passing a NULL value, which should be safe because that's wha

Re: [PATCHES] array_accum aggregate

2006-10-12 Thread Tom Lane
Stephen Frost <[EMAIL PROTECTED]> writes: > Another alternative would be to provide a seperate area for each > aggregate to put any other information it needs. I'm not convinced that that's necessary --- the cases we have at hand suggest that the transition function is perfectly capable of doing t

Re: [PATCHES] array_accum aggregate

2006-10-12 Thread Stephen Frost
* Tom Lane ([EMAIL PROTECTED]) wrote: > (However, now that we support nulls in arrays, meseems a more consistent > definition would be that it allows null inputs and just includes them in > the output. So probably you do need it non-strict.) This was my intention. > I'm inclined to think that th

Re: [PATCHES] Documentation fix for --with-ldap

2006-10-12 Thread Neil Conway
On Mon, 2006-09-04 at 10:23 +0200, Albe Laurenz wrote: > This is just a 'one line' change in the documentation of > the --with-ldap flag of ./configure Applied, thanks for the patch. (BTW, when trivial patches like this fall through the cracks, I'd encourage patch submitters to resend them if yo

Re: [PATCHES] [GENERAL] ISO week dates

2006-10-12 Thread Guillaume Lelarge
Peter Eisentraut a écrit : > Guillaume Lelarge wrote: >> I've tried to work on the first one, the ISO day field. My patch is >> attached and is against CVS HEAD. It only takes care of the code, >> nothing is done for documentation matter. It works with me : >> >> toto=# select to_char(('2006-10-'||

Re: [PATCHES] array_accum aggregate

2006-10-12 Thread Tom Lane
Stephen Frost <[EMAIL PROTECTED]> writes: > * Neil Conway ([EMAIL PROTECTED]) wrote: >> There is no guarantee why SQL NULL and PG_RETURN_XYZ(NULL) refer to the >> same thing -- use PG_RETURN_NULL() to return a SQL NULL value, or just >> make the function strict. > Huh, alright. I'll probably just

Re: [PATCHES] array_accum aggregate

2006-10-12 Thread Stephen Frost
* Neil Conway ([EMAIL PROTECTED]) wrote: > On Wed, 2006-10-11 at 00:51 -0400, Stephen Frost wrote: > > Here, the actual state type for any aggregate call is the array type > > !having the actual input type as elements. Note: array_accum() is now > > !a built-in aggregate which uses a

Re: [PATCHES] array_accum aggregate

2006-10-12 Thread Neil Conway
On Wed, 2006-10-11 at 00:51 -0400, Stephen Frost wrote: > An array_accum aggregate has existed in the documentation for quite > some time using the inefficient (for larger arrays) array_append > routine. My vague recollection is that array_accum() is only defined in the documentation because there

Re: [PATCHES] [GENERAL] ISO week dates

2006-10-12 Thread Peter Eisentraut
Guillaume Lelarge wrote: > I've tried to work on the first one, the ISO day field. My patch is > attached and is against CVS HEAD. It only takes care of the code, > nothing is done for documentation matter. It works with me : > > toto=# select to_char(('2006-10-'||a+2)::date, 'DAY') as "dow", >

[PATCHES] test_fsync on MinGW(win32)

2006-10-12 Thread Hiroshi Saito
Hi. I wanted to see this difference. It is somewhat ad hoc. However, It is more effective than it doesn't show it at all. -- MinGW(win32) -- $ test_fsync Simple write timing: write3.644000 Compare fsync times on write() and non-write() descriptor: (If the times are si

Re: [PATCHES] warning: "min" redefined of qsort.

2006-10-12 Thread Hiroshi Saito
Hi Tom-san. From: "Tom Lane" "Hiroshi Saito" <[EMAIL PROTECTED]> writes: I have warning with MinGW qsort.c:53:1: warning: "min" redefined I've fixed this by using Min() from c.h instead. Ahh, I was consideration shortage. Thanks!! Regards, Hiroshi Saito ---(

Re: [PATCHES] warning: "min" redefined of qsort.

2006-10-12 Thread Tom Lane
"Hiroshi Saito" <[EMAIL PROTECTED]> writes: > I have warning with MinGW > qsort.c:53:1: warning: "min" redefined I've fixed this by using Min() from c.h instead. regards, tom lane ---(end of broadcast)--- TIP 5: don't fo

Re: [PATCHES] [GENERAL] ISO week dates

2006-10-12 Thread Guillaume Lelarge
Heikki Linnakangas a ecrit le 12/10/2006 12:43: Guillaume Lelarge wrote: I've tried to work on the first one, the ISO day field. My patch is attached and is against CVS HEAD. It only takes care of the code, nothing is done for documentation matter. It works with me : I haven't been following

Re: [PATCHES] [GENERAL] ISO week dates

2006-10-12 Thread Heikki Linnakangas
Guillaume Lelarge wrote: I've tried to work on the first one, the ISO day field. My patch is attached and is against CVS HEAD. It only takes care of the code, nothing is done for documentation matter. It works with me : I haven't been following this thread, but I just wanted to point out that

Re: [PATCHES] [GENERAL] ISO week dates

2006-10-12 Thread Guillaume Lelarge
Peter Eisentraut a ecrit le 07/10/2006 09:01: Brendan Jurd wrote: * add an ISO day format pattern to to_char() called 'ID', which starts at Monday = 1, and * add an ISO year field to extract() called 'isoyear'? That seems reasonable. Do you volunteer? I've tried to work on the first one,