Re: [PATCHES] [HACKERS] \copy (query) delimiter syntax error

2007-02-04 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan <[EMAIL PROTECTED]> writes: The consequence will be, though, that psql will accept a syntax for "\copy (query) ..." that the corresponding backend command would reject were we not transforming it. That strikes me as potentially confusing. Perhaps. Wha

Re: [PATCHES] [HACKERS] \copy (query) delimiter syntax error

2007-02-04 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > The consequence will be, though, that psql will accept a syntax for > "\copy (query) ..." that the corresponding backend command would reject > were we not transforming it. That strikes me as potentially confusing. Perhaps. What about plan B: remove

Re: [PATCHES] [HACKERS] \copy (query) delimiter syntax error

2007-02-04 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan <[EMAIL PROTECTED]> writes: oh, good point. OK, I have cut this quick patch that will continue to accept the legacy syntax in psql in non-inline-query cases, but will make psql unreservedly emit new style syntax for COPY to the backend. Does that seem reaso

Re: [PATCHES] [HACKERS] writing new regexp functions

2007-02-04 Thread Jeremy Drake
On Sun, 4 Feb 2007, David Fetter wrote: > On Fri, Feb 02, 2007 at 07:01:33PM -0800, Jeremy Drake wrote: > > > Let me know if you see any bugs or issues with this code, and I am > > open to suggestions for further regression tests ;) > > > Things that I still want to look into: > > * regexp flags (

Re: [PATCHES] [pgsql-patches] Recalculating OldestXmin in a long-running vacuum

2007-02-04 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> BTW I've got serious reservations about whether this bit is safe: >> >>> + /* The table could've grown since vacuum started, and >>> there >>> +* might already be dead tuples on the new pages

Re: [PATCHES] [HACKERS] \copy (query) delimiter syntax error

2007-02-04 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > oh, good point. OK, I have cut this quick patch that will continue to > accept the legacy syntax in psql in non-inline-query cases, but will > make psql unreservedly emit new style syntax for COPY to the backend. > Does that seem reasonable, or is it

Re: [PATCHES] [BUGS] BUG #2221: Bad delimiters allowed in COPY ...

2007-02-04 Thread Tom Lane
Bruce Momjian writes: > Attached is a patch that errors for \r and \n in delimiter and > null. I am not convinced that this is a bug. Can you prove that there is no use-case for asking COPY to emit data in this style? Sure, COPY itself couldn't read it, but people sometimes feed COPY output to

Re: [PATCHES] [HACKERS] writing new regexp functions

2007-02-04 Thread David Fetter
On Fri, Feb 02, 2007 at 07:01:33PM -0800, Jeremy Drake wrote: > Let me know if you see any bugs or issues with this code, and I am > open to suggestions for further regression tests ;) > Things that I still want to look into: > * regexp flags (a la regexp_replace). One more text field at the end

[PATCHES] TM formating patch

2007-02-04 Thread Pavel Stehule
Hello, I am sorry for preview chotic mails. My web email client is stupid (I am too). This patch correct bug, when localized day or month names was incorectly trnasformed to lower or upper string. Regards Pavel Stehule _ Najde

Re: [PATCHES] this patch correct upper and lower case for translated month's and

2007-02-04 Thread Pavel Stehule
This short patch was too short. I send (I hope) last correct version. Multibyte lower, upper functions are called only for localized names, for others we call pg_tolower or pg_toupper still. Regards Pavel Stehule Hello, it's more correct patch and more short. Regards Pavel Stehule Wou

Re: [PATCHES] this patch correct upper and lower case for translated month's and

2007-02-04 Thread Pavel Stehule
This short patch is too short. I send (I hope) last correct version. Multibyte lower, upper functions are called only for localized names, for others we call pg_tolower or pg_toupper still. Regards Pavel Stehule Hello, it's more correct patch and more short. Regards Pavel Stehule Woul

Re: [PATCHES] this patch correct upper and lower case for translated month's and

2007-02-04 Thread Pavel Stehule
This short patch is too short. I send (I hope) last correct version. Multibyte lower, upper functions are called only for localized names, for others we call pg_tolower or pg_toupper still. Regards Pavel Stehule Hello, it's more correct patch and more short. Regards Pavel Stehule Woul

Re: [PATCHES] this patch correct upper and lower case for translated month's and

2007-02-04 Thread Pavel Stehule
Hello, it's more correct patch and more short. Regards Pavel Stehule Would you please modify this patch to use the functions in oracle_compat.c? --- Pavel Stehule wrote: > Hello, > > this patch correct bug in to_char

Re: [PATCHES] Remove log segment and log_id fields from pg_controldata

2007-02-04 Thread Simon Riggs
On Sat, 2007-02-03 at 20:37 -0500, Bruce Momjian wrote: > Your patch has been added to the PostgreSQL unapplied patches list at: > > http://momjian.postgresql.org/cgi-bin/pgpatches > > It will be applied as soon as one of the PostgreSQL committers reviews > and approves it. Tom applied th