Re: [PATCHES] bgwriter stats

Magnus Hagander [EMAIL PROTECTED] writes: This seems quite a bizarre way to do things. Why wouldn't you implement this functionality by shipping messages to the stats collector? Would you suggest doing the same with the checkpoint counter, that's already in shared mem? I want to expose that

Re: [PATCHES] Win32 shmem

On Tue, Mar 20, 2007 at 07:41:32AM +0100, Magnus Hagander wrote: Does it seem like I've overlooked anything obvious in this? I do get the feeling that this is too simple, but I don't know exactly where the problem is :-) I think you do still need the on_shmem_exit detach callback.

Re: [PATCHES] Win32 shmem

Magnus Hagander [EMAIL PROTECTED] writes: I think you do still need the on_shmem_exit detach callback. Ok, will look into that. Haven't tested that scenario. That was indeed so. Added in new version, attached. If it handles the restart-after-backend-crash scenario and correctly locks out

Re: [PATCHES] Fix race condition in size functions

Patch applied by Alvaro. --- Michael Fuhr wrote: Fix a race condition that caused pg_database_size() and pg_tablespace_size() to fail if an object was removed between calls to ReadDir() and stat(). Per discussion in

Re: [PATCHES] pgbench on mingw needs fflush

Magnus Hagander wrote: On Tue, Mar 13, 2007 at 05:09:15PM +0900, ITAGAKI Takahiro wrote: Tatsuo Ishii [EMAIL PROTECTED] wrote: Can we distinguish mingw case from others so that we could ifdef out the extra fflush()? The buffered stderr might be a bug of mingw After a little

[PATCHES] Make CLUSTER MVCC-safe

This patch makes CLUSTER MVCC-safe. Visibility information and update chains are preserved like in VACUUM FULL. I created a new generic rewriteheap-facility to handle rewriting tables in a visibility-preserving manner. All the update chain tracking is done in rewriteheap.c, the caller is

Re: [PATCHES] patch adding new regexp functions

Jeremy Drake wrote: The patch has been sitting in the unapplied patches queue for a while, and the inevitable bitrot finally caught up with it. This version of the patch is exactly the same as the one in the patches queue, except for using new, non-conflicting oids for the functions.

Re: [PATCHES] Code-Cleanup: char* - const char*

Neil Conway wrote: BTW, the preferred format for patches is context diffs, not unified diffs. FYI, for the type of diff he is supplying unified diffs are better because it is single-line changes, and you see the old/new lines next to each other; the developer's FAQ mentions this. -- Bruce

[PATCHES] HOT WIP Patch - Version 5.0

The version 5.0 of HOT WIP patch is attached. This fixes the VACUUM FULL issue with HOT. In all the earlier versions, I'd disabled VACUUM FULL. When we move the HOT-chain, we move the chains but don't carry the HOT_UPDATED or HEAP_ONLY flags and insert as many index entries as there are tuples

Re: [PATCHES] patch adding new regexp functions

Neil Conway [EMAIL PROTECTED] writes: * Comments like /* get text type oid, too lazy to do it some other way */ do not exactly inspire confidence :) Surely the code was just using the TEXTOID macro? If so, it does not require a comment. If not, it should be fixed ...

Re: [PATCHES] patch adding new regexp functions

On Wed, 21 Mar 2007, Tom Lane wrote: Neil Conway [EMAIL PROTECTED] writes: * Comments like /* get text type oid, too lazy to do it some other way */ do not exactly inspire confidence :) Surely the code was just using the TEXTOID macro? If so, it does not require a comment. If not, it