[PATCHES] Add chklocale.c to msvc build

2007-09-29 Thread Petr Jelinek
Hi, attached patch adds chklocale.c to pgportfiles in Mkvcbuild perl module (not really worth the .diff :)) This fixes MSVC build (see buildfarm errors with unresolved reference for _pg_get_encoding_from_locale). -- Regards Petr Jelinek (PJMODOS) Index: Mkvcbuild.pm

[PATCHES] ALTER TYPE RENAME

2007-09-29 Thread Petr Jelinek
Hi, I noticed we don't have ALTER TYPE foo RENAME TO bar command which would be handy for me especially for enum types. So I wrote this little patch (including very brief doc) which adds above syntax. It basically just does some checks and calls existing TypeRename function which is used for

Re: [PATCHES] Add chklocale.c to msvc build

2007-09-29 Thread Magnus Hagander
Petr Jelinek wrote: Hi, attached patch adds chklocale.c to pgportfiles in Mkvcbuild perl module (not really worth the .diff :)) This fixes MSVC build (see buildfarm errors with unresolved reference for _pg_get_encoding_from_locale). Similar patch applied. I put the chklocale.c file in pseudo

Re: [PATCHES] OpenSSL Applink

2007-09-29 Thread Dave Page
--- Original Message --- From: Tom Lane [EMAIL PROTECTED] To: Dave Page [EMAIL PROTECTED] Sent: 29/09/07, 01:28:09 Subject: Re: [PATCHES] OpenSSL Applink I concur with Magnus that it'll be better if there's not two code paths here. It's not entirely clear whether BIO_new_fp()

[PATCHES] set_ps_display during recovery

2007-09-29 Thread Simon Riggs
Small patch to set ps display during recovery, so we can see the current WAL file being processed in both crash and archive recovery. Very simple patch, but useful. Tested. -- Simon Riggs 2ndQuadrant http://www.2ndQuadrant.com Index: src/backend/access/transam/xlog.c

Re: [PATCHES] OpenSSL Applink

2007-09-29 Thread Tom Lane
Dave Page [EMAIL PROTECTED] writes: From: Tom Lane [EMAIL PROTECTED] ... It's not entirely clear whether BIO_new_fp() would avoid the problematic calls, but it doesn't look like it'd be hard to try. The last version of the patch I posted uses BIO_new_file() in all cases, and (from memory)

Re: [PATCHES] pgcrypto: fix for broken solaris openssl, v03

2007-09-29 Thread Zdenek Kotala
Marko Kreen wrote: solaris openssl refuses to handle keys longer than 128bits. * aes will crash on longer keys * blowfish will silently cut the key which can result data corruption to fix it: - test errors from AES functions - bf errors cannot be tested, do test encryption - change aes

Re: [PATCHES] pgcrypto: fix for broken solaris openssl, v03

2007-09-29 Thread Zdenek Kotala
Tom Lane wrote: Marko Kreen [EMAIL PROTECTED] writes: solaris openssl refuses to handle keys longer than 128bits. ... So something like the current patch should be still applied as a near-term fix. Applied to HEAD and 8.2. I wasn't sure if there was interest in patching further back, or if

Re: [PATCHES] pgcrypto: fix for broken solaris openssl, v03

2007-09-29 Thread Tom Lane
Zdenek Kotala [EMAIL PROTECTED] writes: Tom Lane wrote: Applied to HEAD and 8.2. I wasn't sure if there was interest in patching further back, or if the patch was meant to work further back. Let me know if you're not happy. PostgreSQL 8.1 is shipped with Solaris. We are interesting it to

Re: [PATCHES] ALTER TYPE RENAME

2007-09-29 Thread Tom Lane
I wrote: Hm, it's definitely a bug/oversight that AlterTypeNamespace doesn't make a similar test for that. On closer look, there *is* such a test, but it's down inside AlterTypeNamespaceInternal. regards, tom lane ---(end of

Re: [PATCHES] ALTER TYPE RENAME

2007-09-29 Thread Tom Lane
BTW, another issue this brings up is whether we should reject regression=# create type footyp as (f2 int); CREATE TYPE regression=# alter table footyp rename to foobar; ALTER TABLE Currently, since there's no ALTER TYPE RENAME command, this is useful functionality and I wouldn't want to forbid

Re: [PATCHES] set_ps_display during recovery

2007-09-29 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: Small patch to set ps display during recovery, so we can see the current WAL file being processed in both crash and archive recovery. Hmm, not right there, because we don't know that the file actually exists yet. Applied with modifications ...

Re: [PATCHES] OpenSSL Applink

2007-09-29 Thread Dave Page
Tom Lane wrote: Dave Page [EMAIL PROTECTED] writes: From: Tom Lane [EMAIL PROTECTED] ... It's not entirely clear whether BIO_new_fp() would avoid the problematic calls, but it doesn't look like it'd be hard to try. The last version of the patch I posted uses BIO_new_file() in all cases, and

Re: [PATCHES] ALTER TYPE RENAME

2007-09-29 Thread Petr Jelinek
Tom Lane wrote: BTW, another issue this brings up is whether we should reject regression=# create type footyp as (f2 int); CREATE TYPE regression=# alter table footyp rename to foobar; ALTER TABLE Currently, since there's no ALTER TYPE RENAME command, this is useful functionality and I

Re: [PATCHES] pgcrypto: fix for broken solaris openssl, v03

2007-09-29 Thread Zdenek Kotala
Tom Lane wrote: Zdenek Kotala [EMAIL PROTECTED] writes: Tom Lane wrote: Applied to HEAD and 8.2. I wasn't sure if there was interest in patching further back, or if the patch was meant to work further back. Let me know if you're not happy. PostgreSQL 8.1 is shipped with Solaris. We are

Re: [PATCHES] ALTER TYPE RENAME

2007-09-29 Thread Petr Jelinek
Tom Lane wrote: Hm, I'm not entirely sure if you got the point or not. For either relations or composite types, there is both a pg_class entry and a pg_type entry, and their names *must* stay in sync. We could allow people to rename both entries using either ALTER TABLE or ALTER TYPE, but the