> ------- Original Message ------- > From: Tom Lane <[EMAIL PROTECTED]> > To: Dave Page <[EMAIL PROTECTED]> > Sent: 29/09/07, 01:28:09 > Subject: Re: [PATCHES] OpenSSL Applink > > I concur with Magnus that it'll be better if there's not two code paths > here. It's not entirely clear whether BIO_new_fp() would avoid the > problematic calls, but it doesn't look like it'd be hard to try.
The last version of the patch I posted uses BIO_new_file() in all cases, and (from memory) BIO_get_fp() in the non-win32 case to get a FILE* to pass to fstat. I believe the problem is sharing FILE*'s between differing runtime versions used by openssl and the app. Coding it with BIO_new_file makes it less tempting for future changes to start mucking about with FILE*'s on Windows. Note that I've been away from my *nix boxes so I haven't tested the patch except on Windows yet. /D ---------------------------(end of broadcast)--------------------------- TIP 5: don't forget to increase your free space map settings
