Re: [PATCHES] LOCK_DEBUG documentation
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 Tom Lane replied: Documentation patch by Kevin L. McBride explaining LOCK_DEBUG options in detail. Should this stuff really go into the SGML documentation, when these options will certainly never be enabled anywhere except in developers' private builds? A few lines of comments in pg_config_manual.h seems a more appropriate solution. Call me a traditionalist, but I like all the documentation in one place, even if some of it it seldom used. For the record, these options have been enabled by myself and others in production systems for debugging purposes, and the lack of detail in that section while doing so led to the patch. The docs also has the advantage of being more available, searchable, and found via the web. - -- Greg Sabino Mullane [EMAIL PROTECTED] End Point Corporation PGP Key: 0x14964AC8 200805271012 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8 -BEGIN PGP SIGNATURE- iEYEAREDAAYFAkg8F04ACgkQvJuQZxSWSsjNiQCffXM6m8N6DGW9fP3LmVvIGMDo Y30AoJ0fD2G0n1j5g1HdOukFWppd8jgu =6tFr -END PGP SIGNATURE- -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches
[PATCHES] Doc patch: type modifiers
From http://developer.postgresql.org/pgdocs/postgres/sql-createtype.html : type_modifier_input_function The name of a function that converts numeric modifier(s) for the type into internal form. type_modifier_output_function The name of a function that converts the internal form of the type's modifier(s) to external textual form. But the paragraph above says: ...take one or more simple constants or identifiers as modifiers... So in the description of the input function, numeric is wrong, and should be something like textual (for the sake of symmetry). Patch attached. Regards, Jeff Davis diff --git a/doc/src/sgml/ref/create_type.sgml b/doc/src/sgml/ref/create_type.sgml index 641c13e..d7d1a0b 100644 --- a/doc/src/sgml/ref/create_type.sgml +++ b/doc/src/sgml/ref/create_type.sgml @@ -433,7 +433,7 @@ CREATE TYPE replaceable class=parametername/replaceable termreplaceable class=parametertype_modifier_input_function/replaceable/term listitem para - The name of a function that converts numeric modifier(s) for the type + The name of a function that converts textual modifier(s) for the type into internal form. /para /listitem -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches
Re: [PATCHES] Doc patch: type modifiers
Jeff Davis [EMAIL PROTECTED] writes: From http://developer.postgresql.org/pgdocs/postgres/sql-createtype.html : type_modifier_input_function The name of a function that converts numeric modifier(s) for the type into internal form. Yeah, this text is a holdover from the original user-definable-modifiers patch, in which the modifiers indeed had to be numbers. I don't quite like your suggestion of using textual, though, because that makes it sound like the input and output functions are exact inverses, which they are not. How about ... converts an array of modifier(s) for ...? regards, tom lane -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches
Re: [PATCHES] Doc patch: type modifiers
On Tue, 2008-05-27 at 12:08 -0400, Tom Lane wrote: Yeah, this text is a holdover from the original user-definable-modifiers patch, in which the modifiers indeed had to be numbers. I don't quite like your suggestion of using textual, though, because that makes it sound like the input and output functions are exact inverses, which they are not. How about ... converts an array of modifier(s) for ...? Sounds good to me. Regards, Jeff Davis -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches
Re: [PATCHES] Doc patch: type modifiers
Jeff Davis [EMAIL PROTECTED] writes: On Tue, 2008-05-27 at 12:08 -0400, Tom Lane wrote: How about ... converts an array of modifier(s) for ...? Sounds good to me. OK, done. regards, tom lane -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches
[PATCHES] guc config_enum_entry add hidden field
Tom Lane [EMAIL PROTECTED] writes: I am wondering if it's a good idea to hide the redundant entries to reduce clutter in the pg_settings display. (We could do this by adding a hidden boolean to struct config_enum_entry.) Thoughts? The Attached patch does just that... guc_config_enum_entry_hide.patch Description: Binary data -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches
