I wrote:
> I look forward to receiving feedback on this.
Peter Eisentraut wrote:
> Please send a patch in diff -c format. And don't put a single patch
> file in a tar file.
Thanks for the pointer. I'm quite new to this.
I've done some more revisions to the patch. This has mostly just involve
Heikki Linnakangas wrote:
> After reading the wikipedia article on Boyer-Moore search algorithm, it
> looks to me like this patch actually implements the simpler
> Boyer-Moore-Horspool algorithm that only uses one lookup table. That's
> probably fine, as it ought to be faster on small needles an
Heikki Linnakangas wrote:
> The skip table really should be constructed only once in
> text_position_start and stored in TextPositionState. That would make a
> big difference to the performance of those functions that call
> text_position_next repeatedly: replace_text, split_text and text_to_arr
Alvaro Herrera wrote:
>Oh, BTW: don't post to pgsql-patches. It's deprecated. Use
> pgsql-hackers instead.
I thought this too until I read
http://wiki.postgresql.org/wiki/Submitting_a_Patch
Which is correct?
David.
--
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To m
Tom Lane wrote:
> I looked this over a bit and was immediately confused by one thing:
> the introductory comment says that the skip table size ought to be based
> on the length of the haystack, which makes sense to me, but the code is
> actually initializing it on the basis of len2, ie, the length
Heikki Linnakangas Wrote:
> Tom Lane wrote:
> > Heikki Linnakangas <[EMAIL PROTECTED]> writes:
> >> Also, it would be nice to use B-M(-H) for LIKE as well.
> >
> > Right offhand, that seems impossible, at least in patterns with %.
> > Or were you thinking of trying to separate out the fixed substr
