Tom Lane said:
Jeremy Drake [EMAIL PROTECTED] writes:
On Sun, 2 Jul 2006, Tom Lane wrote:
Nah, it was a false alarm: I was looking at the first post-patch
report,
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=mongoosedt=2006-07-02%2003:30:01
but apparently mongoose had managed to pick up
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
So this patch was by no stretch of the imagination ready to apply,
but you did it anyway.
Right. What is your next question?
Perhaps why is the buildfarm failing would be appropriate.
Yes, that is appropriate,
On Sun, 2 Jul 2006, Tom Lane wrote:
Nah, it was a false alarm: I was looking at the first post-patch report,
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=mongoosedt=2006-07-02%2003:30:01
but apparently mongoose had managed to pick up a partially-updated
snapshot. The later reports
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
Perhaps why is the buildfarm failing would be appropriate.
Yes, that is appropriate, though it seems Neil's cleanup of the patch
has fixed it now. I see only a single stats failure and an initdb
failure in the
Jeremy Drake [EMAIL PROTECTED] writes:
On Sun, 2 Jul 2006, Tom Lane wrote:
Nah, it was a false alarm: I was looking at the first post-patch report,
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=mongoosedt=2006-07-02%2003:30:01
but apparently mongoose had managed to pick up a
Bruce Momjian [EMAIL PROTECTED] writes:
I ran pgindent on the tablecmds.c block of code, and cleaned up some
boolean assignments. There are a few XXX comments still in the code so
someone should look at those questions and either modify the code or
remove the comments.
So this patch was by
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
I ran pgindent on the tablecmds.c block of code, and cleaned up some
boolean assignments. There are a few XXX comments still in the code so
someone should look at those questions and either modify the code or
remove the comments.
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
So this patch was by no stretch of the imagination ready to apply,
but you did it anyway.
Right. What is your next question?
Perhaps why is the buildfarm failing would be appropriate.
regards, tom lane
I cleaned up the code and added some more documentation.
I think I've addressed all the concerns raised so far. Please tell me if I've
missed anything.
There were a few tangentially related issues that have come up that I think
are TODOs. I'm likely to tackle one or two of these next so I'm
