Re: [PATCHES] return can contains any row or record functions

2006-06-16 Thread Pavel Stehule
PROTECTED] CC: [EMAIL PROTECTED], pgsql-patches@postgresql.org Subject: Re: [PATCHES] return can contains any row or record functions Date: Wed, 14 Jun 2006 18:48:00 -0400 (EDT) Has any more work happened on this patch

Re: [PATCHES] return can contains any row or record functions

2006-06-15 Thread Bruce Momjian
--- Pavel Stehule wrote: Not from my side Regards Pavel Stehule From: Bruce Momjian pgman@candle.pha.pa.us To: Pavel Stehule [EMAIL PROTECTED] CC: [EMAIL PROTECTED], pgsql-patches@postgresql.org Subject: Re: [PATCHES] return can contains any row or record functions Date: Wed, 14

Re: [PATCHES] return can contains any row or record functions

2006-06-14 Thread Bruce Momjian
Has any more work happened on this patch? --- Pavel Stehule wrote: - we can't use estate-rsi for the RETURN case, at least as presently implemented, because that is not always filled-out -- the example I gave before

Re: [PATCHES] return can contains any row or record functions

2006-06-14 Thread Pavel Stehule
Not from my side Regards Pavel Stehule From: Bruce Momjian pgman@candle.pha.pa.us To: Pavel Stehule [EMAIL PROTECTED] CC: [EMAIL PROTECTED], pgsql-patches@postgresql.org Subject: Re: [PATCHES] return can contains any row or record functions Date: Wed, 14 Jun 2006 18:48:00 -0400 (EDT) Has

Re: [PATCHES] return can contains any row or record functions

2005-12-03 Thread Bruce Momjian
Where are we on this patch? I don't see it as applied to CVS. --- Pavel Stehule wrote: - we can't use estate-rsi for the RETURN case, at least as presently implemented, because that is not always filled-out -- the

Re: [PATCHES] return can contains any row or record functions

2005-11-09 Thread Neil Conway
On Tue, 2005-08-11 at 08:55 +0100, Pavel Stehule wrote: Sorry for my ugly english. Sorry, I didn't understand your reply. The problem is this: - we need to find the TupleDesc of the function's expected return type for tuple-returning functions - we can't use estate-rsi for the RETURN case, at

Re: [PATCHES] return can contains any row or record functions

2005-11-09 Thread Pavel Stehule
- we can't use estate-rsi for the RETURN case, at least as presently implemented, because that is not always filled-out -- the example I gave before shows how because we don't check for a compatible TupleDesc when estate-rsi is NULL, we end up returning a value that is incompatible with the

[PATCHES] return can contains any row or record functions

2005-11-07 Thread Pavel Stehule
Hello this patch allow using any row or record expression in return, return next statement in row, record functions - per request John Berkus http://archives.postgresql.org/pgsql-hackers/2005-10/msg01350.php regards Pavel Stehule

Re: [PATCHES] return can contains any row or record functions

2005-11-07 Thread Tom Lane
Neil Conway [EMAIL PROTECTED] writes: On Mon, 2005-07-11 at 14:58 +0100, Pavel Stehule wrote: this patch allow using any row or record expression in return, return next statement in row, record functions I'll review and apply this in the next day or two. Seems like it's past time to pay

Re: [PATCHES] return can contains any row or record functions

2005-11-07 Thread Neil Conway
I'm confused by this part of the patch, circa line 1835 of pl_exec.c: /* coerce type if needed */ if (estate-rsi IsA(estate-rsi, ReturnSetInfo) estate-rsi-expectedDesc != NULL !compatible_tupdesc(estate-rsi-expectedDesc, in_tupdesc)) { estate-retval = (Datum)

Re: [PATCHES] return can contains any row or record functions

2005-11-07 Thread Pavel Stehule
From: Neil Conway [EMAIL PROTECTED] To: Pavel Stehule [EMAIL PROTECTED] CC: pgsql-patches@postgresql.org Subject: Re: [PATCHES] return can contains any row or record functions Date: Mon, 07 Nov 2005 18:10:13 -0500 I'm confused by this part of the patch, circa line 1835 of pl_exec.c