Re: [PATCHES] pg_dump --clean w/ = 7.2 server

2004-07-10 Thread Bruce Momjian

Where are we on this?

---

Tom Lane wrote:
 Kris Jurka [EMAIL PROTECTED] writes:
  Possibly the most correct solution is to assign the name public to the
  dummy schema that pg_dump creates internally when talking to a pre-7.3
  server.
 
  I was considering that they might want to restore the dump into another 
  schema and that would be easier with an unqualified name.  I don't really 
  understand why the name needs to be fully qualified in the first place.
 
 Because it's entirely too likely that you'll drop the wrong thing if you
 issue an unqualified DROP.
 
   regards, tom lane
 
 ---(end of broadcast)---
 TIP 3: if posting/reading through Usenet, please send an appropriate
   subscribe-nomail command to [EMAIL PROTECTED] so that your
   message can get through to the mailing list cleanly
 

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  [EMAIL PROTECTED]   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073

---(end of broadcast)---
TIP 2: you can get off all lists at once with the unregister command
(send unregister YourEmailAddressHere to [EMAIL PROTECTED])


Re: [PATCHES] pg_dump --clean w/ = 7.2 server

2004-06-24 Thread Christopher Kings-Lynne
When running pg_dump --clean against a server that doesn't have schemas 
the namespace is blank and ends up producing a dump full off things like:

DROP TABLE .tab;
Since the person is dumping using 7.5 pg_dump, presumably they will be 
restoring to 7.5, and it should be:

DROP TABLE public.tab;
Chris
---(end of broadcast)---
TIP 8: explain analyze is your friend


Re: [PATCHES] pg_dump --clean w/ = 7.2 server

2004-06-24 Thread Tom Lane
Christopher Kings-Lynne [EMAIL PROTECTED] writes:
 When running pg_dump --clean against a server that doesn't have schemas 
 the namespace is blank and ends up producing a dump full off things like:
 
 DROP TABLE .tab;

 Since the person is dumping using 7.5 pg_dump, presumably they will be 
 restoring to 7.5, and it should be:

 DROP TABLE public.tab;

Possibly the most correct solution is to assign the name public to the
dummy schema that pg_dump creates internally when talking to a pre-7.3
server.

I seem to recall that there was some reason for using , but I don't
recall what exactly.

regards, tom lane

---(end of broadcast)---
TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]


Re: [PATCHES] pg_dump --clean w/ = 7.2 server

2004-06-24 Thread Kris Jurka


On Thu, 24 Jun 2004, Tom Lane wrote:

 Christopher Kings-Lynne [EMAIL PROTECTED] writes:
  When running pg_dump --clean against a server that doesn't have schemas 
  the namespace is blank and ends up producing a dump full off things like:
  
  DROP TABLE .tab;
 
  Since the person is dumping using 7.5 pg_dump, presumably they will be 
  restoring to 7.5, and it should be:
 
  DROP TABLE public.tab;
 
 Possibly the most correct solution is to assign the name public to the
 dummy schema that pg_dump creates internally when talking to a pre-7.3
 server.

I was considering that they might want to restore the dump into another 
schema and that would be easier with an unqualified name.  I don't really 
understand why the name needs to be fully qualified in the first place.

 I seem to recall that there was some reason for using , but I don't
 recall what exactly.
 

It seems like the only possible reasons are deliberately making it fail or 
just a lack of testing.  There's no way it does anything useful.

Kris Jurka

---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
  subscribe-nomail command to [EMAIL PROTECTED] so that your
  message can get through to the mailing list cleanly


Re: [PATCHES] pg_dump --clean w/ = 7.2 server

2004-06-24 Thread Tom Lane
Kris Jurka [EMAIL PROTECTED] writes:
 Possibly the most correct solution is to assign the name public to the
 dummy schema that pg_dump creates internally when talking to a pre-7.3
 server.

 I was considering that they might want to restore the dump into another 
 schema and that would be easier with an unqualified name.  I don't really 
 understand why the name needs to be fully qualified in the first place.

Because it's entirely too likely that you'll drop the wrong thing if you
issue an unqualified DROP.

regards, tom lane

---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
  subscribe-nomail command to [EMAIL PROTECTED] so that your
  message can get through to the mailing list cleanly