Re: [PATCHES] [HACKERS] BEGIN vs START TRANSACTION

2003-11-10 Thread Alvaro Herrera
On Mon, Nov 10, 2003 at 11:23:20AM -0500, Tom Lane wrote: > IIRC, the code patch only added about two lines to gram.y. It seems a > bit silly to add *more* lines of documentation to explain that the two > statements aren't alike than it would take lines of code to make them > work alike. But may

Re: [PATCHES] [HACKERS] BEGIN vs START TRANSACTION

2003-11-10 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Jan Wieck wrote: >> Since BEGIN isn't standard, wouldn't it be time to redirect them on the >> BEGIN manpage to the START TRANSACTION manpage and tell them there that >> BEGIN does not support the full syntax of START TRANSACTION? > Yea, we could do th

Re: [PATCHES] [HACKERS] BEGIN vs START TRANSACTION

2003-11-10 Thread Bruce Momjian
Jan Wieck wrote: > Bruce Momjian wrote: > > > Tom Lane wrote: > >> Bruce Momjian <[EMAIL PROTECTED]> writes: > >> > Peter Eisentraut wrote: > >> >> I object to adding unnecessary complications like that. > >> > >> > Shouldn't BEGIN and START TRANSACTION have the same mechanics? The > >> > change

Re: [PATCHES] [HACKERS] BEGIN vs START TRANSACTION

2003-11-10 Thread Jan Wieck
Bruce Momjian wrote: Tom Lane wrote: Bruce Momjian <[EMAIL PROTECTED]> writes: > Peter Eisentraut wrote: >> I object to adding unnecessary complications like that. > Shouldn't BEGIN and START TRANSACTION have the same mechanics? The > changes to the code were the addition of only one line. The r

Re: [PATCHES] [HACKERS] BEGIN vs START TRANSACTION

2003-11-09 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Peter Eisentraut wrote: > >> I object to adding unnecessary complications like that. > > > Shouldn't BEGIN and START TRANSACTION have the same mechanics? The > > changes to the code were the addition of only one line. The rest of th

Re: [PATCHES] [HACKERS] BEGIN vs START TRANSACTION

2003-11-09 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Peter Eisentraut wrote: >> I object to adding unnecessary complications like that. > Shouldn't BEGIN and START TRANSACTION have the same mechanics? The > changes to the code were the addition of only one line. The rest of the > patch was docs. My init

Re: [PATCHES] [HACKERS] BEGIN vs START TRANSACTION

2003-11-09 Thread Bruce Momjian
Peter Eisentraut wrote: > Bruce Momjian writes: > > > In fact, the BEGIN manual page says: > > > > >endterm="sql-start-transaction-title"> has the same functionality > >as BEGIN. > > > > which is currently not true because START TRANSACTION has additional > > options. > > Then the tha

Re: [PATCHES] [HACKERS] BEGIN vs START TRANSACTION

2003-11-09 Thread Peter Eisentraut
Bruce Momjian writes: > In fact, the BEGIN manual page says: > >endterm="sql-start-transaction-title"> has the same functionality >as BEGIN. > > which is currently not true because START TRANSACTION has additional > options. Then the that manual page should be fixed. > The following

Re: [PATCHES] [HACKERS] BEGIN vs START TRANSACTION

2003-11-08 Thread Bruce Momjian
Gaetano Mendola wrote: > Hi all, > why START TRANSACTION READ ONLY is allowed > and not BEGIN READ ONLY ? Seems it should be allowed so that BEGIN and START TRANSACTION behave the same. In fact, the BEGIN manual page says: has the same functionality as BEGIN. which is currently not true