[PATCHES] Doc patch: type modifiers
From http://developer.postgresql.org/pgdocs/postgres/sql-createtype.html : type_modifier_input_function The name of a function that converts numeric modifier(s) for the type into internal form. type_modifier_output_function The name of a function that converts the internal form of the type's modifier(s) to external textual form. But the paragraph above says: ...take one or more simple constants or identifiers as modifiers... So in the description of the input function, numeric is wrong, and should be something like textual (for the sake of symmetry). Patch attached. Regards, Jeff Davis diff --git a/doc/src/sgml/ref/create_type.sgml b/doc/src/sgml/ref/create_type.sgml index 641c13e..d7d1a0b 100644 --- a/doc/src/sgml/ref/create_type.sgml +++ b/doc/src/sgml/ref/create_type.sgml @@ -433,7 +433,7 @@ CREATE TYPE replaceable class=parametername/replaceable termreplaceable class=parametertype_modifier_input_function/replaceable/term listitem para - The name of a function that converts numeric modifier(s) for the type + The name of a function that converts textual modifier(s) for the type into internal form. /para /listitem -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches
Re: [PATCHES] Doc patch: type modifiers
Jeff Davis [EMAIL PROTECTED] writes: From http://developer.postgresql.org/pgdocs/postgres/sql-createtype.html : type_modifier_input_function The name of a function that converts numeric modifier(s) for the type into internal form. Yeah, this text is a holdover from the original user-definable-modifiers patch, in which the modifiers indeed had to be numbers. I don't quite like your suggestion of using textual, though, because that makes it sound like the input and output functions are exact inverses, which they are not. How about ... converts an array of modifier(s) for ...? regards, tom lane -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches
Re: [PATCHES] Doc patch: type modifiers
On Tue, 2008-05-27 at 12:08 -0400, Tom Lane wrote: Yeah, this text is a holdover from the original user-definable-modifiers patch, in which the modifiers indeed had to be numbers. I don't quite like your suggestion of using textual, though, because that makes it sound like the input and output functions are exact inverses, which they are not. How about ... converts an array of modifier(s) for ...? Sounds good to me. Regards, Jeff Davis -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches
Re: [PATCHES] Doc patch: type modifiers
Jeff Davis [EMAIL PROTECTED] writes: On Tue, 2008-05-27 at 12:08 -0400, Tom Lane wrote: How about ... converts an array of modifier(s) for ...? Sounds good to me. OK, done. regards, tom lane -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches
