Re: [PATCHES] Fix for initdb failures on Vista

2008-03-04 Thread Dave Page
On Fri, Feb 29, 2008 at 6:41 PM, Magnus Hagander [EMAIL PROTECTED] wrote: Will you provide a patch for that, or should I? (I remind you I have no box ready to reproduce it on, so it helps a lot if you can do it :-P) Patch attached. Tested on XP and Vista. -- Dave Page EnterpriseDB UK Ltd:

Re: [PATCHES] Fix for initdb failures on Vista

2008-03-04 Thread Magnus Hagander
On Tue, Mar 04, 2008 at 03:28:30PM +, Dave Page wrote: On Fri, Feb 29, 2008 at 6:41 PM, Magnus Hagander [EMAIL PROTECTED] wrote: Will you provide a patch for that, or should I? (I remind you I have no box ready to reproduce it on, so it helps a lot if you can do it :-P) Patch

Re: [PATCHES] Fix for initdb failures on Vista

2008-02-29 Thread Dave Page
On Fri, Feb 29, 2008 at 3:25 PM, Magnus Hagander [EMAIL PROTECTED] wrote: I noticed that as well when looking at the code, but since I ran my tests on non-vista platforms I didn't hit the actual problem. Dave - it shuold be a simple case of adding the same line of code to the regression

Re: [PATCHES] Fix for initdb failures on Vista

2008-02-29 Thread Magnus Hagander
On Fri, Feb 29, 2008 at 12:17:51AM -0500, Andrew Dunstan wrote: Dave Page wrote: The attached patch fixes problems reported primarily on Vista, but also on some Windows 2003 and XP installations in which initdb reports that it cannot find postgres.exe. This occurs because of

Re: [PATCHES] Fix for initdb failures on Vista

2008-02-29 Thread Magnus Hagander
Dave Page wrote: On Fri, Feb 29, 2008 at 3:25 PM, Magnus Hagander [EMAIL PROTECTED] wrote: I noticed that as well when looking at the code, but since I ran my tests on non-vista platforms I didn't hit the actual problem. Dave - it shuold be a simple case of adding the same line of code to the

Re: [PATCHES] Fix for initdb failures on Vista

2008-02-28 Thread Andrew Dunstan
Dave Page wrote: The attached patch fixes problems reported primarily on Vista, but also on some Windows 2003 and XP installations in which initdb reports that it cannot find postgres.exe. This occurs because of security-related changes implemented in Windows Vista and recent patches on older

Re: [PATCHES] Fix for initdb failures on Vista

2008-02-27 Thread Magnus Hagander
On Thu, Feb 21, 2008 at 03:02:07PM +, Dave Page wrote: The attached patch fixes problems reported primarily on Vista, but also on some Windows 2003 and XP installations in which initdb reports that it cannot find postgres.exe. This occurs because of security-related changes implemented

Re: [PATCHES] Fix for initdb failures on Vista

2008-02-27 Thread Andrew Dunstan
Magnus Hagander wrote: I've tested on Vista and XP, but additional testing would be useful (Andrew, Magnus?). Please apply to head, 8.3 and 8.2 Other than Heikkis comments: We obviously need to test-build on mingw, so if someone can do that, pleae do. If not, I'll try to get my VM up

Re: [PATCHES] Fix for initdb failures on Vista

2008-02-25 Thread Heikki Linnakangas
Dave Page wrote: The attached patch fixes problems reported primarily on Vista, but also on some Windows 2003 and XP installations in which initdb reports that it cannot find postgres.exe. A couple of minor nitpicks: Regarding the AddUserToDaclCleanup helper function, I would suggest putting

[PATCHES] Fix for initdb failures on Vista

2008-02-21 Thread Dave Page
The attached patch fixes problems reported primarily on Vista, but also on some Windows 2003 and XP installations in which initdb reports that it cannot find postgres.exe. This occurs because of security-related changes implemented in Windows Vista and recent patches on older OS's. When running