Re: [PATCHES] Sun Studio on Linux spinlock patch

2008-04-24 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > So, is this a feature we want? I have no objection to being able to use Sun Studio, but the submitted patch seemed to need a lot of work yet ... regards, tom lane -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql

Re: [PATCHES] Sun Studio on Linux spinlock patch

2008-04-24 Thread Bruce Momjian
So, is this a feature we want? --- Julius Stroffek wrote: > Tom Lane wrote: > > This patch seems broken in a number of ways. Why are you removing > > -DLINUX_PROFILE, for example? Are you sure you don't need -D_GNU_SOURCE?

Re: [PATCHES] Sun Studio on Linux spinlock patch

2008-03-10 Thread Julius Stroffek
Tom Lane wrote: This patch seems broken in a number of ways. Why are you removing -DLINUX_PROFILE, for example? Are you sure you don't need -D_GNU_SOURCE? And why add -DSUNOS4_CC, which is a Solaris-specific define (not that we seem to be using it anywhere anymore)? Do we really have to have a

Re: [PATCHES] Sun Studio on Linux spinlock patch

2008-03-05 Thread Zdenek Kotala
Tom Lane napsal(a): But I guess the *real* question is why anyone would care ... what benefit is there to using Sun's compiler on Linux? There are severals benefits: 1) Sun Studio is not only compiler. It has a lot of tools like performance analyzer/profiler, memory checker ... There are gr

Re: [PATCHES] Sun Studio on Linux spinlock patch

2008-03-05 Thread Tom Lane
Julius Stroffek <[EMAIL PROTECTED]> writes: > I have made PostgreSQL to compile on linux using sun studio with > spinlock support. The patch is attached. Here is the explanation of > changes I made: This patch seems broken in a number of ways. Why are you removing -DLINUX_PROFILE, for example?

[PATCHES] Sun Studio on Linux spinlock patch

2008-03-05 Thread Julius Stroffek
Hi All, I have made PostgreSQL to compile on linux using sun studio with spinlock support. The patch is attached. Here is the explanation of changes I made: I renamed the following files solaris_x86.s solaris_sparch.s to sunstudio_x86.s sunstudio_sparch.s because the code is used on linux a