Re: [PATCHES] Uninstall scripts for contrib

2006-02-27 Thread Peter Eisentraut
Am Mittwoch, 22. Februar 2006 08:31 schrieb David Fetter: > It applied just fine against the CVSup version. This one should apply > against CVS TIP. Done. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 6

Re: [PATCHES] Uninstall scripts for contrib

2006-02-21 Thread David Fetter
On Sat, Feb 18, 2006 at 07:08:15PM +0100, Peter Eisentraut wrote: > David Fetter wrote: > > This one should do it. > > This patch fails to apply all over the place. It applied just fine against the CVSup version. This one should apply against CVS TIP. Cheers, D -- David Fetter [EMAIL PROTECTED

Re: [PATCHES] Uninstall scripts for contrib

2006-02-18 Thread Peter Eisentraut
David Fetter wrote: > This one should do it. This patch fails to apply all over the place. Please fix it so we don't have to sort out the chunks manually. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP

Re: [PATCHES] Uninstall scripts for contrib

2006-02-12 Thread David Fetter
On Sat, Feb 11, 2006 at 11:37:49PM -0500, Bruce Momjian wrote: > David Fetter wrote: > > On Sun, Jan 15, 2006 at 09:55:39PM -0800, David Fetter wrote: > > > On Mon, Jan 16, 2006 at 12:13:11AM -0500, Neil Conway wrote: > > > > On Sun, 2006-01-15 at 20:08 -0800, David Fetter wrote: > > > > > > > >

Re: [PATCHES] Uninstall scripts for contrib

2006-02-11 Thread Bruce Momjian
David Fetter wrote: > On Sun, Jan 15, 2006 at 09:55:39PM -0800, David Fetter wrote: > > On Mon, Jan 16, 2006 at 12:13:11AM -0500, Neil Conway wrote: > > > On Sun, 2006-01-15 at 20:08 -0800, David Fetter wrote: > > > > > > > > ifdef USE_PGXS > > > > > > The change to $PostgreSQL$ is bogus (pe

Re: [PATCHES] Uninstall scripts for contrib

2006-01-24 Thread David Fetter
On Sun, Jan 15, 2006 at 09:55:39PM -0800, David Fetter wrote: > On Mon, Jan 16, 2006 at 12:13:11AM -0500, Neil Conway wrote: > > On Sun, 2006-01-15 at 20:08 -0800, David Fetter wrote: > > > > > > ifdef USE_PGXS > > > > The change to $PostgreSQL$ is bogus (perhaps due to the way you > > setup

Re: [PATCHES] Uninstall scripts for contrib

2006-01-19 Thread Jim C. Nasby
On Thu, Jan 19, 2006 at 11:48:54AM -0800, David Fetter wrote: > On Thu, Jan 19, 2006 at 07:08:28PM +0100, Peter Eisentraut wrote: > > David Fetter wrote: > > > It's paper bag time for me. How about a new patch which gives > > > each contrib project its own directory and places them there? > > > >

Re: [PATCHES] Uninstall scripts for contrib

2006-01-19 Thread Bruce Momjian
Removed at submitter request. --- David Fetter wrote: > On Mon, Jan 16, 2006 at 12:13:11AM -0500, Neil Conway wrote: > > On Sun, 2006-01-15 at 20:08 -0800, David Fetter wrote: > > > > > > ifdef USE_PGXS > > > > The ch

Re: [PATCHES] Uninstall scripts for contrib

2006-01-19 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > David Fetter wrote: >> It's paper bag time for me. How about a new patch which gives each >> contrib project its own directory and places them there? > This would presumably imply that the installation scripts would be > renamed to install.sql. On

Re: [PATCHES] Uninstall scripts for contrib

2006-01-19 Thread David Fetter
On Thu, Jan 19, 2006 at 07:08:28PM +0100, Peter Eisentraut wrote: > David Fetter wrote: > > It's paper bag time for me. How about a new patch which gives > > each contrib project its own directory and places them there? > > This would presumably imply that the installation scripts would be > rena

Re: [PATCHES] Uninstall scripts for contrib

2006-01-19 Thread Peter Eisentraut
David Fetter wrote: > It's paper bag time for me. How about a new patch which gives each > contrib project its own directory and places them there? This would presumably imply that the installation scripts would be renamed to install.sql. On a green field this might make sense but as it is may

Re: [PATCHES] Uninstall scripts for contrib

2006-01-19 Thread David Fetter
On Thu, Jan 19, 2006 at 02:22:17PM +0100, Peter Eisentraut wrote: > Am Montag, 16. Januar 2006 06:55 schrieb David Fetter: > > Oops. My FM R'ing skills need some work. This patch includes the > > files. > > This patch is rather useless because all the uninstall.sql files > install on top of each

Re: [PATCHES] Uninstall scripts for contrib

2006-01-19 Thread Peter Eisentraut
Am Montag, 16. Januar 2006 06:55 schrieb David Fetter: > Oops. My FM R'ing skills need some work. This patch includes the > files. This patch is rather useless because all the uninstall.sql files install on top of each other. I suggest naming them cube_uninstall.sql dblink_uninstall.sql etc.

Re: [PATCHES] Uninstall scripts for contrib

2006-01-18 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Da

Re: [PATCHES] Uninstall scripts for contrib

2006-01-15 Thread David Fetter
On Mon, Jan 16, 2006 at 12:13:11AM -0500, Neil Conway wrote: > On Sun, 2006-01-15 at 20:08 -0800, David Fetter wrote: > > > > ifdef USE_PGXS > > The change to $PostgreSQL$ is bogus (perhaps due to the way you > setup cvsup?), as are all the other $PostgreSQL$ changes in the > patch. Also, th

Re: [PATCHES] Uninstall scripts for contrib

2006-01-15 Thread Neil Conway
On Sun, 2006-01-15 at 20:08 -0800, David Fetter wrote: > *** contrib/chkpass/Makefile27 Sep 2005 17:13:00 - 1.7 > --- contrib/chkpass/Makefile14 Jan 2006 23:16:03 - > *** > *** 1,9 > ! # $PostgreSQL: pgsql/contrib/chkpass/Makefile,v 1.6 2004/08/20 > 20:13:02 mo

[PATCHES] Uninstall scripts for contrib

2006-01-15 Thread David Fetter
Folks, Please find attached a patch against CVS TIP which adds an uninstall script in SQL for each of the things where it would be appropriate. Contrib modules that already have an uninstall script are left as-is, as are ones which create stand-alone executeables, as I believe that we need to disc