Matthew T. O'Connor [EMAIL PROTECTED] writes:
I agree. The thought had crossed my mind that autovac should shut down
first, but I'm really not sure how to make that happen.
You have to issue the kill() when the postmaster first receives the
shutdown signal, rather than waiting till after all
Matthew T. O'Connor [EMAIL PROTECTED] writes:
Please apply to CVS or tell me what I need to change to get it applied.
I looked over this patch (sorry for the delay), and found a number of
problems.
Bigger problems:
* I don't think you've thought through system shutdown at all. The
postmaster
Tom Lane wrote:
I'm not sure what we do now. I can't apply this in its current state,
and I do not have time to fix it. I don't really want to push it in
and assume we can fix the problems during beta ...
I see. :-(
I know Matthew just got back from being away so perhaps he has time to
Bruce Momjian [EMAIL PROTECTED] writes:
As far as libpq, can't pg_autovacuum dynamically load libpq like dblink
does?
Hmm, make the bulk of the autovac daemon be a shlib that is dynamically
linked by just that subprocess? Yeah, that might work.
On the password issue, can't we use .pgpass in
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
As far as libpq, can't pg_autovacuum dynamically load libpq like dblink
does?
Hmm, make the bulk of the autovac daemon be a shlib that is dynamically
linked by just that subprocess? Yeah, that might work.
We certainly don't want to
On Mon, 2004-08-02 at 21:36, Bruce Momjian wrote:
Tom Lane wrote:
I'm not sure what we do now. I can't apply this in its current state,
and I do not have time to fix it. I don't really want to push it in
and assume we can fix the problems during beta ...
I see. :-(
I know Matthew
On Mon, 2004-08-02 at 21:53, Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
As far as libpq, can't pg_autovacuum dynamically load libpq like dblink
does?
Hmm, make the bulk of the autovac daemon be a shlib that is dynamically
linked by just that subprocess? Yeah, that might
On Mon, 2004-08-02 at 19:26, Tom Lane wrote:
I looked over this patch (sorry for the delay), and found a number of
problems.
Thanks for the feedback, hopefully we can still get something in place
for 7.5.
Bigger problems:
* I don't think you've thought through system shutdown at all. The
Patch applied. Thanks.
---
Matthew T. O'Connor wrote:
On Fri, 2004-07-23 at 23:25, Tom Lane wrote:
Matthew T. O'Connor [EMAIL PROTECTED] writes:
Peter Eisentraut wrote:
I'm not sure whether we can allow int8
[ Oops, I mean added, not applied. ]
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
Bruce Momjian [EMAIL PROTECTED] writes:
Patch applied. Thanks.
What happened to the review part?
regards, tom lane
---(end of broadcast)---
TIP 2: you can get off all lists at once with the unregister command
(send
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
What happened to the review part?
See correction email. I put the wrong header on the email.
Right, I saw that a bit later. Sorry for the noise.
regards, tom lane
---(end of
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
Patch applied. Thanks.
What happened to the review part?
See correction email. I put the wrong header on the email.
--
Bruce Momjian| http://candle.pha.pa.us
[EMAIL PROTECTED] | (610)
Matthew T. O'Connor wrote:
As before, to apply this patch:
1) Move pg_autovacuum.c and .h get from contrib to
src/backend/postmaster and src/include/postmaster respectively.
Trivial comment: maybe we can drop the pg_ prefix on the file names.
2) Place the attached pg_autovacuum.h in
Peter Eisentraut wrote:
Matthew T. O'Connor wrote:
As before, to apply this patch:
1) Move pg_autovacuum.c and .h get from contrib to
src/backend/postmaster and src/include/postmaster respectively.
Trivial comment: maybe we can drop the pg_ prefix on the file names.
Ok, that's not a problem.
Matthew T. O'Connor wrote:
Peter Eisentraut wrote:
Matthew T. O'Connor wrote:
As before, to apply this patch:
1) Move pg_autovacuum.c and .h get from contrib to
src/backend/postmaster and src/include/postmaster respectively.
Trivial comment: maybe we can drop the pg_ prefix on the
Peter Eisentraut wrote:
Matthew T. O'Connor wrote:
As before, to apply this patch:
1) Move pg_autovacuum.c and .h get from contrib to
src/backend/postmaster and src/include/postmaster respectively.
Trivial comment: maybe we can drop the pg_ prefix on the file names.
2) Place the
17 matches
Mail list logo