Andreas Pflug [EMAIL PROTECTED] writes:
Attached the patch, an orgy in #ifdefs, decorated with various indents
and crlf line ends (glad we have pgindent).
I spent a fair amount of time fooling with this, trying to extract
something that I trusted enough to apply at this late date, but got
Tom Lane wrote:
Andreas Pflug [EMAIL PROTECTED] writes:
Attached the patch, an orgy in #ifdefs, decorated with various indents
and crlf line ends (glad we have pgindent).
I spent a fair amount of time fooling with this, trying to extract
something that I trusted enough to apply at this late
Andreas Pflug [EMAIL PROTECTED] writes:
Tom Lane wrote:
but I don't know how to do the equivalent in this threaded scheme
you've devised for Windows.
In pipeThread:
if (!ReadFile(...))
{
DWORD error = GetLastError();
if (error == ERROR_HANDLE_EOF)
exit(0);
Got it.
Tom Lane wrote:
if (!ReadFile(...))
{
DWORD error = GetLastError();
if (error == ERROR_HANDLE_EOF)
exit(0);
Got it. And there's no reason that the pipe thread can't do exit(0)
for itself?
Not really. All threads are equivalent.
BTW, should there be a last NOTICE syslogger shutting
Attached the patch, an orgy in #ifdefs, decorated with various indents
and crlf line ends (glad we have pgindent).
Remarks:
Log_destination for win32 is set to file, because stderr is equivalent
to /dev/null for services. This doesn't reflect correctly in
postgresql.conf.sample.
Bruce Momjian wrote:
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
Do not apply.
I'm investigating issues under win32.
Main
This is the known patch, with following changes:
- realStdErr handed over for EXEC_BACKEND, but still not tested
- Sometimes EMFILE is received in the logger's process queue, when a
backend ended after a SSL connection was interrupted. This is ignored
now (previously it forced an exit(1) and
