Re: [PATCHES] pg_dump --no-tablespaces patch

2008-03-20 Thread Tom Lane
Gavin M. Roy [EMAIL PROTECTED] writes: This is the patch I proposed on hackers to make pg_dump optionally ignore tablespaces. The patch is against 8.2.4. If I should be applying it to CVS head or what not, please let me know (along with any thoughts, concerns or issues). Applied with minor

Re: [PATCHES] pg_dump --no-tablespaces patch

2007-08-30 Thread Gavin M. Roy
I wanted to push to see if I made a version of this patch against CVS head if we could see it included in 8.3. It's of clear value for people who use pg_dump and tablespaces. HOT and tsearch development still continues and implementations of each feature are still being discussed/debated as of

Re: [PATCHES] pg_dump --no-tablespaces patch

2007-08-30 Thread Bruce Momjian
Gavin M. Roy wrote: I wanted to push to see if I made a version of this patch against CVS head if we could see it included in 8.3. It's of clear value for people who use pg_dump and tablespaces. HOT and tsearch development still continues and implementations of each feature are still being

Re: [PATCHES] pg_dump --no-tablespaces patch

2007-08-30 Thread Andrew Dunstan
Bruce Momjian wrote: If you want it in 8.3 you are going to need some community members to take ownership of the patch, take responsibility for it, testing it, etc, and argue that a feature addition that arrived in July should be added. Not impossible, but you are going to need advocates for

Re: [PATCHES] pg_dump --no-tablespaces patch

2007-08-30 Thread Andrew Dunstan
Bruce Momjian wrote: Andrew Dunstan wrote: Bruce Momjian wrote: If you want it in 8.3 you are going to need some community members to take ownership of the patch, take responsibility for it, testing it, etc, and argue that a feature addition that arrived in July should be added. Not

Re: [PATCHES] pg_dump --no-tablespaces patch

2007-08-30 Thread Bruce Momjian
Andrew Dunstan wrote: At this stage we should be kicking things out of the list, not adding to it, IMNSHO. It really doesn't look to me like HOT is ready, from what I can see of the discussion, and desirable as it is I think it should probably wait. Are you saying HOT should

Re: [PATCHES] pg_dump --no-tablespaces patch

2007-08-30 Thread Bruce Momjian
Joshua D. Drake wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Bruce Momjian wrote: Andrew Dunstan wrote: At this stage we should be kicking things out of the list, not adding to HOT too unless there is a short clear path to committal (which seems unlikely given the tenor of

Re: [PATCHES] pg_dump --no-tablespaces patch

2007-07-17 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Gavin M. Roy wrote: This is the patch I proposed on hackers to make pg_dump optionally ignore tablespaces. The

[PATCHES] pg_dump --no-tablespaces patch

2007-07-15 Thread Gavin M. Roy
This is the patch I proposed on hackers to make pg_dump optionally ignore tablespaces. The patch is against 8.2.4. If I should be applying it to CVS head or what not, please let me know (along with any thoughts, concerns or issues). Gavin pg_dump-8.2.4-no-tablespace-option.patch Description:

Re: [PATCHES] pg_dump --no-tablespaces patch

2007-07-15 Thread Dave Page
Gavin M. Roy wrote: This is the patch I proposed on hackers to make pg_dump optionally ignore tablespaces. The patch is against 8.2.4. If I should be applying it to CVS head or what not, please let me know (along with any thoughts, concerns or issues). Hi Gavin, It should be against -head