[PATCHES] bug

2003-11-28 Thread mlavenne2
If PostgreSQL failed to compile on your computer or you found a bug that is likely to be specific to one platform then please fill out this form and e-mail it to [EMAIL PROTECTED] To report any other bug, fill out the form below and e-mail it to [EMAIL PROTECTED] If you not only found the problem

Re: [PATCHES] bug

2003-11-28 Thread Tom Lane
[EMAIL PROTECTED] writes: > I patched it, here my diff -c pg_ctl pg_ctl_fixed: I think you probably broke it rather than fixed it. Checking whether the kill worked isn't a bad idea, but you can't just plow ahead if it failed. regards, tom lane ---

Re: [PATCHES] [pgsql-hackers-win32] pg_ctl

2003-11-28 Thread Bruce Momjian
[ Adding patches list.] Well, I would change the // and use /* */, and remove the C++ code so it is straight C. Also, it should look more like our code, like initdb.c does. --- Joshua D. Drake wrote: > Hello, > >Here

Re: [PATCHES] [pgsql-hackers-win32] pg_ctl

2003-11-28 Thread Neil Conway
This code is pretty awful, IMHO. If you're going to copy code from a 3rd party (in this case, MSDN), it is standard practise to include an attribution. Also, what redistribution terms apply to MSDN sample code? Assuming we don't remove or rewrite the MSDN sample code, it is usually considered goo

Re: [PATCHES] [pgsql-hackers-win32] pg_ctl

2003-11-28 Thread Neil Conway
Neil Conway <[EMAIL PROTECTED]> writes: > This code is pretty awful, IMHO. Also, why is this code still invoking psql manually? ISTM that linking against libpq directly would be much better. -Neil ---(end of broadcast)--- TIP 6: Have you searched

Re: [PATCHES] [pgsql-hackers-win32] pg_ctl

2003-11-28 Thread Bruce Momjian
Yea, I have to agree. It looks like it was written by an MS C programmer, not by a PostgreSQL programmer in terms of style and structure. Sorry for the bad news. --- Neil Conway wrote: > This code is pretty awful, IMHO. >

Re: [PATCHES] [pgsql-hackers-win32] pg_ctl

2003-11-28 Thread Joshua D. Drake
Hello, New version will be resolved next week. Sincerely, Joshua D. Drake Bruce Momjian wrote: [ Adding patches list.] Well, I would change the // and use /* */, and remove the C++ code so it is straight C. Also, it should look more like our code, like initdb.c does. ---

Re: [PATCHES] [pgsql-hackers-win32] pg_ctl

2003-11-28 Thread Joshua D. Drake
Hello, I am addressing these issues with my programmers now. Should see better results next week. Sincerely, Joshua D. Drake Neil Conway wrote: This code is pretty awful, IMHO. If you're going to copy code from a 3rd party (in this case, MSDN), it is standard practise to include an attribu

[PATCHES] pg_autovacuum patches

2003-11-28 Thread Matthew T. O'Connor
Hello, I noticed that there have been a few patched submitted for pg_autovacuum that have not been applied, so I applied them locally and tested them on my Fedora box. I am resubmitting them as one single patch. Included in the attached patch: Brian Hurt's patch that fixed the truncate bug by

Re: [PATCHES] pg_autovacuum patches

2003-11-28 Thread Matthew T. O'Connor
ARRRGGHH ok, with patch this time... On Sat, 2003-11-29 at 00:17, Matthew T. O'Connor wrote: > Hello, > > I noticed that there have been a few patched submitted for pg_autovacuum > that have not been applied, so I applied them locally and tested them on > my Fedora box. I am resubmitting th

[PATCHES] file too large, segmentation fault

2003-11-28 Thread Anjan Dave
Hi All: I am trying to restore a database on a different machine (7.2.3 on Sol9 to 7.2.4 RH8), and i get the following error, that i haven't seen before: -bash-2.05b$ pg_restore -d access -Ft -a access.dump.tar pg_restore: [tar archiver] could not open TOC file for input: File too large Segmen

Re: [PATCHES] file too large, segmentation fault

2003-11-28 Thread Kurt Roeckx
On Sun, Nov 23, 2003 at 10:51:10PM -0500, Anjan Dave wrote: > Hi All: > > I am trying to restore a database on a different machine (7.2.3 on Sol9 to 7.2.4 > RH8), and i get the following error, that i haven't seen before: > > -bash-2.05b$ pg_restore -d access -Ft -a access.dump.tar > pg_restor

Re: [PATCHES] file too large, segmentation fault

2003-11-28 Thread Joshua D. Drake
Hello, Did the dump come from those machines? If so, it is probably not a valid archive anyway because you hit the 2gig limit. My suggestion would be to recompile PostgreSQL with the 64bit file access. Sincerely, Joshua D. Drake Kurt Roeckx wrote: On Sun, Nov 23, 2003 at 10:51:10PM -0500, Anj