Re: [PATCHES] [HACKERS] New pg_ctl has retrogressed in error messages

2004-05-31 Thread Bruce Momjian
Tom Lane wrote: > 7.4, on not finding a postmaster: > > [EMAIL PROTECTED] pgsql]$ pg_ctl stop > /home/tgl/version74/bin/pg_ctl: line 274: kill: (15273) - No such process > waiting for postmaster to shut > down failed > pg_ctl: postma

Re: [PATCHES] [HACKERS] New pg_ctl has retrogressed in error messages

2004-05-31 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > I also changed all the pid variables to use pid_t. Good, but ... > ! fscanf(pidf, "%u", &pid); this code will fail rather horribly if sizeof(pid_t) != sizeof(int). Even more to the point, I believe a standalone backend will put the negative of its

Re: [PATCHES] [HACKERS] New pg_ctl has retrogressed in error messages

2004-05-31 Thread Andrew Dunstan
Tom Lane wrote: Bruce Momjian <[EMAIL PROTECTED]> writes: I also changed all the pid variables to use pid_t. Good, but ... ! fscanf(pidf, "%u", &pid); this code will fail rather horribly if sizeof(pid_t) != sizeof(int). Even more to the point, I believe a standalone backend will p

Re: [PATCHES] [HACKERS] New pg_ctl has retrogressed in error messages

2004-05-31 Thread Bruce Momjian
Andrew Dunstan wrote: > > >this code will fail rather horribly if sizeof(pid_t) != sizeof(int). > >Even more to the point, I believe a standalone backend will put > >the negative of its PID into the file, and the revised code will fail > >to parse that at all. > > > >I think the safest code would

Re: [PATCHES] Fully enabling NLS in pg_ctl

2004-05-31 Thread Bruce Momjian
I have added the setting of local calls to the top of pg_ctl.c. I did not localize ".", nor: printf("%s (PostgreSQL) %s\n", progname, PG_VERSION); This does not change based on locale, and none of our other applications adjust this for locale. I do not know how to add the Russian p

Re: [PATCHES] Fully enabling NLS in pg_ctl

2004-05-31 Thread Serguei A. Mokhov
On Mon, 31 May 2004, Bruce Momjian wrote: > Date: Mon, 31 May 2004 23:31:42 -0400 (EDT) > > I have added the setting of local calls to the top of pg_ctl.c. I did > not localize ".", nor: > > printf("%s (PostgreSQL) %s\n", progname, PG_VERSION); > > This does not change based on locale