This patch fixes the following bugs:
* pg_dump --clean against a pre-7.3 server output drop commands in the
form: DROP .foo; . These will now all be output as: DROP public.foo;
* If you use ALTER USER to set user params on the cluster owner user,
these would not be dumped. This patch will now
Actually, i'm not sure that making it respect -S is the right way to go.
What we really need is an option that specifies the cluster owner on
the new installation.
I will revert that part of this patch and resubmit shortly...
Chris
Christopher Kings-Lynne wrote:
This patch fixes the following
On Wed, 2004-07-14 at 05:45, Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
I think that judgment is exactly backward. *Not* having timelines is
what will cause serious and possibly fatal mistakes during restore:
people will hand the wrong xlog files to restore
I wrote:
close(2);
d = dup(p[0]);
Assert(d == 2);
Having re-read the pipe(2) man page, of course that should be
d = dup(p[1]);
since it's the writing end of the pipe you want to plug stderr into.
BTW, if it wasn't clear: I'd do the same pushup for stdout too,
just in
OK,
This dump is a proper fix for the three bugs mentioned in the first email.
It now just outputs an ALTER USER command for the cluster owner and has
nothing to do with the '-S' switch.
It also fixes the other two issues.
Chris
pg_dump_fixes2.txt.gz
Description: application/gunzip
We could make the same adjustments when opening a new log file rather
than pipe, no?
---
Tom Lane wrote:
I wrote:
close(2);
d = dup(p[0]);
Assert(d == 2);
Having re-read the pipe(2) man page, of course
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
I think that judgment is exactly backward. *Not* having timelines is
what will cause serious and possibly fatal mistakes during restore:
people will hand the wrong xlog files to restore and the software will
be
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
I think it's really important to get this right the first time, both for
reliability's sake and because we are expecting people to write their
own archiving scripts. If we change the xlog segment naming convention
later on, then we will
Tom Lane wrote:
That struck me as not only useless but the deliberately hard way to do
it. To use that in the real world, you'd have to set up a cron job to
trigger the rotation,
Still on my radar...
which means a lot of infrastructure and privilege;
whereas ISTM the point of this feature was to
Fabien COELHO wrote:
Dear patchers,
Please find attached version number 3 for a patch to enable
extensions such as contribs or external add-ons to be installed
simply with an already installed postgresql.
OK, I think we're getting somewhere.
I am still opposed to adding more targets of the
Bruce Momjian wrote:
Patch applied. Thanks.
thanks - that's wonderful news :-)
However the patch as it went in has a minor cosmetic issues with the
display of the --help output.
Maybe something like the attached patch should be applied to restore
the alphabetical option ordering and make the
Bruce Momjian wrote:
Also there are no documenttion changes.
Here are the missing docs, freshly created against cvs.
Regards,
Andreas
Index: func.sgml
===
RCS file: /projects/cvsroot/pgsql-server/doc/src/sgml/func.sgml,v
retrieving
Here is a patch required to build plperl with win32. The issues were:
* perl_useshrplib gets set to yes and not to true. I assume it's set
to true on unix, so I left both.
* Need to translate backslashes into slashes
* The linker config coming out of perl was for MSVC and not for mingw
Some of
On Wed, 2004-07-14 at 16:00, Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
I think it's really important to get this right the first time, both for
reliability's sake and because we are expecting people to write their
own archiving scripts. If we change the xlog
On Wed, 2004-07-14 at 20:03, Alvaro Herrera wrote:
So I have dropped the idea of the propietary syntax. This patch
implements proper savepoint syntax. Includes regression tests but no
documentation is provided yet.
Excellent. Thank you very much for your efforts.
Many thanks, Simon Riggs
Attached is a patch against pg_dump version 7.4.3 that permits
multiple -t switches so that you can select more than one table (but
less than all) to dump.
It also adds a -T switch (long name --exclude-table) that says
*not* to dump a specific table. So:
pg_dump -t table1 -t table2 db
Hmmm, and I need to resurrect the -X use-set-session-authorization flag
for pg_dumpall as well...patch coming soon...
Chris
Stefan Kaltenbrunner wrote:
Bruce Momjian wrote:
Patch applied. Thanks.
thanks - that's wonderful news :-)
However the patch as it went in has a minor cosmetic issues
Hehe - actually, don't commit this either, I keep finding more and more
bugs in pg_dump...
Chris
Christopher Kings-Lynne wrote:
OK,
This dump is a proper fix for the three bugs mentioned in the first email.
It now just outputs an ALTER USER command for the cluster owner and has
nothing to do
Christopher Kings-Lynne wrote:
With \dp having a schema column, how would we display permissions there?
Access privileges for database test
Schema | Name | Type | Access privileges
+--+---+---
public | test | table |
(1 row)
19 matches
Mail list logo
