Re: [PATCHES] fix for Makefile.shlib multiply defined target

2004-11-01 Thread Andrew Dunstan
Well, one of us is confused at least. I am still seeing these warnings. cheers andrew Bruce Momjian wrote: I am told this patch is no longer required. --- Andrew Dunstan wrote: The attached patch fixes a problem with multipl

Re: [PATCHES] Cache last known per-tuple offsets to speed long tuple

2004-11-01 Thread a_ogawa
I remaked patch for "Cache last known per-tuple offsets to speed long tuple access" that is in TODO list. The point of this patch is as follows: (1)Add fields to TupleTableSlot and TupleTableData. This fields are for holding the tuple disassembly information. (2)Add the c

Re: [PATCHES] [HACKERS] make check error on -HEAD

2004-11-01 Thread Magnus Hagander
>>>I have just seen this failure on Windows - it appears to >have nothing to >>>do there with finding an out of date libpq. >> >>Actually, *any* failure in pg_regress's first attempt to invoke psql >>yields this message. I tweaked the script yesterday to not suppress >>stderr; do you have that u

Re: [PATCHES] [HACKERS] make check error on -HEAD

2004-11-01 Thread Bruce Momjian
Patch applied. Thanks. --- Magnus Hagander wrote: > >>>I have just seen this failure on Windows - it appears to > >have nothing to > >>>do there with finding an out of date libpq. > >> > >>Actually, *any* failure in pg_r

Re: [PATCHES] [CYGWIN] Where is the link to cygwin?

2004-11-01 Thread Marek Lewczuk
Bruce Momjian wrote: We just added code to add the *.exe suffix for MinGW and I am hoping this will fix your register problem on Cygwin too. Would you test a recent snapshot and let me know if it works? Latest CVS compilation fails, so I was not able to check pg_ctl. make[4]: Leaving directory `/u

Re: [PATCHES] transformExpr() refactor

2004-11-01 Thread James William Pye
On Thu, 2004-10-28 at 18:00, Neil Conway wrote: > I think the code is more readable this way. FWIW, I'm +1 on the patch for the above reason. -- Regards, James William Pye signature.asc Description: This is a digitally signed message part

Re: [PATCHES] transformExpr() refactor

2004-11-01 Thread Bruce Momjian
James William Pye wrote: -- Start of PGP signed section. > On Thu, 2004-10-28 at 18:00, Neil Conway wrote: > > I think the code is more readable this way. > > FWIW, I'm +1 on the patch for the above reason. I liked the large case statement myself. I don't like breaking things into pieces when th

[PATCHES] pthread.h header check

2004-11-01 Thread Kris Jurka
configure checks for the presense of pthread.h before adjusting CFLAGS to include PTHREAD_CFLAGS. This patch just moves the check down so CFLAGS are set usefully. Kris Jurka ---(end of broadcast)--- TIP 6: Have you searched our list archives?

Re: [PATCHES] pthread.h header check

2004-11-01 Thread Bruce Momjian
Kris Jurka wrote: > > configure checks for the presense of pthread.h before adjusting CFLAGS to > include PTHREAD_CFLAGS. This patch just moves the check down so CFLAGS > are set usefully. I think you forgot to attach the patch. -- Bruce Momjian| http://candle.pha.

Re: [PATCHES] pthread.h header check

2004-11-01 Thread Bruce Momjian
Patch applied. Thanks. --- Kris Jurka wrote: > > > On Tue, 2 Nov 2004, Bruce Momjian wrote: > > > I think you forgot to attach the patch. > > > > Here you go. > > Kris Jurka Content-Description: [ Attachment, skip

Re: [PATCHES] pthread.h header check

2004-11-01 Thread Kris Jurka
On Tue, 2 Nov 2004, Bruce Momjian wrote: > I think you forgot to attach the patch. > Here you go. Kris JurkaIndex: configure.in === RCS file: /projects/cvsroot/pgsql/configure.in,v retrieving revision 1.383 diff -c -r1.383 config