[PATCHES] Kerberos code overwrites it's own error message

2005-03-15 Thread Magnus Hagander
interfaces/libpq/fe-auth, line 621-622: <> if (pg_krb5_sendauth(PQerrormsg, conn->sock, hostname) != STATUS_OK) { snprintf(PQerrormsg, PQERRORMSG_LENGTH, libpq_gettext("K

[PATCHES] Fix that deals with unusable custom variables.

2005-03-15 Thread Thomas Hallgren
This is a bit embarrassing but the patch I submitted that enables custom variable classes (8-10 months ago) was somewhat incomplete. The DefineCustomIntVariable and DefineCustomRealVariable functions doesn't have parameters that make it possible to set the min and max values of the variables. C

[PATCHES] Kerberos on win32

2005-03-15 Thread Magnus Hagander
Hi! Attached patch makes kerberos work on the client-side on win32. This makes it possible to use postgresql on linux in an active directory kerberos environment, with windows clients (with the MIT kerberos for win32 kit installed). I have not yet tested the server side of things, so I expect it n

[PATCHES] WIP: avoiding tuple construction/deconstruction overhead

2005-03-15 Thread Tom Lane
Attached is the current state of a patch to reduce the overhead of passing tuple data up through many levels of plan nodes. It's not tested enough to apply yet, but I thought I'd put it out for comment. It seems to get about a factor of 4 speedup on Miroslav's nested-joins example (above and beyo

Re: [PATCHES] [GENERAL] invalid multibyte character for locale

2005-03-15 Thread Bruce Momjian
Tatsuo Ishii wrote: > Apparently your hack does not kill #define USE_WIDE_UPPER_LOWER. > > BTW, the current code for upper/lower etc. seems to be broken. The > exact problem you have are happening in Japanese encodings too(EUC_JP) > too. PostgreSQL should not use wide-character method if LC_CTYPE

Re: [PATCHES] COPY CSV header line feature

2005-03-15 Thread Alvaro Herrera
On Sun, Mar 13, 2005 at 06:32:20PM -0500, Andrew Dunstan wrote: > The attached patch implements the previously discussed header line > feature for CSV mode COPY. It is triggered by the keyword HEADER (blame > Bruce - he chose it ;-) ). I think you should add the new reserved keyword to the unrese

Re: [PATCHES] Patch that deals with that AtCommit_Portals encounters

2005-03-15 Thread Neil Conway
Thomas Hallgren wrote: This patch will ensure that the hash table iteration performed by AtCommit_Portals is restarted when a portal is deleted. This is necessary since the deletion of a portal may cause the deletion of another which on rare occations may cause the iterator to return a deleted

Re: [PATCHES] COPY CSV header line feature

2005-03-15 Thread Andrew Dunstan
Alvaro Herrera said: > On Sun, Mar 13, 2005 at 06:32:20PM -0500, Andrew Dunstan wrote: > >> The attached patch implements the previously discussed header line >> feature for CSV mode COPY. It is triggered by the keyword HEADER >> (blame Bruce - he chose it ;-) ). > > I think you should add the new

Re: [PATCHES] COPY CSV header line feature

2005-03-15 Thread Alvaro Herrera
On Tue, Mar 15, 2005 at 08:55:36PM -0600, Andrew Dunstan wrote: > Alvaro Herrera said: > > On Sun, Mar 13, 2005 at 06:32:20PM -0500, Andrew Dunstan wrote: > > > >> The attached patch implements the previously discussed header line > >> feature for CSV mode COPY. It is triggered by the keyword HEADE

Re: [PATCHES] COPY CSV header line feature

2005-03-15 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > I think you should add the new reserved keyword to the > unreserved_keywords list or some other. *Every* keyword needs to be in one of those lists. I'd like to have some sort of automatic enforcement of this, because forgetting to add a new keyword to

Re: [PATCHES] Sort psql output

2005-03-15 Thread Neil Conway
Christopher Kings-Lynne wrote: This patch makes \d on tables and views sort fk constraints, triggers and rules alphabetically in the output. This makes it the same as for indexes and stops the irritating random or reverse ordering it currently has. I'll apply this to HEAD later today, barring a

Re: [PATCHES] [pgsql-hackers-win32] [HACKERS] snprintf causes regression tests

2005-03-15 Thread Bruce Momjian
I have applied a modified version of your patch, attached. initdb will not work without %*s support, so I had to add that. Please look over my work. I don't think i handle %*1$ but I am not even sure what that means or if our translators would ever use such a thing. You can probably test that

Re: [PATCHES] [COMMITTERS] pgsql: Handle carriage returns and line feeds in COPY

2005-03-15 Thread Bruce Momjian
Patch applied. Thanks. --- Andrew Dunstan wrote: > > > Neil Conway wrote: > > > Bruce Momjian wrote: > > > >> Handle carriage returns and line feeds in COPY CSV mode. > > > > > > Would it be possible to have some regres

Re: [PATCHES] Patch that deals with that AtCommit_Portals encounters

2005-03-15 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Thomas Hallgren wrote: >> This patch will ensure that the hash table iteration performed by >> AtCommit_Portals is restarted when a portal is deleted. > I'll apply this to HEAD within 24 hours, barring any objections. I don't believe that this actually f

Re: [PATCHES] Patch that deals with that AtCommit_Portals encounters

2005-03-15 Thread Thomas Hallgren
Tom Lane wrote: Neil Conway <[EMAIL PROTECTED]> writes: Thomas Hallgren wrote: This patch will ensure that the hash table iteration performed by AtCommit_Portals is restarted when a portal is deleted. I'll apply this to HEAD within 24 hours, barring any objections. I don't b

Re: [PATCHES] Patch that deals with that AtCommit_Portals encounters

2005-03-15 Thread Tom Lane
Thomas Hallgren <[EMAIL PROTECTED]> writes: > I'm not sure what you mean. Earlier you rejected my bug-report on the > iterator because you it was the callers responsability to deal with it > (hence this patch). Are you now suggesting that we fix that bug instead? Quite honestly, I dunno. I agre