ExecHash() currently returns a null TupleTableSlot, and a misleading
comment from 1991 claims there is a good reason for this. AFAICS there
isn't and the return value isn't used, so I've changed it to return NULL.
Barring any objections I'll apply this tomorrow.
-Neil
Index: src/backend/executor
On Tue, Mar 29, 2005 at 11:48:57PM -0500, Tom Lane wrote:
> Alvaro Herrera <[EMAIL PROTECTED]> writes:
> > This patch removes it, along with an obsolete comment (which refers to a
> > file and function that hasn't existed at all in the whole CVS history.)
>
> I agree that the code is useless, but
I have confirmed that the attached patch works on Cygwin as well as
Windows. Please apply.
cheers
andrew
Andrew Dunstan wrote:
It fixes the build error on Windows - haven't tried because i don't have
time, but I know it won't work on Cygwin, because WIN32 isn't (usually)
defined on Cygwin - see p
Neil Conway wrote:
ExecHash() currently returns a null TupleTableSlot, and a misleading
comment from 1991 claims there is a good reason for this. AFAICS there
isn't and the return value isn't used, so I've changed it to return NULL.
Applied.
-Neil
---(end of broadcast)
Neil Conway wrote:
Andrew Dunstan wrote:
I have confirmed that the attached patch works on Cygwin as well as
Windows. Please apply.
Applied, thanks.
Great that it fixes it... however, I had submitted a tidier patch that
puts the macro in the header (probably after asking Andrew to test the
fi
Mark Kirkwood wrote:
Great that it fixes it... however, I had submitted a tidier patch that
puts the macro in the header
How is this tidier?
(I don't see a reason for pg_buffercache_pages.h at all, actually.)
-Neil
---(end of broadcast)---
TIP 7: don
Andrew Dunstan wrote:
I have confirmed that the attached patch works on Cygwin as well as
Windows. Please apply.
Applied, thanks.
-Neil
---(end of broadcast)---
TIP 8: explain analyze is your friend
