Re: [PATCHES] [HACKERS] Should *.backup files ever be removed from pg_xlog?

2005-06-09 Thread Bruce Momjian
Bruce Momjian wrote: > Tom Lane wrote: > > Bruce Momjian writes: > > > I have fixed the code to properly remove *.backup files from the > > > /pg_xlog directory once they are archived. > > > > I do not actually think that this is a good idea. The .backup files are > > not large and they are pret

Re: [PATCHES] Troff -ms output for psql

2005-06-09 Thread Bruce Momjian
Patch applied, thanks. > Following the commit of my psql latex format fixes, I've re-done the > patch for the troff-ms format which previously included this patch. > It's identical to the original but with the latex hunks removed. -

Re: [PATCHES] (8.1) to_timestamp correction (epoch to timestamptz)

2005-06-09 Thread Bruce Momjian
I have modified your original patch and applied it. Tom mentioned to me privately that none of the AT TIME ZONE clauses is required, probably because epoch is already UTC, and adding seconds to it just keeps it UTC, then it is converted to your local timezone for display. I also found your patch

Re: [PATCHES] to_timestamp overloaded to convert from Unix epoch

2005-06-09 Thread Bruce Momjian
Updated patch attached with both documentation portions --- applied. --- Michael Glaesemann wrote: > Please find attached a patch (diff -c against cvs HEAD) to add a > function that accepts a double precision argument assum

Re: [PATCHES] final light versions of Oracle compatibility (SQLSTATE, GREATEST,

2005-06-09 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Attached is a revised version of this patch. I'll apply it tonight or > tomorrow, barring any objections. I still find the grammar changes to be an ugly kluge --- it should be possible to do this without introducing bogus nonterminals. The ns push/pop op

Re: [PATCHES] final light versions of Oracle compatibility (SQLSTATE,

2005-06-09 Thread Bruce Momjian
Also, do we want these features? Do they duplicate anything we already have? --- Tom Lane wrote: > Neil Conway <[EMAIL PROTECTED]> writes: > > Attached is a revised version of this patch. I'll apply it tonight or > > tomor

Re: [PATCHES] final light versions of Oracle compatibility (SQLSTATE, GREATEST,

2005-06-09 Thread Tom Lane
Bruce Momjian writes: > Also, do we want these features? Do they duplicate anything we already > have? This patch only covers SQLSTATE/SQLERRM for plpgsql, which I think we're now agreed on doing. The other stuff is still open for discussion --- personally I'm OK with the concept of LEAST and G

Re: [PATCHES] [HACKERS] Added schema selection to pg_restore

2005-06-09 Thread Bruce Momjian
Richard van den Berg wrote: > Since I needed this feature badly, I added the -n / --schema switch to > pg_restore. It restores the given schemaname only. It can be used in > conjunction with the -t and other switches to make the selection very > fine grained. > > This patches works for me, but

[PATCHES] Broken code in recent troff commit

2005-06-09 Thread Tom Lane
print.c line 1009: fputs("\(rs", fout); is sufficiently obviously wrong that even my ancient HPUX C compiler is unhappy. I don't know troff, though, so I don't know if "\\(rs" was meant or something else. regards, tom lane ---(end

Re: [PATCHES] Broken code in recent troff commit

2005-06-09 Thread Bruce Momjian
Tom Lane wrote: > print.c line 1009: > fputs("\(rs", fout); > > is sufficiently obviously wrong that even my ancient HPUX C compiler is > unhappy. I don't know troff, though, so I don't know if "\\(rs" was > meant or something else. Yea, fixed. \(rs is reverse slash. -- Bruc

Re: [PATCHES] Broken code in recent troff commit

2005-06-09 Thread Roger Leigh
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Tom Lane <[EMAIL PROTECTED]> writes: > print.c line 1009: > fputs("\(rs", fout); > > is sufficiently obviously wrong that even my ancient HPUX C compiler is > unhappy. I don't know troff, though, so I don't know if "\\(rs" was > meant

Re: [PATCHES] PQgetGetCopyData() doc. and PQsendQueryGuts() SegFault handling fix.

2005-06-09 Thread Tom Lane
Volkan YAZICI <[EMAIL PROTECTED]> writes: > Fixed PQconsumeInput() usage for PQgetCopyData() in libpq.sgml. > (Related mail thread: > http://archives.postgresql.org/pgsql-novice/2005-06/msg00038.php) > Fixed SegFault in PQsendQueryGuts() when user submitted a binary > parameter without size. > An

[PATCHES] fix typo in postmaster.c

2005-06-09 Thread Alvaro Herrera
This trivial patch fixes a typo in StartChildProcess opening comment. Please apply. -- Alvaro Herrera () Management by consensus: I have decided; you concede. (Leonard Liu) Index: postmaster.c === RCS file: /home/alvherre/cvs/pgsql/s

Re: [PATCHES] fix typo in postmaster.c

2005-06-09 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > This trivial patch fixes a typo in StartChildProcess opening comment. > Please apply. Done. regards, tom lane ---(end of broadcast)--- TIP 6: Have you searched our list archives?

Re: [PATCHES] log_line_prefix additions

2005-06-09 Thread Bruce Momjian
qEd L. wrote: > Attached also is a patch to comments in sample postgresql.conf file. > > Subject: [PATCHES] log_line_prefix additions > Date: Wednesday August 25 2004 3:26 > From: "Ed L." <[EMAIL PROTECTED]> > To: pgsql-patches@postgresql.org > > This patch against 8.0.0beta1 source adds log_lin

Re: [PATCHES] Show full path name when saving in psql

2005-06-09 Thread Bruce Momjian
Greg Sabino Mullane wrote: [ There is text before PGP section. ] > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > NotDashEscaped: You need GnuPG to verify this message > > > This patch shows the full path name when doing a \s in psql, > if you have previously issued a \cd command. I have

Re: [PATCHES] plperl features

2005-06-09 Thread Bruce Momjian
Sergej Sergeev wrote: > > >Sergej Sergeev <[EMAIL PROTECTED]> writes: > > > > > >>>What happens if you feed other pseudotypes, like cstring or > >>>language_handler? Shouldn't that be disallowed or something? > >>> > >>> > > > > > > > >>Other pseudo-types are disallowed (no-change) > >>

Re: [PATCHES] final light versions of Oracle compatibility (SQLSTATE,

2005-06-09 Thread Neil Conway
Tom Lane wrote: I still find the grammar changes to be an ugly kluge --- it should be possible to do this without introducing bogus nonterminals. The scope-local variables need to be added to the namespace by the time that we parse the WHEN clauses. I can see two ways to do that: adding a bog

Re: [PATCHES] [HACKERS] PGPASSWORD and client tools

2005-06-09 Thread Bruce Momjian
I have applied this patch, but restructured it to better work in our code. Patch attached. I also added documentation. Another new addition is that we now will check to see that the password file is a regular file and not a symlink or something. This was part of your patch for PGPASSFILE but I

Re: [PATCHES] plperl features

2005-06-09 Thread Tom Lane
Bruce Momjian writes: > Also, I don't think the arg_is_p variable is really the proper fix for > this, but I am unsure what to recomment. Others? The thing I didn't like about that was that it assumes there is only one pseudotype behavior that is or ever will be interesting for plperl. I think

Re: [PATCHES] final light versions of Oracle compatibility (SQLSTATE, GREATEST,

2005-06-09 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> I still find the grammar changes to be an ugly kluge --- it should be >> possible to do this without introducing bogus nonterminals. > The scope-local variables need to be added to the namespace by the time > that we parse the WHEN clau

Re: [PATCHES] [HACKERS] PGPASSWORD and client tools

2005-06-09 Thread Tom Lane
Bruce Momjian writes: > charpgpassfile[MAXPGPATH]; > ! if (!pgpassfile) > ! { > ! fprintf(stderr, libpq_gettext("out of memory\n")); > ! return NULL; > ! } Waste of code, eh? re

Re: [PATCHES] [HACKERS] PGPASSWORD and client tools

2005-06-09 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > charpgpassfile[MAXPGPATH]; > > > ! if (!pgpassfile) > > ! { > > ! fprintf(stderr, libpq_gettext("out of memory\n")); > > ! return NULL; > > ! } > > Waste of code, eh? Ne

Re: [PATCHES] final light versions of Oracle compatibility (SQLSTATE,

2005-06-09 Thread Neil Conway
Tom Lane wrote: Right, mid-rule actions were what I had in mind. They're not uglier than introducing empty nonterminals Well, IMHO they make the grammar rather hard to read when the action has multiple lines (we would need at least 6 lines of code in the mid-rule action, I believe). Unless w

Re: [PATCHES] final light versions of Oracle compatibility (SQLSTATE, GREATEST,

2005-06-09 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Considering that the Bison manual suggests that it implements > mid-rule actions by introducing an implicit bogus non-terminal ([1]), Indeed ... and the reason that they bothered to do that is that mid-rule actions are more understandable ;-). A nontermi