Re: [PATCHES] ADD/DROPS inherits

2006-06-13 Thread Simon Riggs
On Mon, 2006-06-12 at 17:39 -0400, Greg Stark wrote: > Points I'm uncertain about: > > . I throw an elog() error if there's a null conbin for a CHECK constraint. Is > it possible for a valid CHECK constraint structure to have a null conbin? ruleutils shows: elog(ERROR, "null conbin for constra

[PATCHES] ADD/DROPS INHERIT (actually INHERIT / NO INHERIT)

2006-06-13 Thread Greg Stark
I cleaned up the code and added some more documentation. I think I've addressed all the concerns raised so far. Please tell me if I've missed anything. There were a few tangentially related issues that have come up that I think are TODOs. I'm likely to tackle one or two of these next so I'm inte

Re: [PATCHES] ADD/DROPS inherits

2006-06-13 Thread Greg Stark
Simon Riggs <[EMAIL PROTECTED]> writes: > On Mon, 2006-06-12 at 17:39 -0400, Greg Stark wrote: > > > Points I'm uncertain about: > > > > . I throw an elog() error if there's a null conbin for a CHECK constraint. > > Is > > it possible for a valid CHECK constraint structure to have a null con